javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 19:21:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

perf(animations): do not create setTimeout if infinite iterations (#19632)

Browse Source 
closes #19627
This commit is contained in:
Liam DeBeasi
2019-10-11 12:49:54 -04:00
committed by GitHub
parent 589e67e4af
commit 0d699fb2e4
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/utils/animation/animation.ts
View File

@ -819,7 +819,10 @@ export const createAnimation = (): Animation => {
const animationDuration = getDuration() || 0;
const animationIterations = getIterations() || 1;
cssAnimationsTimerFallback = setTimeout(onAnimationEndFallback, animationDelay + (animationDuration * animationIterations) + ANIMATION_END_FALLBACK_PADDING_MS);
// No need to set a timeout when animation has infinite iterations
if (isFinite(animationIterations)) {
cssAnimationsTimerFallback = setTimeout(onAnimationEndFallback, animationDelay + (animationDuration * animationIterations) + ANIMATION_END_FALLBACK_PADDING_MS);
}
animationEnd(elements[0], () => {
clearCSSAnimationsTimeout();