From ea8c9892eee92df3ce78d30be2bf07c5aca095ef Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Sun, 31 Jan 2016 04:26:25 +0100 Subject: [PATCH 1/4] Fixes #5152 issue --- ionic/components/alert/alert.ios.scss | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ionic/components/alert/alert.ios.scss b/ionic/components/alert/alert.ios.scss index f98b1738b8..d6c7c13fa2 100644 --- a/ionic/components/alert/alert.ios.scss +++ b/ionic/components/alert/alert.ios.scss @@ -212,9 +212,15 @@ ion-alert { // iOS Alert Button // -------------------------------------------------- +.alert-button-group { + flex-wrap: wrap; + margin-right: -1px; +} + .alert-button { margin: 0; - flex: 1; + flex: 1 1 auto; + min-width: 50%: font-size: $alert-ios-button-font-size; min-height: $alert-ios-button-min-height; border-radius: $alert-ios-button-border-radius; From 4bab548831f81a6c55aa95f9d90c78b76da12ddf Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Sun, 31 Jan 2016 04:46:45 +0100 Subject: [PATCH 2/4] Fixes typo --- ionic/components/alert/alert.ios.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ionic/components/alert/alert.ios.scss b/ionic/components/alert/alert.ios.scss index d6c7c13fa2..6b93a28c46 100644 --- a/ionic/components/alert/alert.ios.scss +++ b/ionic/components/alert/alert.ios.scss @@ -220,7 +220,7 @@ ion-alert { .alert-button { margin: 0; flex: 1 1 auto; - min-width: 50%: + min-width: 50%; font-size: $alert-ios-button-font-size; min-height: $alert-ios-button-min-height; border-radius: $alert-ios-button-border-radius; From 83984c4de26d5f103a34e27cfc3ab3da9421ab61 Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Sun, 31 Jan 2016 04:58:21 +0100 Subject: [PATCH 3/4] Fixes AlertDialog in material --- ionic/components/alert/alert.md.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/ionic/components/alert/alert.md.scss b/ionic/components/alert/alert.md.scss index d4f504aaa0..ddf1497370 100644 --- a/ionic/components/alert/alert.md.scss +++ b/ionic/components/alert/alert.md.scss @@ -211,6 +211,7 @@ $alert-md-buttons-justify-content: flex-end !default; .alert-button-group { padding: $alert-md-buttons-padding; justify-content: $alert-md-buttons-justify-content; + flex-wrap: wrap-reverse; } .alert-button { From 9ede6f41cd69e7c0e2bcf9a25dc3ce20ae40aae5 Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Sun, 31 Jan 2016 15:36:56 +0100 Subject: [PATCH 4/4] Fixes alertview when displaying more than 2 buttons --- ionic/components/alert/alert.md.scss | 1 + ionic/components/alert/alert.scss | 5 +++++ ionic/components/alert/alert.ts | 2 +- ionic/components/alert/test/basic/index.ts | 19 +++++++++++++++++++ ionic/components/alert/test/basic/main.html | 5 +++-- 5 files changed, 29 insertions(+), 3 deletions(-) diff --git a/ionic/components/alert/alert.md.scss b/ionic/components/alert/alert.md.scss index ddf1497370..9661389f6a 100644 --- a/ionic/components/alert/alert.md.scss +++ b/ionic/components/alert/alert.md.scss @@ -223,6 +223,7 @@ $alert-md-buttons-justify-content: flex-end !default; background-color: $alert-md-button-background-color; border-radius: $alert-md-button-border-radius; text-transform: uppercase; + text-align: right; &.activated { opacity: 1; diff --git a/ionic/components/alert/alert.scss b/ionic/components/alert/alert.scss index b775338754..a1364e3441 100644 --- a/ionic/components/alert/alert.scss +++ b/ionic/components/alert/alert.scss @@ -69,6 +69,11 @@ ion-alert { .alert-button-group { display: flex; flex-direction: row; + + &.vertical { + flex-direction: column; + flex-wrap: nowrap; + } } .alert-button { diff --git a/ionic/components/alert/alert.ts b/ionic/components/alert/alert.ts index 2721c06657..40e8708d07 100644 --- a/ionic/components/alert/alert.ts +++ b/ionic/components/alert/alert.ts @@ -277,7 +277,7 @@ export class Alert extends ViewController { '' + '' + - '
' + + '
' + '' + diff --git a/ionic/components/alert/test/basic/index.ts b/ionic/components/alert/test/basic/index.ts index 658971ddc9..cf734e2e21 100644 --- a/ionic/components/alert/test/basic/index.ts +++ b/ionic/components/alert/test/basic/index.ts @@ -51,6 +51,25 @@ class E2EPage { }); } + doAlertLongMessage() { + let alert = Alert.create({ + title: 'Alert', + message: 'Message text!!!', + buttons: ['Cancel', 'Continue to grant access'] + }); + this.nav.present(alert); + } + + doMultipleButtons() { + let alert = Alert.create({ + title: 'Alert', + subTitle: 'Subtitle', + message: 'This is an alert message.', + buttons: ['Cancel', 'Continue', 'Delete'] + }); + this.nav.present(alert); + } + doPrompt() { let alert = Alert.create(); alert.setTitle('Prompt!'); diff --git a/ionic/components/alert/test/basic/main.html b/ionic/components/alert/test/basic/main.html index f359df4e55..fc742a9cec 100644 --- a/ionic/components/alert/test/basic/main.html +++ b/ionic/components/alert/test/basic/main.html @@ -1,4 +1,3 @@ - Alerts @@ -6,6 +5,8 @@ + + @@ -23,4 +24,4 @@ Checkbox Result: {{testCheckboxResult}} - + \ No newline at end of file