From 0b07b4fb5d369bca2c832fca7a5b9d865ac5c1a1 Mon Sep 17 00:00:00 2001 From: Tim Lancina Date: Fri, 4 Dec 2015 15:31:28 -0600 Subject: [PATCH] fix demo task race condition --- gulpfile.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gulpfile.js b/gulpfile.js index bb0c3d31ff..4d9ec24a91 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -44,6 +44,7 @@ function buildDemoBundle(opts, done) { } return glob(fp, function(err, files){ + var numTasks = files.length; files.forEach(function(file){ var config = require('./scripts/demos/webpack.config.js'); @@ -57,8 +58,6 @@ function buildDemoBundle(opts, done) { filename: path.dirname(file) + '/bundle.js' } - // pretty sure this is a race, but it works - numWebpacks++; webpack(config, function(err, stats){ // var statsOptions = { // 'colors': true, @@ -68,7 +67,7 @@ function buildDemoBundle(opts, done) { // 'errorDetails': true // } // console.log(stats.toString(statsOptions)); - if (--numWebpacks === 0) done(); + if (--numTasks === 0) done(); }) })