From 0aa4748620a80754bbc6f26bea2539cadeb12a19 Mon Sep 17 00:00:00 2001 From: Max Lynch Date: Fri, 25 Oct 2013 21:32:55 -0500 Subject: [PATCH] Fixed #55 It was a scoping issue, $scope.side was getting set to the last one since the side menu wasn't creating a new scope. --- dist/js/ionic-angular.js | 4 +++- js/ext/angular/src/directive/ionicSideMenu.js | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dist/js/ionic-angular.js b/dist/js/ionic-angular.js index 594a8dc65a..ed3a617d5a 100644 --- a/dist/js/ionic-angular.js +++ b/dist/js/ionic-angular.js @@ -741,10 +741,12 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture']) require: '^sideMenuCtrl', replace: true, transclude: true, + scope: { + side: '@' + }, template: '', compile: function(element, attr, transclude) { return function($scope, $element, $attr, sideMenuCtrl) { - $scope.side = attr.side; if($scope.side == 'left') { sideMenuCtrl.left.isEnabled = true; diff --git a/js/ext/angular/src/directive/ionicSideMenu.js b/js/ext/angular/src/directive/ionicSideMenu.js index c9bae40e35..bbe9c3f97c 100644 --- a/js/ext/angular/src/directive/ionicSideMenu.js +++ b/js/ext/angular/src/directive/ionicSideMenu.js @@ -101,10 +101,12 @@ angular.module('ionic.ui.sideMenu', ['ionic.service.gesture']) require: '^sideMenuCtrl', replace: true, transclude: true, + scope: { + side: '@' + }, template: '', compile: function(element, attr, transclude) { return function($scope, $element, $attr, sideMenuCtrl) { - $scope.side = attr.side; if($scope.side == 'left') { sideMenuCtrl.left.isEnabled = true;