From 09b60e05b55bdf409b9b49f09d41c4ea03da3cb7 Mon Sep 17 00:00:00 2001 From: Dan Bucholtz Date: Tue, 9 Jan 2018 13:21:59 -0600 Subject: [PATCH] refactor(nav): make transition fall back to original element --- .../core/src/components/nav/transitions/transition.md.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/core/src/components/nav/transitions/transition.md.ts b/packages/core/src/components/nav/transitions/transition.md.ts index f71b19833a..cc05c6166f 100644 --- a/packages/core/src/components/nav/transitions/transition.md.ts +++ b/packages/core/src/components/nav/transitions/transition.md.ts @@ -63,5 +63,11 @@ function getIonPageElement(element: HTMLElement) { if (element.tagName.toLowerCase() === 'ion-page') { return element; } - return element.querySelector('ion-page'); + const ionPage = element.querySelector('ion-page'); + if (ionPage) { + return ionPage; + } + + // idk, return the original element so at least something animates and we don't have a null pointer + return element; }