From 091b43362b68ba2ab406b673b56716d320570e0c Mon Sep 17 00:00:00 2001 From: "Manu Mtz.-Almeida" Date: Wed, 22 Aug 2018 11:16:35 +0200 Subject: [PATCH] fix(config): using sessionStorage is not safe --- core/src/utils/config.ts | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/core/src/utils/config.ts b/core/src/utils/config.ts index 1dd4da75ea..32228a65d6 100644 --- a/core/src/utils/config.ts +++ b/core/src/utils/config.ts @@ -19,12 +19,20 @@ const IONIC_PREFIX = 'ionic:'; const IONIC_SESSION_KEY = 'ionic-persist-config'; export function configFromSession(): any { - const configStr = window.sessionStorage.getItem(IONIC_SESSION_KEY); - return configStr ? JSON.parse(configStr) : {}; + try { + const configStr = window.sessionStorage.getItem(IONIC_SESSION_KEY); + return configStr ? JSON.parse(configStr) : {}; + } catch { + return {}; + } } export function saveConfig(config: any) { - window.sessionStorage.setItem(IONIC_SESSION_KEY, JSON.stringify(config)); + try { + window.sessionStorage.setItem(IONIC_SESSION_KEY, JSON.stringify(config)); + } catch { + return; + } } export function configFromURL() {