javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 19:21:34 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(all): update types to be required (#16218)

Browse Source
This commit is contained in:
Manu MA
2018-11-03 20:54:58 +01:00
committed by GitHub
parent a9811169fc
commit 091625df64
11 changed files with 34 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
core/src/components/menu/menu.tsx
View File

@ -57,7 +57,7 @@ export class Menu implements ComponentInterface, MenuI {
* The display type of the menu.
* Available options: `"overlay"`, `"reveal"`, `"push"`.
*/
@Prop({ mutable: true }) type!: string;
@Prop({ mutable: true }) type?: string;
@Watch('type')
typeChanged(type: string, oldType: string | undefined) {
@ -143,7 +143,9 @@ export class Menu implements ComponentInterface, MenuI {
@Event() protected ionMenuChange!: EventEmitter<MenuChangeEventDetail>;
async componentWillLoad() {
this.type = this.type || this.config.get('menuType', this.mode === 'ios' ? 'reveal' : 'overlay');
if (this.type === undefined) {
this.type = this.config.get('menuType', this.mode === 'ios' ? 'reveal' : 'overlay');
}
if (this.isServer) {
this.disabled = true;
@ -169,7 +171,7 @@ export class Menu implements ComponentInterface, MenuI {
// add menu's content classes
content.classList.add('menu-content');
this.typeChanged(this.type, undefined);
this.typeChanged(this.type!, undefined);
this.sideChanged();
// register this menu with the app's menu controller
@ -313,7 +315,7 @@ export class Menu implements ComponentInterface, MenuI {
this.animation = undefined;
}
// Create new animation
this.animation = await this.menuCtrl!._createAnimation(this.type, this);
this.animation = await this.menuCtrl!._createAnimation(this.type!, this);
}
private async startAnimation(shouldOpen: boolean, animated: boolean): Promise<void> {