javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-15 09:34:19 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(vue): components have correct name in Vue Dev Tools (#27180)

Browse Source 
<!-- Please refer to our contributing documentation for any questions on
submitting a pull request, or let us know here if you need any help:
https://ionicframework.com/docs/building/contributing -->

<!-- Some docs updates need to be made in the `ionic-docs` repo, in a
separate PR. See
https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#modifying-documentation
for details. -->

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
<!-- Please describe the current behavior that you are modifying. -->


<!-- Issues are required for both bug fixes and features. -->
Issue URL: resolves #25199

Vue components show up as "Anonymous Component" in Vue Dev Tools. This
is caused by our use of `displayName` instead of `name`. This required a
fix in the Vue Output Target package. See
https://github.com/ionic-team/stencil-ds-output-targets/pull/257 for
more info.

## What is the new behavior?
<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Updates the Vue Output Target dependency
- Functional components created manually in Ionic Vue now set `name`
instead of `displayName`. Note: Non-functional components were never
impacted by this bug.

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this introduces a breaking change, please describe the impact
and migration path for existing applications below. -->


## Other information

<!-- Any other information that is important to this PR such as
screenshots of how the component looks before and after the change. -->


Dev build: `7.0.2-dev.11681308435.141a05de`
This commit is contained in:
Liam DeBeasi
2023-04-12 12:50:21 -04:00
committed by GitHub
parent 6fc002458a
commit 07941a59ba
7 changed files with 16 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/vue/src/components/IonApp.ts
View File

@ -16,6 +16,8 @@ export const IonApp = /*@__PURE__*/ defineComponent((_, { attrs, slots }) => {
};
});
IonApp.name = "IonApp";
/**
* When rendering user components inside of
* ion-modal, or ion-popover the component

2
packages/vue/src/components/IonBackButton.ts
View File

@ -36,3 +36,5 @@ export const IonBackButton = /*@__PURE__*/ defineComponent(
};
}
);
IonBackButton.name = "IonBackButton";

2
packages/vue/src/components/IonNav.ts
View File

@ -22,3 +22,5 @@ export const IonNav = /*@__PURE__*/ defineComponent(() => {
return h("ion-nav", { delegate }, views.value);
};
});
IonNav.name = "IonNav";

2
packages/vue/src/vue-component-lib/overlays.ts
View File

@ -173,7 +173,7 @@ export const defineOverlayContainer = <Props extends object>(name: string, defin
const Container = (controller !== undefined) ? createControllerComponent() : createInlineComponent();
Container.displayName = name;
Container.name = name;
Container.props = {
'isOpen': DEFAULT_EMPTY_PROP

2
packages/vue/src/vue-component-lib/utils.ts
View File

@ -184,7 +184,7 @@ export const defineContainer = <Props, VModelType = string | number | boolean>(
};
});
Container.displayName = name;
Container.name = name;
Container.props = {
[ROUTER_LINK_VALUE]: DEFAULT_EMPTY_PROP,