javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-17 18:54:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(a11y): only preventDefault for the onClick event (#22573)

Browse Source
This commit is contained in:
Brandy Carney
2020-11-25 16:56:51 -05:00
committed by GitHub
parent 5275332e43
commit 07868354aa
5 changed files with 12 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
core/src/components/checkbox/checkbox.tsx
View File

@ -114,7 +114,9 @@ export class Checkbox implements ComponentInterface {
}
}
private onClick = () => {
private onClick = (ev: any) => {
ev.preventDefault();
this.setFocus();
this.checked = !this.checked;
this.indeterminate = false;
@ -168,14 +170,6 @@ export class Checkbox implements ComponentInterface {
{labelText}
</label>
<input
onClick={(ev: Event) => {
{/**
* This is needed otherwise any click
* events set on `ion-item` are fired twice
*/}
ev.preventDefault();
ev.stopPropagation()
}}
type="checkbox"
aria-checked={`${checked}`}
disabled={disabled}