javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-19 03:32:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

stop menu animation when closed (#19234)

Browse Source 
fixes #19203
This commit is contained in:
Liam DeBeasi
2019-09-03 12:02:22 -04:00
committed by GitHub
parent c7b302c7a6
commit 07140cf2c5
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/src/components/menu/menu.tsx
View File

@ -379,9 +379,7 @@ export class Menu implements ComponentInterface, MenuI {
const delta = computeDelta(detail.deltaX, this._isOpen, this.isEndSide); const delta = computeDelta(detail.deltaX, this._isOpen, this.isEndSide);
const stepValue = delta / this.width; const stepValue = delta / this.width;
this.animation this.animation.progressStep(stepValue);
.progressStep(stepValue);
} }
private onEnd(detail: GestureDetail) { private onEnd(detail: GestureDetail) {
@ -491,6 +489,10 @@ export class Menu implements ComponentInterface, MenuI {
this.backdropEl.classList.remove(SHOW_BACKDROP); this.backdropEl.classList.remove(SHOW_BACKDROP);
} }
if (this.animation) {
this.animation.stop();
}
// emit close event // emit close event
this.ionDidClose.emit(); this.ionDidClose.emit();
} }

2
core/src/utils/animation/animation.ts
View File

@ -1031,7 +1031,7 @@ export const createAnimation = () => {
}); });
if (initialized) { if (initialized) {
cleanUp(); cleanUpElements();
initialized = false; initialized = false;
} }