From 042ad8e27154fdb7796295be27f0f4e007a0b751 Mon Sep 17 00:00:00 2001
From: Adam Bradley <adamdbradley@gmail.com>
Date: Mon, 10 Feb 2014 11:20:42 -0600
Subject: [PATCH] feature(DOM): Experiment w/ excluding 'ng-scope' and
 'ng-isolate-scope' classnames from elements
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Ultimate goal is to reduce DOM manipulations. It appears 'ng-scope' and
'ng-isolate-scope' classnames are not required for Angular to work. So
in an effort to reduce any DOM manipulations, we’re going to try to
excluding them from being added to elements and see what comes of it.
---
 .../angular/src/service/angularOverrides.js   |  2 +-
 js/ext/angular/test/dom-trace.js              | 25 ++-----------------
 2 files changed, 3 insertions(+), 24 deletions(-)

diff --git a/js/ext/angular/src/service/angularOverrides.js b/js/ext/angular/src/service/angularOverrides.js
index 01daa9ba06..0e9ef4819b 100644
--- a/js/ext/angular/src/service/angularOverrides.js
+++ b/js/ext/angular/src/service/angularOverrides.js
@@ -1,7 +1,7 @@
 
 angular.element.prototype.addClass = function(cssClasses) {
   var x, y, cssClass, el, splitClasses, existingClasses;
-  if (cssClasses) {
+  if (cssClasses && cssClasses != 'ng-scope' && cssClasses != 'ng-isolate-scope') {
     for(x=0; x<this.length; x++) {
       el = this[x];
       if(el.setAttribute) {
diff --git a/js/ext/angular/test/dom-trace.js b/js/ext/angular/test/dom-trace.js
index d4ba419ef5..7242836ec7 100644
--- a/js/ext/angular/test/dom-trace.js
+++ b/js/ext/angular/test/dom-trace.js
@@ -6,8 +6,6 @@
       attributeMutation(m);
     } else if(m.type == 'childList') {
       childListMutation(m);
-    } else if(m.type == 'characterData') {
-      characterDataMutation(m);
     } else if(m.type == 'subtree') {
       attributeMutation(m);
     } else {
@@ -110,11 +108,6 @@
     }
   }
 
-  function characterDataMutation(m) {
-    // target's data are to be observed
-    
-  }
-
   function createElementId(el) {
     var id;
     if(!el) {
@@ -194,10 +187,10 @@
       observer.observe(el, {
         attributes: true, 
         childList: false, 
-        characterData: true,
         subtree: true,
         attributeOldValue: true,
-        characterDataOldValue: true,
+        //characterData: true,
+        //characterDataOldValue: true,
         attributeFilter: true
       });
     }
@@ -206,21 +199,7 @@
 
   var MutationObserver = window.MutationObserver || window.WebKitMutationObserver || window.MozMutationObserver;
 
-  var logColors = {
-    attributesClass: 'purple', 
-    attributesStyle: 'magenta', 
-    childListAdd: 'orange', 
-    childListRemove: 'orangered', 
-    characterData: 'blue',
-    subtree: 'green',
-    attributeOldValue: 'maroon',
-    characterDataOldValue: 'brown',
-    attributeFilter: 'darkblue'
-  };
-
   var ignoreClassNames = [
-    'ng-isolate-scope', 
-    'ng-scope',
     'ng-binding',
     'ng-bind-html'
   ];