diff --git a/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts b/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts index e7102c402a..09e97a369b 100644 --- a/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts +++ b/core/src/components/datetime/test/prefer-wheel/datetime.e2e.ts @@ -148,6 +148,19 @@ test.describe('datetime: prefer wheel', () => { presentation="date" prefer-wheel="true" > + + `); await page.waitForSelector('.datetime-ready'); diff --git a/core/src/components/item/item.mixins.scss b/core/src/components/item/item.mixins.scss deleted file mode 100644 index 3c5ceeb550..0000000000 --- a/core/src/components/item/item.mixins.scss +++ /dev/null @@ -1,9 +0,0 @@ - -// Item Mixins -// -------------------------------------------------- - -@mixin item-push-svg-url($fill) { - $item-detail-push-svg: ""; - - @include svg-background-image($item-detail-push-svg, true); -} diff --git a/core/src/components/item/item.vars.scss b/core/src/components/item/item.vars.scss index f1d1371922..d0ebad2ee1 100644 --- a/core/src/components/item/item.vars.scss +++ b/core/src/components/item/item.vars.scss @@ -1,5 +1,4 @@ @import "../../themes/ionic.globals"; -@import "./item.mixins"; // Item // -------------------------------------------------- diff --git a/core/src/components/menu-button/test/a11y/e2e.ts b/core/src/components/menu-button/test/a11y/e2e.ts deleted file mode 100644 index ca75e6b862..0000000000 --- a/core/src/components/menu-button/test/a11y/e2e.ts +++ /dev/null @@ -1,11 +0,0 @@ -import { AxePuppeteer } from '@axe-core/puppeteer'; -import { newE2EPage } from '@stencil/core/testing'; - -test('menu-button: axe', async () => { - const page = await newE2EPage({ - url: '/src/components/menu-button/test/a11y?ionic:_testing=true', - }); - - const results = await new AxePuppeteer(page).analyze(); - expect(results.violations.length).toEqual(0); -}); diff --git a/core/src/components/menu-button/test/a11y/menu-button.e2e.ts b/core/src/components/menu-button/test/a11y/menu-button.e2e.ts new file mode 100644 index 0000000000..8d3a42fe5e --- /dev/null +++ b/core/src/components/menu-button/test/a11y/menu-button.e2e.ts @@ -0,0 +1,17 @@ +import AxeBuilder from '@axe-core/playwright'; +import { expect } from '@playwright/test'; +import { test } from '@utils/test/playwright'; + +test.describe('menu-button: a11y', () => { + test.beforeEach(({ skip }) => { + skip.rtl(); + }); + + test('should not have accessibility violations', async ({ page }) => { + await page.goto('/src/components/menu-button/test/a11y'); + + const results = await new AxeBuilder({ page }).analyze(); + + expect(results.violations).toEqual([]); + }); +}); diff --git a/core/src/components/menu-button/test/basic/e2e.ts b/core/src/components/menu-button/test/basic/e2e.ts deleted file mode 100644 index 0873820fbb..0000000000 --- a/core/src/components/menu-button/test/basic/e2e.ts +++ /dev/null @@ -1,10 +0,0 @@ -import { newE2EPage } from '@stencil/core/testing'; - -test('menu-button: basic', async () => { - const page = await newE2EPage({ - url: '/src/components/menu-button/test/basic?ionic:_testing=true', - }); - - const compare = await page.compareScreenshot(); - expect(compare).toMatchScreenshot(); -}); diff --git a/core/src/components/menu-button/test/basic/menu-button.e2e.ts b/core/src/components/menu-button/test/basic/menu-button.e2e.ts new file mode 100644 index 0000000000..9daca79fc8 --- /dev/null +++ b/core/src/components/menu-button/test/basic/menu-button.e2e.ts @@ -0,0 +1,16 @@ +import { expect } from '@playwright/test'; +import { test } from '@utils/test/playwright'; + +test.describe('menu-button: basic', () => { + test.beforeEach(({ skip }) => { + skip.rtl(); + }); + + test('should not have visual regressions', async ({ page }) => { + await page.goto(`/src/components/menu-button/test/basic`); + + await page.setIonViewport(); + + expect(await page.screenshot()).toMatchSnapshot(`menu-button-diff-${page.getSnapshotSettings()}.png`); + }); +}); diff --git a/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-ios-ltr-Mobile-Chrome-linux.png b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-ios-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..0a50e679cb Binary files /dev/null and b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-ios-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-ios-ltr-Mobile-Firefox-linux.png b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-ios-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..a01a4d2459 Binary files /dev/null and b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-ios-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-ios-ltr-Mobile-Safari-linux.png b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-ios-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..067191ae33 Binary files /dev/null and b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-ios-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-md-ltr-Mobile-Chrome-linux.png b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-md-ltr-Mobile-Chrome-linux.png new file mode 100644 index 0000000000..9984ae7b65 Binary files /dev/null and b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-md-ltr-Mobile-Chrome-linux.png differ diff --git a/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-md-ltr-Mobile-Firefox-linux.png b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-md-ltr-Mobile-Firefox-linux.png new file mode 100644 index 0000000000..d877753496 Binary files /dev/null and b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-md-ltr-Mobile-Firefox-linux.png differ diff --git a/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-md-ltr-Mobile-Safari-linux.png b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-md-ltr-Mobile-Safari-linux.png new file mode 100644 index 0000000000..9a30db200c Binary files /dev/null and b/core/src/components/menu-button/test/basic/menu-button.e2e.ts-snapshots/menu-button-diff-md-ltr-Mobile-Safari-linux.png differ diff --git a/core/src/components/modal/modal.tsx b/core/src/components/modal/modal.tsx index b4500948ed..804c803dc7 100644 --- a/core/src/components/modal/modal.tsx +++ b/core/src/components/modal/modal.tsx @@ -348,7 +348,7 @@ export class Modal implements ComponentInterface, OverlayInterface { componentWillLoad() { const { breakpoints, initialBreakpoint, swipeToClose, el } = this; - this.inheritedAttributes = inheritAttributes(el, ['role']); + this.inheritedAttributes = inheritAttributes(el, ['aria-label', 'role']); /** * If user has custom ID set then we should @@ -879,11 +879,8 @@ export class Modal implements ComponentInterface, OverlayInterface { return ( } -