javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-08-18 03:00:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(react): handle undefined attributes better, fixes #19563, #19580 (#19588)

Browse Source
This commit is contained in:
Ely Lucas
2019-10-09 10:36:25 -06:00
committed by GitHub
parent 7ce916cc7c
commit 033abe994b
10 changed files with 22 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/react/src/components/createOverlayComponent.tsx
View File

@ -2,7 +2,7 @@ import { OverlayEventDetail } from '@ionic/core';
import React from 'react';
import ReactDOM from 'react-dom';
import { attachEventProps } from './utils';
import { attachProps } from './utils';
interface OverlayElement extends HTMLElement {
present: () => Promise<void>;
@ -68,7 +68,7 @@ export const createOverlayComponent = <T extends object, OverlayType extends Ove
componentProps: {}
});
attachEventProps(overlay, elementProps, prevProps);
attachProps(overlay, elementProps, prevProps);
await overlay.present();
}