diff --git a/ionic/components/segment/segment.js b/ionic/components/segment/segment.js index 5af0682857..8f14388d9d 100644 --- a/ionic/components/segment/segment.js +++ b/ionic/components/segment/segment.js @@ -65,7 +65,7 @@ export class Segment { static get config() { return { selector: 'ion-segment', - appInjector: [ NgFormControl ], + appInjector: [ NgControl ], properties: [ 'value' ], @@ -85,7 +85,7 @@ export class Segment { } constructor( - cd: NgFormControl, + cd: NgControl, elementRef: ElementRef, renderer: Renderer ) { @@ -135,9 +135,9 @@ export class Segment { */ selected(segmentButton) { for(let button of this.buttons) { - button.setActive(false); + button.isActive = false; } - segmentButton.setActive(true); + segmentButton.isActive = true; //this.onChange(); @@ -147,7 +147,7 @@ export class Segment { this.cd.valueAccessor.writeValue(segmentButton.value); this.selectFromValue(segmentButton.value); - this.cd.form.updateValue(segmentButton.value); + this.cd.control.updateValue(segmentButton.value); // Trigger on change this.change.next(); @@ -185,10 +185,6 @@ export class SegmentButton { this.segment.register(this); } - setActive(isActive) { - this.isActive = isActive; - } - buttonClicked(event) { this.segment.selected(this, event); event.preventDefault(); diff --git a/ionic/components/segment/test/basic/index.js b/ionic/components/segment/test/basic/index.js index e9262fc8bc..f2fe17e570 100644 --- a/ionic/components/segment/test/basic/index.js +++ b/ionic/components/segment/test/basic/index.js @@ -4,26 +4,21 @@ import {formDirectives, FormBuilder, Validators, Control, ControlGroup} from 'an import {IonicView} from 'ionic/ionic'; -@Component({ selector: 'ion-app' }) +@Component({ + selector: 'ion-app', + appInjector: [FormBuilder] +}) @IonicView({ templateUrl: 'main.html', directives: [formDirectives] }) class IonicApp { - constructor() { + constructor(fb: FormBuilder) { - this.mapStyle = new Control("hybrid", Validators.required); - this.form = new ControlGroup({ - "mapStyle": this.mapStyle - }); - - /* - var fb = new FormBuilder(); - this.form = fb.group({ + this.myForm = fb.group({ mapStyle: ['hybrid', Validators.required] }); - */ - console.log(this.form); + console.log(this.myForm); } doSubmit(event) { diff --git a/ionic/components/segment/test/basic/main.html b/ionic/components/segment/test/basic/main.html index 31e918ff3b..8e132994f4 100644 --- a/ionic/components/segment/test/basic/main.html +++ b/ionic/components/segment/test/basic/main.html @@ -1,7 +1,6 @@ -
-
- + + Standard @@ -12,20 +11,19 @@ Satellite -
- Map mode: {{form.controls.mapStyle.value}} + Map mode: {{myForm.controls.mapStyle.value}} -
-
+
+

Standard

-
+

Hybrid

-
+

Satellite!!