From 0134d11245cc43dfa1fd9928efe3c72a8a6c2b83 Mon Sep 17 00:00:00 2001 From: Ken Sodemann Date: Fri, 17 Nov 2017 20:29:25 -0600 Subject: [PATCH] refactor(demo): rename basic inputs page --- ...inputs.e2e-spec.ts => basic-inputs.e2e-spec.ts} | 10 +++++----- .../demo/e2e/{inputs.po.ts => basic-inputs.po.ts} | 4 ++-- .../angular/demo/src/app/app-routing.module.ts | 2 +- .../basic-inputs-page.component.css} | 0 .../basic-inputs-page.component.html} | 2 +- .../basic-inputs-page.component.spec.ts} | 10 +++++----- .../basic-inputs-page.component.ts} | 8 ++++---- .../basic-inputs-routing.module.ts} | 6 +++--- .../src/app/basic-inputs/basic-inputs.module.ts | 14 ++++++++++++++ .../demo/src/app/home/home-page.component.html | 2 +- .../angular/demo/src/app/inputs/inputs.module.ts | 14 -------------- 11 files changed, 36 insertions(+), 36 deletions(-) rename packages/angular/demo/e2e/{inputs.e2e-spec.ts => basic-inputs.e2e-spec.ts} (93%) rename packages/angular/demo/e2e/{inputs.po.ts => basic-inputs.po.ts} (94%) rename packages/angular/demo/src/app/{inputs/inputs-test-page.component.css => basic-inputs/basic-inputs-page.component.css} (100%) rename packages/angular/demo/src/app/{inputs/inputs-test-page.component.html => basic-inputs/basic-inputs-page.component.html} (99%) rename packages/angular/demo/src/app/{inputs/inputs-test-page.component.spec.ts => basic-inputs/basic-inputs-page.component.spec.ts} (71%) rename packages/angular/demo/src/app/{inputs/inputs-test-page.component.ts => basic-inputs/basic-inputs-page.component.ts} (68%) rename packages/angular/demo/src/app/{inputs/inputs-routing.module.ts => basic-inputs/basic-inputs-routing.module.ts} (56%) create mode 100644 packages/angular/demo/src/app/basic-inputs/basic-inputs.module.ts delete mode 100644 packages/angular/demo/src/app/inputs/inputs.module.ts diff --git a/packages/angular/demo/e2e/inputs.e2e-spec.ts b/packages/angular/demo/e2e/basic-inputs.e2e-spec.ts similarity index 93% rename from packages/angular/demo/e2e/inputs.e2e-spec.ts rename to packages/angular/demo/e2e/basic-inputs.e2e-spec.ts index 7bf1861036..146c7d1c19 100644 --- a/packages/angular/demo/e2e/inputs.e2e-spec.ts +++ b/packages/angular/demo/e2e/basic-inputs.e2e-spec.ts @@ -1,17 +1,17 @@ import { ElementFinder, promise } from 'protractor/built'; -import { InputsPage } from './inputs.po'; +import { BasicInputsPage } from './basic-inputs.po'; -describe('Demo Inputs Page', () => { - let page: InputsPage; +describe('Basic Inputs Page', () => { + let page: BasicInputsPage; beforeEach(() => { - page = new InputsPage(); + page = new BasicInputsPage(); }); it('should display title', () => { page.navigateTo(); - expect(page.getTitleText()).toEqual('Ionic Core Inputs Demo'); + expect(page.getTitleText()).toEqual('Ionic Core Basic Inputs Demo'); }); describe('text input', () => { diff --git a/packages/angular/demo/e2e/inputs.po.ts b/packages/angular/demo/e2e/basic-inputs.po.ts similarity index 94% rename from packages/angular/demo/e2e/inputs.po.ts rename to packages/angular/demo/e2e/basic-inputs.po.ts index 8ab72fea47..2850dcd9ad 100644 --- a/packages/angular/demo/e2e/inputs.po.ts +++ b/packages/angular/demo/e2e/basic-inputs.po.ts @@ -1,8 +1,8 @@ import { browser, by, element } from 'protractor'; -export class InputsPage { +export class BasicInputsPage { navigateTo() { - return browser.get('/inputs'); + return browser.get('/basic-inputs'); } getIonicCheckbox() { diff --git a/packages/angular/demo/src/app/app-routing.module.ts b/packages/angular/demo/src/app/app-routing.module.ts index 715990e080..c9849064f5 100644 --- a/packages/angular/demo/src/app/app-routing.module.ts +++ b/packages/angular/demo/src/app/app-routing.module.ts @@ -3,7 +3,7 @@ import { Routes, RouterModule } from '@angular/router'; const routes: Routes = [ { path: '', redirectTo: '/home', pathMatch: 'full' }, - { path: 'inputs', loadChildren: 'app/inputs/inputs.module#InputsModule' }, + { path: 'basic-inputs', loadChildren: 'app/basic-inputs/basic-inputs.module#BasicInputsModule' }, { path: 'home', loadChildren: 'app/home/home.module#HomeModule' } ]; diff --git a/packages/angular/demo/src/app/inputs/inputs-test-page.component.css b/packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.css similarity index 100% rename from packages/angular/demo/src/app/inputs/inputs-test-page.component.css rename to packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.css diff --git a/packages/angular/demo/src/app/inputs/inputs-test-page.component.html b/packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.html similarity index 99% rename from packages/angular/demo/src/app/inputs/inputs-test-page.component.html rename to packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.html index f0035e8ca7..2f3eb0e960 100644 --- a/packages/angular/demo/src/app/inputs/inputs-test-page.component.html +++ b/packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.html @@ -1,5 +1,5 @@
- Ionic Core Inputs Demo + Ionic Core Basic Inputs Demo
diff --git a/packages/angular/demo/src/app/inputs/inputs-test-page.component.spec.ts b/packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.spec.ts similarity index 71% rename from packages/angular/demo/src/app/inputs/inputs-test-page.component.spec.ts rename to packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.spec.ts index 7088b92f8d..a3ae0561e7 100644 --- a/packages/angular/demo/src/app/inputs/inputs-test-page.component.spec.ts +++ b/packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.spec.ts @@ -4,16 +4,16 @@ import { FormsModule } from '@angular/forms'; import { By } from '@angular/platform-browser'; import { SharedModule } from '../shared/shared.module'; -import { InputsTestPageComponent } from './inputs-test-page.component'; +import { BasicInputsPageComponent } from './basic-inputs-page.component'; describe('InputsTestPageComponent', () => { - let component: InputsTestPageComponent; - let fixture: ComponentFixture; + let component: BasicInputsPageComponent; + let fixture: ComponentFixture; beforeEach( async(() => { TestBed.configureTestingModule({ - declarations: [InputsTestPageComponent], + declarations: [BasicInputsPageComponent], imports: [FormsModule, SharedModule], schemas: [CUSTOM_ELEMENTS_SCHEMA] }).compileComponents(); @@ -21,7 +21,7 @@ describe('InputsTestPageComponent', () => { ); beforeEach(() => { - fixture = TestBed.createComponent(InputsTestPageComponent); + fixture = TestBed.createComponent(BasicInputsPageComponent); component = fixture.componentInstance; fixture.detectChanges(); }); diff --git a/packages/angular/demo/src/app/inputs/inputs-test-page.component.ts b/packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.ts similarity index 68% rename from packages/angular/demo/src/app/inputs/inputs-test-page.component.ts rename to packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.ts index 45ccd0956e..165832f283 100644 --- a/packages/angular/demo/src/app/inputs/inputs-test-page.component.ts +++ b/packages/angular/demo/src/app/basic-inputs/basic-inputs-page.component.ts @@ -1,12 +1,12 @@ import { Component, OnInit, ViewEncapsulation } from '@angular/core'; @Component({ - selector: 'app-inputs-test-page', - templateUrl: './inputs-test-page.component.html', - styleUrls: ['./inputs-test-page.component.css'], + selector: 'app-basic-inputs-page', + templateUrl: './basic-inputs-page.component.html', + styleUrls: ['./basic-inputs-page.component.css'], encapsulation: ViewEncapsulation.None }) -export class InputsTestPageComponent implements OnInit { +export class BasicInputsPageComponent implements OnInit { textareaValue = 'This is the Textarea Input'; textValue = 'This is the Text Input'; diff --git a/packages/angular/demo/src/app/inputs/inputs-routing.module.ts b/packages/angular/demo/src/app/basic-inputs/basic-inputs-routing.module.ts similarity index 56% rename from packages/angular/demo/src/app/inputs/inputs-routing.module.ts rename to packages/angular/demo/src/app/basic-inputs/basic-inputs-routing.module.ts index bb8c507348..564c209416 100644 --- a/packages/angular/demo/src/app/inputs/inputs-routing.module.ts +++ b/packages/angular/demo/src/app/basic-inputs/basic-inputs-routing.module.ts @@ -1,14 +1,14 @@ import { NgModule } from '@angular/core'; import { Routes, RouterModule } from '@angular/router'; -import { InputsTestPageComponent } from './inputs-test-page.component'; +import { BasicInputsPageComponent } from './basic-inputs-page.component'; const routes: Routes = [ - { path: '', component: InputsTestPageComponent } + { path: '', component: BasicInputsPageComponent } ]; @NgModule({ imports: [RouterModule.forChild(routes)], exports: [RouterModule] }) -export class InputsRoutingModule { } +export class BasicInputsRoutingModule { } diff --git a/packages/angular/demo/src/app/basic-inputs/basic-inputs.module.ts b/packages/angular/demo/src/app/basic-inputs/basic-inputs.module.ts new file mode 100644 index 0000000000..ad1e926256 --- /dev/null +++ b/packages/angular/demo/src/app/basic-inputs/basic-inputs.module.ts @@ -0,0 +1,14 @@ +import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core'; +import { FormsModule } from '@angular/forms'; +import { CommonModule } from '@angular/common'; +import { BasicInputsPageComponent } from './basic-inputs-page.component'; + +import { SharedModule } from '../shared/shared.module'; +import { BasicInputsRoutingModule } from './basic-inputs-routing.module'; + +@NgModule({ + imports: [CommonModule, FormsModule, BasicInputsRoutingModule, SharedModule], + declarations: [BasicInputsPageComponent], + schemas: [CUSTOM_ELEMENTS_SCHEMA] +}) +export class BasicInputsModule {} diff --git a/packages/angular/demo/src/app/home/home-page.component.html b/packages/angular/demo/src/app/home/home-page.component.html index 8b2cbc2d24..83cafad7cf 100644 --- a/packages/angular/demo/src/app/home/home-page.component.html +++ b/packages/angular/demo/src/app/home/home-page.component.html @@ -2,4 +2,4 @@ Ionic Core Angular Demo Application -Inputs Test Page +Basic Inputs Test Page diff --git a/packages/angular/demo/src/app/inputs/inputs.module.ts b/packages/angular/demo/src/app/inputs/inputs.module.ts deleted file mode 100644 index bafb1b94f7..0000000000 --- a/packages/angular/demo/src/app/inputs/inputs.module.ts +++ /dev/null @@ -1,14 +0,0 @@ -import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core'; -import { FormsModule } from '@angular/forms'; -import { CommonModule } from '@angular/common'; -import { InputsTestPageComponent } from './inputs-test-page.component'; - -import { SharedModule } from '../shared/shared.module'; -import { InputsRoutingModule } from './inputs-routing.module'; - -@NgModule({ - imports: [CommonModule, FormsModule, InputsRoutingModule, SharedModule], - declarations: [InputsTestPageComponent], - schemas: [CUSTOM_ELEMENTS_SCHEMA] -}) -export class InputsModule {}