test(many): replace ionic buttons in e2e tests with native html buttons (#29422)

Issue number: internal

---------

<!-- Please do not submit updates to dependencies unless it fixes an
issue. -->

<!-- Please try to limit your pull request to one type (bugfix, feature,
etc). Submit multiple pull requests if needed. -->

## What is the current behavior?
The `ion-button` component is used in several tests to navigate or show
overlays. This causes screenshot diffs in unrelated tests any time the
UI of the `ion-button` is updated.

## What is the new behavior?
Removes the `ion-button` elements from unrelated tests. 

Did not remove the `ion-button`s from the following tests:
- All `ion-button`s in an `ion-buttons` component
- An `ion-button` inside of a menu
- breadcrumbs/test/basic (uses a clear button in a list header, needs to
be moved)
- input/test/slot
- item/test/buttons
- item/test/colors
- item/test/dividers
- item/test/inputs
- item/test/media
- list-header/test/basic
- ripple-effect/test/basic
- router/test/basic
- router/test/guards
- router-outlet/test/basic
- select/test/slot
- textarea/test/slot

Updates the icon/basic test to use the right icon names by comparing
against the v3 names: https://ionicframework.com/docs/v3/ionicons/

## Does this introduce a breaking change?

- [ ] Yes
- [x] No

---------

Co-authored-by: ionitron <hi@ionicframework.com>
This commit is contained in:
Brandy Carney
2024-05-02 15:20:48 -04:00
committed by GitHub
parent ba5cebf254
commit 0124f3b0b3
669 changed files with 1131 additions and 1246 deletions

View File

@ -112,7 +112,7 @@
<div class="grid-item">
<h2>Popover</h2>
<ion-button onclick="presentPopover(defaultPopover, event)">Present Popover</ion-button>
<button onclick="presentPopover(defaultPopover, event)">Present Popover</button>
<ion-popover class="datetime-popover" id="default-popover">
<ion-datetime></ion-datetime>
</ion-popover>
@ -120,7 +120,7 @@
<div class="grid-item">
<h2>Modal</h2>
<ion-button onclick="presentModal()">Present Modal</ion-button>
<button onclick="presentModal()">Present Modal</button>
</div>
<div class="grid-item">
@ -132,7 +132,7 @@
<div class="grid-item">
<h2>Popover - Custom</h2>
<ion-button id="open-popover">Present Popover</ion-button>
<button id="open-popover">Present Popover</button>
<ion-popover class="datetime-popover" trigger="open-popover" id="custom-popover">
<ion-datetime>
<span slot="title">My Custom Title</span>
@ -146,7 +146,7 @@
<div class="grid-item">
<h2>Modal - Custom</h2>
<ion-button id="open-modal">Present Modal</ion-button>
<button id="open-modal">Present Modal</button>
<ion-modal trigger="open-modal" id="modal">
<ion-datetime>
<span slot="title">My Custom Title</span>

View File

@ -49,7 +49,7 @@
<div class="grid-item">
<h2>Default</h2>
<ion-datetime first-day-of-week="1" value="2022-05-03"></ion-datetime>
<ion-button onclick="increase()">Increase firstDayOfWeek</ion-button>
<button onclick="increase()">Increase firstDayOfWeek</button>
<div>
<span>FirstDayOfWeek: <span id="start-of-week">1</span></span>
</div>

View File

@ -23,7 +23,7 @@
</ion-toolbar>
</ion-header>
<ion-content class="ion-padding">
<ion-button id="open-datetime" onclick="presentPopover(defaultPopover, event)">Present Popover</ion-button>
<button id="open-datetime" onclick="presentPopover(defaultPopover, event)">Present Popover</button>
<ion-popover class="datetime-popover" id="default-popover">
<ion-datetime value="2022-05-03T14:23:00.000Z"></ion-datetime>
</ion-popover>

View File

@ -43,7 +43,7 @@
<div class="grid-item">
<h2>Popover - Fixed (350px)</h2>
<ion-button onclick="presentPopover(defaultPopover, event)">Present Popover</ion-button>
<button onclick="presentPopover(defaultPopover, event)">Present Popover</button>
<ion-popover class="datetime-popover" id="default-popover">
<ion-datetime></ion-datetime>
</ion-popover>
@ -51,7 +51,7 @@
<div class="grid-item">
<h2>Modal - Fixed (350px)</h2>
<ion-button onclick="presentModal()">Present Modal</ion-button>
<button onclick="presentModal()">Present Modal</button>
</div>
<div class="grid-item">
@ -61,7 +61,7 @@
<div class="grid-item">
<h2>Popover - Cover (100%)</h2>
<ion-button onclick="presentPopover(customPopover, event)">Present Popover</ion-button>
<button onclick="presentPopover(customPopover, event)">Present Popover</button>
<ion-popover class="datetime-popover" id="custom-popover">
<ion-datetime size="cover"></ion-datetime>
</ion-popover>
@ -69,7 +69,7 @@
<div class="grid-item">
<h2>Modal - Cover (100%)</h2>
<ion-button onclick="presentModal('cover')">Present Modal</ion-button>
<button onclick="presentModal('cover')">Present Modal</button>
</div>
</div>
</ion-content>