javascript/ionic-framework
1
0
Fork 0
mirror of https://github.com/ionic-team/ionic-framework.git synced 2025-11-10 00:27:41 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tab): props are reactive

Browse Source
This commit is contained in:
Manu Mtz.-Almeida
2018-07-12 18:44:44 +02:00
parent 43f1feccad
commit 00c4c77542
8 changed files with 151 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/src/components/tab/readme.md
View File

@ -217,6 +217,11 @@ If true, hide the tabs on child pages.
Emitted when the current tab is selected.
#### ionTabMutated
Emitted when the tab props mutates. Used internally.
## Methods
#### getTabId()

9
core/src/components/tab/tab.tsx
View File

@ -88,6 +88,11 @@ export class Tab {
*/
@Event() ionSelect!: EventEmitter<void>;
/**
* Emitted when the tab props mutates. Used internally.
*/
@Event() ionTabMutated!: EventEmitter<void>;
componentWillLoad() {
if (Build.isDev) {
if (this.component && this.el.childElementCount > 0) {
@ -99,6 +104,10 @@ export class Tab {
}
}
componentWillUpdate() {
this.ionTabMutated.emit();
}
/** Get the Id for the tab */
@Method()
getTabId(): string|null {