From f548bcb8b5ae53e803583b36742d7fc56433f7e2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E4=BA=91=E6=B8=B8=E5=90=9B?= Date: Thu, 4 Nov 2021 10:04:38 +0800 Subject: [PATCH] fix(style): remove chinese comments in checkbox (#4189) --- DEV_FAQ.md | 8 ++++++++ packages/theme-chalk/src/checkbox.scss | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/DEV_FAQ.md b/DEV_FAQ.md index 52f6ac0797..05fbbbd811 100644 --- a/DEV_FAQ.md +++ b/DEV_FAQ.md @@ -25,3 +25,11 @@ pnpm link --global element-plus ``` > More info see [pnpm link](https://pnpm.io/cli/link). + +## Theme + +We should not write Chinese comments in scss files. + +It will generate warning `@charset "UTF-8";` in the header of css file when built with vite. + +> More info see [#3219](https://github.com/element-plus/element-plus/issues/3219). diff --git a/packages/theme-chalk/src/checkbox.scss b/packages/theme-chalk/src/checkbox.scss index 7af0c8cb39..58d73239d7 100644 --- a/packages/theme-chalk/src/checkbox.scss +++ b/packages/theme-chalk/src/checkbox.scss @@ -180,7 +180,7 @@ $checkbox-bordered-input-width: map.merge( } } @include when(focus) { - /*focus时 视觉上区分*/ + // Visually distinguish when focus .#{$namespace}-checkbox__inner { border-color: var(--el-checkbox-input-border-color-hover); }