From f01edb558e6c9fd432896ae300ef2e3091c2f3c7 Mon Sep 17 00:00:00 2001 From: jeremywu <591449570@qq.com> Date: Thu, 29 Oct 2020 10:40:38 +0800 Subject: [PATCH] fix(popper): fix components used popper with tabindex (#495) --- packages/popover/src/index.vue | 2 -- packages/tooltip/src/index.ts | 6 ------ 2 files changed, 8 deletions(-) diff --git a/packages/popover/src/index.vue b/packages/popover/src/index.vue index 3557d7f533..d3dd101765 100644 --- a/packages/popover/src/index.vue +++ b/packages/popover/src/index.vue @@ -74,7 +74,6 @@ export default defineComponent({ popperClass, pure, showArrow, - tabIndex, transition, visibility, } = this @@ -109,7 +108,6 @@ export default defineComponent({ const _trigger = trigger ? renderTrigger(trigger, { ariaDescribedby: popperId, ref: 'triggerRef', - tabindex: tabIndex, onMouseDown: stop, onMouseUp: stop, ...events, diff --git a/packages/tooltip/src/index.ts b/packages/tooltip/src/index.ts index 2bd9383c8e..c82db29f6a 100644 --- a/packages/tooltip/src/index.ts +++ b/packages/tooltip/src/index.ts @@ -80,10 +80,6 @@ export default defineComponent({ type: Number, default: 0, }, - tabindex: { - type: [Number, String], - default: 0, - }, transition: { type: String, default: 'el-fade-in-linear', @@ -129,7 +125,6 @@ export default defineComponent({ placement, popperOptions, showAfter, - tabindex, transition, trigger, visibleArrow, @@ -147,7 +142,6 @@ export default defineComponent({ placement, showAfter: openDelay || showAfter, // this is for mapping API due to we decided to rename the current openDelay API to showAfter for better readability, showArrow: visibleArrow, - tabIndex: String(tabindex), transition, trigger, popperOptions, // Breakings!: Once popperOptions is provided, the whole popper is under user's control, ElPopper nolonger generates the default options for popper, this is by design if the user wants the full contorl on @PopperJS, read the doc @https://popper.js.org/docs/v2/