From bd2d9b44dcd96f33605e61a9203a66e5e5d770d7 Mon Sep 17 00:00:00 2001 From: Enguerrand des Vaux Date: Sat, 3 Oct 2020 14:35:26 +0200 Subject: [PATCH] fix(popper): re-create popper if destroyed when updating (#385) --- packages/popper/src/popper/index.ts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/packages/popper/src/popper/index.ts b/packages/popper/src/popper/index.ts index 748227787d..c4ceb2f077 100644 --- a/packages/popper/src/popper/index.ts +++ b/packages/popper/src/popper/index.ts @@ -160,6 +160,14 @@ export default function (props: IPopperOptions, { emit }: SetupContext onBlur?: (e: Event) => void } + function update() { + if (popperInstance) { + popperInstance.update() + } else { + initializePopper() + } + } + if (!isManualMode()) { const toggleState = () => { if (visibility.value) { @@ -236,18 +244,10 @@ export default function (props: IPopperOptions, { emit }: SetupContext popperInstance.update() }) - watch(visibility, () => { - if (popperInstance) { - popperInstance.update() - } else { - initializePopper() - } - }) + watch(visibility, update) return { - update() { - popperInstance.update() - }, + update, doDestroy, show, hide,