From 76ee10ab690db7ae0fa82334a0fdedf4817d17df Mon Sep 17 00:00:00 2001 From: tangyongjie <65441198+tyj-321@users.noreply.github.com> Date: Thu, 1 Aug 2024 18:59:58 +0800 Subject: [PATCH] refactor(components): [slider]optimize ts types (#17292) * refactor(components): [slider]Optimize ts types * refactor(components): [slider]fix type check error * refactor(components): [silder]optimize ts types --- packages/components/slider/src/button.ts | 4 ++-- .../components/slider/src/composables/use-slider-button.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/components/slider/src/button.ts b/packages/components/slider/src/button.ts index 14c68ca9c4..117097f208 100644 --- a/packages/components/slider/src/button.ts +++ b/packages/components/slider/src/button.ts @@ -1,7 +1,7 @@ import { placements } from '@popperjs/core' import { buildProps, isNumber } from '@element-plus/utils' import { UPDATE_MODEL_EVENT } from '@element-plus/constants' -import type { ExtractPropTypes, Ref } from 'vue' +import type { ComponentPublicInstance, ExtractPropTypes, Ref } from 'vue' import type Button from './button.vue' export const sliderButtonProps = buildProps({ @@ -24,7 +24,7 @@ export const sliderButtonEmits = { } export type SliderButtonEmits = typeof sliderButtonEmits -export type SliderButtonInstance = InstanceType +export type SliderButtonInstance = ComponentPublicInstance export type ButtonRefs = Record< 'firstButton' | 'secondButton', diff --git a/packages/components/slider/src/composables/use-slider-button.ts b/packages/components/slider/src/composables/use-slider-button.ts index 9613d1f10c..0519bad852 100644 --- a/packages/components/slider/src/composables/use-slider-button.ts +++ b/packages/components/slider/src/composables/use-slider-button.ts @@ -11,6 +11,7 @@ import type { SliderButtonInitData, SliderButtonProps, } from '../button' +import type { TooltipInstance } from '@element-plus/components/tooltip' const { left, down, right, up, home, end, pageUp, pageDown } = EVENT_CODE @@ -19,8 +20,7 @@ const useTooltip = ( formatTooltip: Ref, showTooltip: Ref ) => { - // TODO any is temporary, replace with `TooltipInstance` later - const tooltip = ref() + const tooltip = ref() const tooltipVisible = ref(false)