From 0fb2dc950c315191eec44d8753dffecb95cddbac Mon Sep 17 00:00:00 2001
From: RealityBoy <1923740402@qq.com>
Date: Fri, 2 Dec 2022 13:23:59 +0800
Subject: [PATCH] feat(components): [menu] add `popper-effect` menu attribute
 (#10867)

---
 packages/components/menu/src/menu-item.vue | 4 +---
 packages/components/menu/src/menu.ts       | 5 +++++
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/packages/components/menu/src/menu-item.vue b/packages/components/menu/src/menu-item.vue
index 508147b574..7734a06cef 100644
--- a/packages/components/menu/src/menu-item.vue
+++ b/packages/components/menu/src/menu-item.vue
@@ -15,7 +15,7 @@
         rootMenu.props.collapse &&
         $slots.title
       "
-      :effect="Effect.DARK"
+      :effect="rootMenu.props.popperEffect"
       placement="right"
       :fallback-placements="['left']"
       persistent
@@ -47,7 +47,6 @@ import {
   toRef,
 } from 'vue'
 import ElTooltip from '@element-plus/components/tooltip'
-import { Effect } from '@element-plus/components/popper'
 import { throwError } from '@element-plus/utils'
 import { useNamespace } from '@element-plus/hooks'
 import useMenu from './use-menu'
@@ -106,7 +105,6 @@ export default defineComponent({
     })
 
     return {
-      Effect,
       parentMenu,
       rootMenu,
       active,
diff --git a/packages/components/menu/src/menu.ts b/packages/components/menu/src/menu.ts
index 9f011262f3..7a35b63b1a 100644
--- a/packages/components/menu/src/menu.ts
+++ b/packages/components/menu/src/menu.ts
@@ -66,6 +66,11 @@ export const menuProps = buildProps({
     type: Boolean,
     default: true,
   },
+  popperEffect: {
+    type: String,
+    values: ['dark', 'light'],
+    default: 'dark',
+  },
 } as const)
 export type MenuProps = ExtractPropTypes<typeof menuProps>