From 0ee70e64b5b4f408eada776d6b6020354760293b Mon Sep 17 00:00:00 2001 From: zazzaz Date: Wed, 28 Oct 2020 11:20:41 +0800 Subject: [PATCH] fix: remove popper tabIndex (#486) --- packages/popper/__tests__/popper.spec.ts | 7 ------- packages/popper/src/index.vue | 2 -- packages/popper/src/renderers/popper.ts | 4 ---- packages/popper/src/use-popper/defaults.ts | 5 ----- 4 files changed, 18 deletions(-) diff --git a/packages/popper/__tests__/popper.spec.ts b/packages/popper/__tests__/popper.spec.ts index 8c0a8de7c2..39bf9a37e5 100644 --- a/packages/popper/__tests__/popper.spec.ts +++ b/packages/popper/__tests__/popper.spec.ts @@ -160,13 +160,6 @@ describe('Popper.vue', () => { ) }) - test('should add tab index to referrer', async () => { - const wrapper = _mount({ - appendToBody: false, - }) - expect(wrapper.find(`.el-popper`).attributes('tabindex')).toBe('0') - }) - test('should initialize a new popper when component mounted', async () => { _mount({ appendToBody: false, diff --git a/packages/popper/src/index.vue b/packages/popper/src/index.vue index b9f145453d..d89629ce5f 100644 --- a/packages/popper/src/index.vue +++ b/packages/popper/src/index.vue @@ -65,7 +65,6 @@ export default defineComponent({ popperId, pure, showArrow, - tabIndex, transition, visibility, } = this @@ -82,7 +81,6 @@ export default defineComponent({ onMouseLeave: onPopperMouseLeave, onAfterEnter, onAfterLeave, - tabindex: tabIndex, visibility, }, [ diff --git a/packages/popper/src/renderers/popper.ts b/packages/popper/src/renderers/popper.ts index 7c934f73de..a72742dcc9 100644 --- a/packages/popper/src/renderers/popper.ts +++ b/packages/popper/src/renderers/popper.ts @@ -13,7 +13,6 @@ interface IRenderPopperProps { popperId: string popperRef?: Ref pure: boolean - tabindex: number visibility: boolean onMouseEnter: () => void onMouseLeave: () => void @@ -33,7 +32,6 @@ export default function renderPopper( popperRef, pure, popperId, - tabindex, visibility, onMouseEnter, onMouseLeave, @@ -73,7 +71,6 @@ export default function renderPopper( id: popperId, ref: popperRef ?? 'popperRef', role: 'tooltip', - tabindex, onMouseEnter, onMouseLeave, onClick: stop, @@ -90,7 +87,6 @@ export default function renderPopper( 'onMouseup', 'onClick', 'id', - 'tabindex', ], ), [[vShow, visibility]], diff --git a/packages/popper/src/use-popper/defaults.ts b/packages/popper/src/use-popper/defaults.ts index 51aa0eb67a..b3163764dd 100644 --- a/packages/popper/src/use-popper/defaults.ts +++ b/packages/popper/src/use-popper/defaults.ts @@ -31,7 +31,6 @@ export type IPopperOptions = { showAfter: number showArrow: boolean strategy: PositioningStrategy - tabIndex: string trigger: Trigger visible: boolean } @@ -130,10 +129,6 @@ export default { type: [String, Array] as PropType, default: DEFAULT_TRIGGER, }, - tabIndex: { - type: String, - default: '0', - }, visible: { type: Boolean, default: undefined,