Files
NativeScript/tns-core-modules
Dick Smith db33cf313c fix: crash on Android Tab-View #6466 (#6467)
* fix: crash on Android Tab-View NativeScript#6466

This fix has been tested in production with no new issues occurring.

Long-term solution would be one of the following, though:
1. reintroduce overrides for `saveState`/`restoreState` in the current PagerAdapter implementation (removed on this commit NativeScript@ac04ede#diff-f1459d509d1432b432c29bcd30e462fbL97)
2. use FragmentPagerAdapter
3. use FragmentStatePagerAdapter

Both 2 and 3 manage the save/restore cycles. The main difference between 2 and 3 is that 2 uses more memory, but allows for quicker switching between Fragments than 3. Since tabs should usually be limited to 5 or less, this may be the best choice to maintain performance, which is important for top level navigation tabs.

When I have more time I may experiment with these options myself to see what the difference to performance and memory consumption is for each.

* refactor: _commitCurrentTransaction method+comment

* chore: fix typo

* fix: missing class definition
2018-11-14 15:53:38 +00:00
..