Commit Graph

888 Commits

Author SHA1 Message Date
Hristo Hristov
ac3c895c89 Fix crash on iOS (#5071)
* Fix crash on iOS where JS object that extend NSObject was not hold into memory.

* TS fix
2017-11-14 13:36:23 +02:00
Hristo Hristov
725475f860 Click next moves the focus to next focusable textfield (#5047)
* Click next moves the focus to next focusable textfield

Fixes https://github.com/NativeScript/NativeScript/issues/5033
When clicking next arrow on the virtual keyboard we were returning true which means we handled the event so the OS doesn't move the focus to the next item. This PR delete the `return true` when the action is `IME_ACTION_NEXT` so that next focusable item is automatically focued

* Fix IME_ACTION_PREVIOUS to raise returnPress event.
Added unit-test that IME_ACTION_PREVIOUS to raise returnPress event.
Refactored text-field-tests
2017-11-10 16:34:47 +02:00
Hristo Hristov
43fbabb5e9 Fixed most module cyclic references. There is one left for ios and android: (#4978)
- http -> http-request -> image-source
that can't be fixed easily and will be removed once we delete image-source module because it is obsolete anyway.
There is one more for android:
- frame -> fragment that could be removed if we use global object.
Updated madge bersion
2017-11-10 15:47:02 +02:00
Hristo Hristov
729b068e7b Fix android search-bar bug (#5046)
* Fix android search-bar bug

Searching twice for the same item in the search bar leads to a bug where `submit` event won't be raised.
This PR fixes https://github.com/NativeScript/NativeScript/issues/5039

* test: include new test page
2017-11-10 15:46:23 +02:00
Nick Iliev
65a50bbf82 fixed removeEventListener super call (#4994) 2017-11-03 12:57:11 +02:00
Vasil Chimev
3e6f465cc8 fix: TextField not secure when keyboardType="number" (#5012) 2017-10-31 18:29:39 +02:00
Panayot Cankov
f7a3a36b9c Housekeeping node tests, renamed to unit-tests (#4936)
Add parsers for the background css shorthand property, make ViewBase unit testable in node environment

Add background parser and linear-gradient parser

Use sticky regexes

Simplify some types, introduce generic Parsed<T> instead of & TokenRange

Apply each parser to return a { start, end, value } object

Move the css selector parser to the css/parser and unify types

Add the first steps toward building homegrown css parser

Add somewhat standards compliant tokenizer, add baseline, rework and shady css parsers

Enable all tests again, skip flaky perf test

Improve css parser tokenizer by converting some char token types to simple string

Implement 'parse a stylesheet'

Add gonzales css-parser

Add parseLib and css-tree perf

Add a thin parser layer that will convert CSS3 tokens to values, for now output is compatible with rework

Make root tsc green

Return the requires of tns-core-modules to use relative paths for webpack to work

Implement support for '@import 'url-string';

Fix function parser, function-token is no-longer neglected

Make the style-scope be able to load from "css" and "css-ast" modules

Add a loadAppCss event so theme can be added to snapshot separately from loaded
2017-10-20 10:42:07 +03:00
Vladimir Amiorkov
2eba7c66e4 Fix for iOS 11 ListView top offset (#4919)
* Changed the default value of the new iOS11 'contentInsetAdjustmentBehavior' property #4916

* Fixed missing ts definitions and added TODOs
2017-10-20 08:38:07 +03:00
Hristo Hristov
7c68953009 Fix clear history transition (#4951)
* fix: Navigation test app added

* Removed native popToBackstack call.
Implemented custom fragment save/restore state.
When navigating back we reverse manually transitions/animations because we no longer add them to navite backstack.
Fragment instance stored on entry.
Animation and Transition listeners now holds reference to entry instead of fragment for easier update of fragment.
Animation and Transition listeners removed when entry removed from backstack.
Animation and Transition removed from fragment when fragment activity is destroyed.

* Revert package.json start up entry
Fixed bug where goBack took the last element in backstack while navigationQueue is not empty.
Fixed bug where goBack to specific entry in the backstack was removing that entry...
Removed duplicated method
Refactored method name
Fixed TS
2017-10-20 08:37:36 +03:00
Dave Coffin
2e09d3714a FIX: Now checking that webView.request.URL is not null before accessing properties on it. (#4830)
- The symptom is the app would crash when web view tries to load
certain (valid) requests.
2017-10-20 08:36:06 +03:00
Eddy Verbruggen
d3a6a3f782 Line-height property breaks text alignment (iOS) (#4909) 2017-10-20 08:35:11 +03:00
Hristo Hristov
1b9610b4dd The original issue described here: https://github.com/NativeScript/NativeScript/issues/4804 is fixed in 3.2 but there is another bug which doesn't render borderRadius on Image element. (#4963) 2017-10-20 08:33:08 +03:00
Panayot Cankov
188c1f2568 Hanlde hint color reset properly in iOS (#4968) 2017-10-20 08:31:18 +03:00
Panayot Cankov
69199a5df2 Fix hint color in ios, the attributedPlaceholder and placeholder was set following two very distinct paths (#4945) 2017-10-18 16:10:23 +03:00
Peter Kanev
374f31cbf7 fix(minor): reword missing-xml-error to be clearer (#4947) 2017-10-18 10:43:17 +03:00
Hristo Hristov
cb6a75c107 Fix crash on API 23 where constantState.newDrawable(nativeView.getResources()); throws exception in Java. (#4959)
Fix https://github.com/bradmartin/nativescript-floatingactionbutton/issues/57
Addition to https://github.com/NativeScript/NativeScript/issues/4728
2017-10-18 10:35:07 +03:00
Peter Kanev
cb029225c3 Elements tab support for iOS Chrome DevTools (#4930)
* add initial implementation of the dom agent for ios

* add implementation of the css agent for ios

* refactor devtools inspector methods to somewhat accomodate ios and android

patch elements dom-node tests to test for ios too

* fix android dom-node test

* fix ios dom-node-tests to mock the ios devtools inspector properly

* fix: minor changes
2017-10-12 11:32:31 +03:00
Panayot Cankov
35be4bc40a Animations improperly reset (#4900)
* Animations improperly reset

* Scope stop and start of animations to avoid blinks
2017-10-03 15:50:09 +03:00
Panayot Cankov
1049fcc251 Revert _applyXMLAttributes to set style, rows, columns and fontAttributes as properties (#4911) 2017-10-03 15:40:27 +03:00
Hristo Hristov
27773e96a6 Initial transitions are ingored on android (as they are on ios) because on API 21+ Transition class requires at least one layout pass before transitions are executed. If we don't ignore it our transition handlers won't execute and frame navigation won't execute because it thinks there is a pending navigation. (#4896)
Fix https://github.com/NativeScript/NativeScript/issues/4895
2017-09-28 09:19:06 +03:00
Hristo Hristov
9b52bbcd29 If you set tap gesture on a button parent (e.g. some layout for example) and set tap handler on the button and click the button there is a chance to execute navigation with clear history. This will remove current fragment and will clear the button listener owner. Still android will fire the click handler and we will throw an exception. (#4898)
Fix https://github.com/NativeScript/NativeScript/issues/4897
2017-09-28 09:17:54 +03:00
Alexander Vakrilov
1e47117179 fix: DatePicker month off by 1 in Android (#4872) 2017-09-26 09:44:33 +03:00
Panayot Cankov
6d7c1ff295 Avoid applying CSS multiple times (#4784)
* Move the applyStyleFromScope to onLoaded, when the views are created and id or className properties are set the CSS selectors are queried and applied multiple times

* Condense the changes when applying properties
2017-09-25 18:32:00 +03:00
Evan Payne
b0577728be Return true if user has consumed the action (#4859)
Based on this: https://developer.android.com/reference/android/widget/TextView.OnEditorActionListener.html
And assuming that the developer will run dismissSoftInput in the owner.dismissSoftInput() only if they need to.
Returning False will close the keyboard regardless.
2017-09-25 15:46:01 +03:00
Nikolay Tsonev
cf48c9f6dd edit broken link (#4799) 2017-09-05 18:22:26 +03:00
Alexander Vakrilov
d0b3e0c536 fix(date-picker): Date picker changed check (#4797) 2017-09-05 13:42:06 +03:00
Alexander Vakrilov
28b6eba9ac TypeScript 2.5 compatibility (#4794) 2017-09-04 14:36:34 +03:00
Brad Martin
a79a83ce82 Typos (#4789) 2017-09-04 11:09:36 +03:00
Panayot Cankov
12c0199fb5 UIScrollViews will now report 'scroll' events and the background in ios will adjust added layers (#4762) 2017-08-29 10:25:45 +03:00
Hristo Hristov
617fa92efc Fix MultiTemplateParser to not eat its closing tag (#4756) 2017-08-25 17:44:10 +03:00
Eddy Verbruggen
f00ec1a966 Add a 'focus' even to text input fields (#4730) 2017-08-25 11:22:47 +03:00
Hristo Hristov
c98443b331 Fix breaking change - nativeView property should have setter (#4750)
Exposed savedInstanceState on LaunchEventArgs so some controls that need Bundle to initialize could get it from there.
2017-08-25 11:13:51 +03:00
Panayot Cankov
d62df3789c Do not change the Android layer types (hardware/software) (#4625) 2017-08-25 10:45:58 +03:00
Panayot Cankov
3a447b6f3f Added @profile on several key methods in the Android lifecycle, refactored by extracting into methods a little (#4685) 2017-08-24 13:10:53 +03:00
Daniel Leal
7b364613da fix: typo on android utils, getPalleteColor to getPaletteColor (#4687)
* fix: typo on android, getPalleteColor to getPaletteColor

* fix: adress comments
2017-08-24 11:55:31 +03:00
Hristo Hristov
b6d5510627 Fix crash where some android Drawables doesn't implement getConstantState... (#4742)
Changed all places where getConstantState was used.
2017-08-24 11:06:33 +03:00
Hristo Hristov
06ad345015 Fix issue 4302 (#4723)
Fix tests for that issue
2017-08-22 09:52:07 +03:00
Hristo Hristov
9bcf4ef460 Removes list-view selected state when rowHeight is set (#4725) 2017-08-22 09:50:54 +03:00
Eddy Verbruggen
6e06eba218 Fixed a bunch of typo's and minor errors in TypeScript definition files. (#4707)
* Fix a bunch of typo's and minor errors in TypeScript definition files.

* Implemented the requested change by @hshristov
2017-08-21 11:22:04 +03:00
Hristo Hristov
bba7a82bdf Disable recycling, refactoring & fixes (#4705)
* Added tests for native view recycling
Disabled android native view recycling
Move toString from view-common to view-base
Fix crash on application restore and navigation back on API26
Added setAsRootView method
Added missing logo into perf-tests/recycling app

* additional fix for image-source-tests. ios is case sensitive.

* Add @private to some internal properties
Fix where padding is not respected when background is reset.
2017-08-17 09:15:35 +03:00
Hristo Hristov
2701ea3c1e Fix failing test on ios 11 (#4686)
Add new perf-test page for view recycling
Changed the initialization of TextTransformation field
2017-08-16 15:19:01 +03:00
Stanimira Vlaeva
08dcfabe82 refactor(date-picker): value converter for month is 1-based (#4656) 2017-08-08 17:07:21 +03:00
Hristo Hristov
24923445bd Image cache is cleared when livesync happens (#4672) 2017-08-08 16:52:39 +03:00
Hristo Hristov
2c27b1ac7a Cache android.widget.SeekBar as SeekBar for better performance (#4669)
* Cache android.widget.SeekBar as SeekBar for better performance
Made singleton listener for SeekBar
Fix slider issue
Add slider test

* Futher refactoring
2017-08-08 16:04:41 +03:00
Alexander Vakrilov
50d399101e Fixes TabView icons changes. (#4666)
* Fixes TabView icons/title changes.

* Access TabLayput trough parent

* TabView icon change example
2017-08-08 13:06:56 +03:00
Hristo Hristov
075e70e336 cache page on forward navigation (#4652)
* cache page on forward navigation
Still some failing navigation tests

* Current page is kept alive when navigating forward
Refactoring code and removing all hacks and flags
Remove one module circular reference

* Disable Page recycling because when there is transition between pages the nativeView stays animated (e.g. when transition is Fade the hidden page nativeView stays with Alpha 0)
Disable recycling if there is native anitmation

* Fix failing tests on ios & android API17
Fix wrong urls in http tests
Made some timer tests async

* Animations are not stored in BackstackEntry instead of Fragment because fragments could die (activity die) and recreated and we lose animations.

* Fix android crash when activity is recreated.
Refactoring transitionListener.
2017-08-07 17:24:12 +03:00
Stanimira Vlaeva
14098d40db fix: set default values to time widgets (#4383) 2017-08-03 22:03:05 +03:00
Vasil Chimev
c26f1c916a Add line-height test page (#4638)
* Add lineHeight property to text-base.d.ts

* Add line-height test page
2017-08-02 09:30:29 +03:00
Hristo Hristov
0f14101238 recycling now happens only if nativeView and android properties are not accessed. (#4627)
recycleNativeView filed now accepts: "always" | "never" | "auto". Always will recycle the nativeView no matter if its nativeView or android proprties are accessed. Never will disable recycling. Auto will recycle it only if nativeView and android properties are not accessed.
2017-08-01 15:04:16 +03:00
Alexander Vakrilov
7983895c8e FIX: Background drawable cache conflicts with local property (#4633) 2017-08-01 11:53:42 +03:00