Commit Graph

25 Commits

Author SHA1 Message Date
Manol Donev
75ee84cdd2 fix(image): fix(image): apply tintColor correctly on iOS (#5546)
only reset image to non-template when tintColor is changed to a non-color (removed)
2018-03-15 18:41:02 +02:00
Hristo Hristov
af034089ca iOS Frame, Page and TabView measure/layout methods removed. We now rely on the framework positioning. This will result in a change that width, height, minWidth, minHeight, margins not respected on these controls
iOS layout positioning now respects native properties like automaticallyAdjustsScrollViewInsets, edgesForExtendedLayout, extendedLayoutIncludesOpaqueBars, navigationBar.translucent, tabBar.translucent
Removed frame-tests.ios.ts - those tests are now invalid
Added new layout tests inside page-tests.ios.ts
Commented few asserts in scroll-view-tests
View now expose ios namespace with layoutView method and UILayoutViewController used by page, tab-view and application module
ViewBase now expose viewController property that should be set from all widgets that are using viewcontrollers internally (like Page, Frame, TabView)
ViewBase now sets ios property to either the view returned from createNativeView or to nativeViewProptected
fragment.transitions now use animation/transition start to add fragments to waitingQueue. Before we did it manually in navigate/goBack. This way we can reuse the fragment.transition when calling showDialog. Also when animation/transition ends we check the animation/transition to see if this fragment should be set as current.
Frame expose new loadViewFromEntry method (to load a view from URI)
Frame navigation happens once frame is loaded
Frame now supports Page as a child in XML
Fixed GridLayout row, rowSpan, column, columnSpan properties type
Fixed bug in GridLayout where add/remove of columns/rows won't update the internal state of the grid (backport from android when GridLayout is recycled)
ListView will no longer invalidate layout when cell is removed
Fixed bug in ScrollView ios where effectiveMinWidth/Height was multiplied to density (it is already on device pixels so no need to multiply)
TabView android now calls loaded only on the selected child (not all)
Core refactoring
2017-12-15 13:06:34 +02:00
Hristo Hristov
0f14101238 recycling now happens only if nativeView and android properties are not accessed. (#4627)
recycleNativeView filed now accepts: "always" | "never" | "auto". Always will recycle the nativeView no matter if its nativeView or android proprties are accessed. Never will disable recycling. Auto will recycle it only if nativeView and android properties are not accessed.
2017-08-01 15:04:16 +03:00
Alexander Vakrilov
23757e5dfc Enable recycling of nativeView 2 (#4467)
* enable recycling of nativeView

* backgroundInternal is reset if setting new value leads to background.isEmpty() == true.

* android background.getDefault always return copy of the background. Now all controls that mutate the background can be reset to initial state (e.g. Button & ActionBar)
passing resources to copied background so it respect density.
fix properties initNativeView

* reset padding when backgroundInternal is reset.

* Fix text reset
Fix padding reset

* fix tsc errors

* fix ugly text rendering.

* Add unit tests for recycling native views
Fix several issues that came from the above tests
Fix maxLength property missing a converter callback
Remove old files

* Remove old files

* Revert backgroundInternal setter

* change the order of tests so that appium can work again

* Remove suggestion on every TextView & TextField init (strangely it is enabled after view is recycled....)

* Fix function to get parent layout if specified

* Button stateListAnimator restored when button is recycled
zIndex defaultValue is now undefined instead of NaN

* revert zIndex.setNative to always clear stateListAnimator because it was breaking one UI test (setting value=0 was returning the previous stateListAnimator)

* fix search-bar backgound-color recycling

* Fix alignments setters

* Fix imageView recycling
Fix button recycling
Fix edit-text recycling
resetNativeView is called only if recycleNativeView flag is true

* Fix incorrect merge

* Fix text-view & text-field textTransform

* Fix EditText text reset

* Fix runtime crash on ARM emulator API 21

* Fix text-base minHeight. maxHeight reset
Fix reset of isUserInteractionEnabled
2017-06-29 18:01:22 +03:00
Hristo Hristov
f2898f84d5 NativeView recycled for android 2017-03-28 18:08:59 +03:00
Panayot Cankov
2b28730011 Split get/set native to getDefault setNative 2017-03-22 16:37:52 +02:00
vakrilov
f29f7cb607 Always set clipToBounds for images, list-view and scroll-view 2017-03-17 15:22:59 +02:00
Panayot Cankov
aac9cc2e3e Fix iOS image scaling to work in px 2017-03-09 10:58:56 +02:00
Panayot Cankov
5265bf0ae3 Animation properties and some backward compatability with the QSF 2017-02-08 10:52:54 +02:00
Rossen Hristov
fec5e92dbe Fix tracing 2017-01-16 13:29:46 +02:00
vakrilov
819155fb18 Minor fixes + more green tests 2017-01-12 16:20:38 +02:00
vakrilov
d17ff9ffbd Use [srcProperty.native] 2017-01-06 15:43:57 +02:00
Panayot Cankov
70cc1dd5d9 Move the effective* values from style to this 2016-12-27 10:57:10 +02:00
Hristo Hristov
19ee47ba24 got to layouts 2016-12-13 15:51:18 +02:00
Hristo Hristov
1202cb7288 almost all without layouts 2016-12-13 15:51:18 +02:00
Hristo Hristov
645f428f59 alpha1 2016-12-13 15:51:18 +02:00
Tsvetan Raikov
1b568b56ca Added tintColor property in Image view. It should be used instead of color 2016-09-16 16:29:08 +03:00
Nathan Walker
465b5bfd77 fix(iOS): image._setColorTint is not a function fix
closes https://github.com/NativeScript/NativeScript/issues/2647
closes https://github.com/NativeScript/nativescript-angular/issues/422
closes https://github.com/jlooper/pocketrave/issues/2
closes https://github.com/jlooper/pocketrave/issues/3
2016-08-30 21:09:18 -07:00
Tsvetan Raikov
afb2d1ea68 Added tintColor property in {N} ImageView 2016-08-29 18:50:44 +03:00
Panayot Cankov
1236f66f44 Add npm script that generates ios .d.ts-es from the tests app
Less than 30 erros left, let's hope it still works

Added lib.*.d.ts from typescript, removed lib and dom stuff, added by hand XHR, alert etc. .d.ts-es for polyfills

Roll back some changes involved in separating UIEvent for dom and ios

Test combined dts-es will now use lib, while internally we will not to avoid UIEvent conflict with dom stuff
2016-08-29 09:58:17 +03:00
Hristo Hristov
8d40782191 Style perf improvements (#2342)
* Add css-perf app.

* Style properties now check only properties that are set.
Image utils module required on top (instead of in onMeasure) to improve performance.
Remove try/catch block when Style applies native property.

* fix tslint

* Fix broken merge
Update package.json version

* Failed miserably - if the try/catch around applyProperty method is removed - TextField fails big time.
TextField needs some good refactoring as well as calls to _updateTextDecoration & _updateTextTransform
utils - setTextTransform & setTextDecoration should be split, typing support should be added.
2016-07-08 14:39:43 +03:00
Panayot Cankov
165a948150 Image won't require in onMeasure; global loadModule cache 2016-06-21 15:02:15 +03:00
Rossen Hristov
4e678a06ff Fix: Images have margin when added to Layout
Resolves #1425
2016-06-14 10:53:07 +03:00
Panayot Cankov
717b5131b1 Add isIOS, isAndroid in platform, and fast ts watcher and transpiler
Image should not requestLayout when sized with 'exactly' spec

Update image tests

Tests will run in ios only
2016-05-27 16:57:59 +03:00
Panayot Cankov
e135c20b14 Rename the files 2016-05-26 14:30:25 +03:00