Commit Graph

38 Commits

Author SHA1 Message Date
Nick Iliev
b58dff0de3 feat(ActionBar): apply text color when largeTitletextAttribute is set on iOS (#6631)
* apply CSS text color when largeTitletextAttribute is set on iOS

* common logic improvment
2018-11-30 11:29:40 +02:00
Alexander Vakrilov
56a1b120af fix: Don't crash on missing resources in tab-view and action-bar (#6388) 2018-10-11 21:31:19 +03:00
Dick Smith
324fdcebcd fix(action-bar): #5743 navController may be null (#6029)
* fix(action-bar): #5743 navController may be null

From my own Crashlytics:
`stderr: file:///app/vendor.js:1:860568: JS ERROR TypeError: null is not an object (evaluating 'a.viewControllers')`
```
file:///app/vendor.js:1:860489
var l,p=a.viewControllers.indexOfObject(n);if(p>0&&p<a.viewControllers.count&&(t=a.viewControllers[p-1]),t)
```
which corresponds to:
2fc1d8a8d4/tns-core-modules/ui/action-bar/action-bar.ios.ts (L132)

further up `navController` is checked for truthiness:
2fc1d8a8d4/tns-core-modules/ui/action-bar/action-bar.ios.ts (L119)

So applying same logic.

* Adjusted per request
2018-07-10 13:22:30 +03:00
Manol Donev
2fc1d8a8d4 chore(tsc): enable noUnusedLocals compiler option for tns-core-modules (#5755) 2018-05-10 16:12:59 +03:00
Alexander Djenkov
c54e069f57 fix(ios-action-bar): NavigationButton cannot be hidden if navigating with transition (#5451) 2018-02-26 09:44:58 +02:00
Hristo Hristov
ac04ede97e Implemented showModal on View 2017-12-15 13:08:15 +02:00
Hristo Hristov
b489e52a5f Fix iOS 11 titleView misplacement in ActionBar 2017-12-15 13:06:34 +02:00
Hristo Hristov
a7ae124ad8 ActionBar is measured the moment we create native buttons otherwise it won't show correctly 2017-12-15 13:06:34 +02:00
Hristo Hristov
af034089ca iOS Frame, Page and TabView measure/layout methods removed. We now rely on the framework positioning. This will result in a change that width, height, minWidth, minHeight, margins not respected on these controls
iOS layout positioning now respects native properties like automaticallyAdjustsScrollViewInsets, edgesForExtendedLayout, extendedLayoutIncludesOpaqueBars, navigationBar.translucent, tabBar.translucent
Removed frame-tests.ios.ts - those tests are now invalid
Added new layout tests inside page-tests.ios.ts
Commented few asserts in scroll-view-tests
View now expose ios namespace with layoutView method and UILayoutViewController used by page, tab-view and application module
ViewBase now expose viewController property that should be set from all widgets that are using viewcontrollers internally (like Page, Frame, TabView)
ViewBase now sets ios property to either the view returned from createNativeView or to nativeViewProptected
fragment.transitions now use animation/transition start to add fragments to waitingQueue. Before we did it manually in navigate/goBack. This way we can reuse the fragment.transition when calling showDialog. Also when animation/transition ends we check the animation/transition to see if this fragment should be set as current.
Frame expose new loadViewFromEntry method (to load a view from URI)
Frame navigation happens once frame is loaded
Frame now supports Page as a child in XML
Fixed GridLayout row, rowSpan, column, columnSpan properties type
Fixed bug in GridLayout where add/remove of columns/rows won't update the internal state of the grid (backport from android when GridLayout is recycled)
ListView will no longer invalidate layout when cell is removed
Fixed bug in ScrollView ios where effectiveMinWidth/Height was multiplied to density (it is already on device pixels so no need to multiply)
TabView android now calls loaded only on the selected child (not all)
Core refactoring
2017-12-15 13:06:34 +02:00
Alexander Vakrilov
2dbd1b19ea Fix: refresh flat property on change in IOS (#4628)
* Fix: refresh flat property on change in IOS

* Fix typos
2017-08-01 10:40:51 +03:00
Eddy Verbruggen
12020bd8bb Implement an ActionBar 'flat' property to remove the bottom border/shadow and (on iOS) translucency (#3900)
* #2740 Feature Request: Improved ActionBar CSS Support

* Now using a dedicated 'flat' property.
2017-07-28 15:30:30 +03:00
Panayot Cankov
43659799bc Implement non uniform border corner radiuses and fix blinking image-view radiuses (#4573)
* Image corners were blinking in #4322 and CSS border will now draw non uniform corner radiuses if the border color is uniform

* Implement per-side corner radiuses for iOS

* Update stretch-mode example

* Update matrix-mode example

* Update image resources

* Add clipping for non uniform radii without border width, don't throw for missing image resources in css
2017-07-27 15:36:47 +03:00
vakrilov
a598e2c90a Ensure navigation title view is removed if undefined 2017-04-06 13:21:23 +03:00
Hristo Hristov
15e4d6a230 ActionBar wasn’t applying native setters becasue it was missing nativeView (#3910) 2017-03-30 18:38:48 +03:00
Hristo Hristov
f2898f84d5 NativeView recycled for android 2017-03-28 18:08:59 +03:00
Panayot Cankov
2b28730011 Split get/set native to getDefault setNative 2017-03-22 16:37:52 +02:00
Hristo Hristov
fe54ac6ead Layout round instead of ceiling (#3833)
* Layout round instead of cailing
Add helper method to layout module to convert to/from dips to px and measure the native view
whiteSpace affects layout added for iOS
Fix bug in switch onMeasure implementation
Fix bug in cssValueToDevicePixels iOS implementation
ActionBar for iOS is measured with AT_MOST modifier

* Fix switch measure routine
2017-03-20 16:11:16 +02:00
Hristo Deshev
629eb6e683 Use relative imports in tns-core-modules.
Use tns-core-modules/* imports in outside code (apps, tests, etc)
2017-03-13 14:37:59 +02:00
Alexander Vakrilov
9ac9e5ab53 Merge pull request #3754 from NativeScript/fix-ios-action-bar-reset
Fix: Action-bar bg-color in ios not resetting
2017-03-09 09:42:54 +02:00
vakrilov
e69bc78111 Fix: Action-bar bg-color in ios not resetting 2017-03-08 13:42:35 +02:00
Panayot Cankov
9f1ebc11ca Add support for 'px' on Length in iOS 2017-03-08 09:01:17 +02:00
Hristo Hristov
ea22eb9c20 refactoring circular imports 2017-03-06 14:05:55 +02:00
Hristo Hristov
a582adc561 Hhristov/fix (#3653)
* Fix action-bar systemIcon
Fix CSS applying

* refactoring

* fix console

* remove StyleScope import - it is private and cannot be imported in public .d.ts
2017-02-17 17:21:57 +02:00
vakrilov
d448f3dc7f Animated nav-bar 2017-01-25 10:48:48 +02:00
vakrilov
cd3cd13075 View tests turned green 2017-01-11 17:34:25 +02:00
PanayotCankov
7931ecd4f8 Fix tslint errors 2016-12-21 17:42:31 +02:00
Hristo Hristov
1202cb7288 almost all without layouts 2016-12-13 15:51:18 +02:00
Hristo Hristov
645f428f59 alpha1 2016-12-13 15:51:18 +02:00
Hristo Hristov
bb2c7aa60a partial state 2016-12-13 15:51:18 +02:00
Hristo Hristov
e4c21258a3 More files migrated. 2016-12-13 15:51:18 +02:00
Hristo Hristov
b58e0b08a3 refactoring 2016-12-13 15:51:18 +02:00
Morten Sjøgren
37d927b077 fix: #2796 - ActionItems lacks proper support for VoiceOver on iOS (#2799)
UIBarButtonItem weren't created with a title/text so VoiceOver couldn't
know what to reads. This marks the element as an AccessibilityElement
and sets an accessibilityLabel.
2016-10-05 16:32:04 +03:00
Panayot Cankov
1236f66f44 Add npm script that generates ios .d.ts-es from the tests app
Less than 30 erros left, let's hope it still works

Added lib.*.d.ts from typescript, removed lib and dom stuff, added by hand XHR, alert etc. .d.ts-es for polyfills

Roll back some changes involved in separating UIEvent for dom and ios

Test combined dts-es will now use lib, while internally we will not to avoid UIEvent conflict with dom stuff
2016-08-29 09:58:17 +03:00
Tsvetan Raikov
8554bb199e Fixed: Action bar doesn't handle events properly when a custom button is added in Angular 2016-06-20 15:53:04 +03:00
Tsvetan Raikov
f3c7aa5a76 Fixed action bar tests 2016-06-17 18:50:18 +03:00
Tsvetan Raikov
6f241ff473 Fixed: Custom ActionItem gets displaced in IOS 2016-06-15 18:25:32 +03:00
Tsvetan Raikov
5d54ae69f4 Fixed a crash in action bar on iOS 9.3 2016-06-08 11:00:58 +03:00
Panayot Cankov
e135c20b14 Rename the files 2016-05-26 14:30:25 +03:00