octicon-git-branch(16/) Commit Graph

14 Commits

Author SHA1 Message Date
Jamie Birch
9e472d7874 docs(core): update comments for on, once, addEventListener and removeEventListener (#10545) 2024-05-23 08:26:03 -07:00 octicon-file-diff(16/) octicon-file-code(16/)
farfromrefuge
0632215793 chore: eslint cleanup (#10160) 2023-01-09 09:40:20 -08:00 octicon-file-diff(16/) octicon-file-code(16/)
Nathan Walker
b147612e06 test: standardized jest unit testing (#10047) 2022-11-28 14:32:25 -08:00 octicon-file-diff(16/) octicon-file-code(16/)
Dimitris-Rafail Katsampas
d82f3d990d fix(core): Added ObservableArray constructor declarations to allow setting multiple arguments (#9980) 2022-07-30 08:23:40 -07:00 octicon-file-diff(16/) octicon-file-code(16/)
Jason Cassidy
01643f513e fix(core): correct typings in ObservableArray (#9961) 2022-07-20 21:38:28 -07:00 octicon-file-diff(16/) octicon-file-code(16/)
Dimitris-Rafail Katsampas
df74a8baa8 feat(core): iterable ObservableArray (#9824)
BREAKING CHANGE:

Method push will now handle arguments just like Array.prototype.push.
Certain existing methods will now return ObservableArray instance instead.
Callback arguments that contained an array argument themselves will now contain an ObservableArray argument.
2022-07-09 10:09:43 -07:00 octicon-file-diff(16/) octicon-file-code(16/)
Nathan Walker
770030e7f6 feat(observable-array): findIndex now supported 2021-04-06 11:18:36 -07:00 octicon-file-diff(16/) octicon-file-code(16/)
matthewianmorgan
3ddfb5c34a fix(core): ObservableArray splice with start only (#9159) 2021-01-31 10:05:37 -08:00 octicon-file-diff(16/) octicon-file-code(16/)
Dimitris - Rafail Katsampas
5fe27428e0 feat(android): FlexboxLayout support for isPassThroughParentEnabled (#8798) 2021-01-29 13:03:27 -08:00 octicon-file-diff(16/) octicon-file-code(16/)
Martin Guillon
c1f231d88e chore: fix eslint issues (#9017) 2020-11-11 08:46:36 -08:00 octicon-file-diff(16/) octicon-file-code(16/)
Nathanael Anderson
5c1b7f6d76 fix(core): ObservableArray tests and a typo (#8968) 2020-10-17 16:15:20 -07:00 octicon-file-diff(16/) octicon-file-code(16/)
Martin Guillon
6d135e5d63 fix(core): ObservableArray splice ensure index is > 0 (#8921)
Otherwise it will crash in ListView for iOS for example as it tries to animate an item with a negative row index
2020-09-30 16:54:54 -07:00 octicon-file-diff(16/) octicon-file-code(16/)
Martin Guillon
65b1cdbae0 fix(core): Observable splice index > length (#8900)
* fix for splice index > length

In javascript you can call splice with an index > length. The result is a push.
But when you do that ObservableArray index will be wrong and thus user logic will fail.
Example:
```ts
// obsarray = [0];
obsarray.splice(2, 0, 1);
// this works, the inner array is now [0,1]
// however 'change' is called with index = 2
// when the use tries to do obsarray.getItem(eventData.index) -> crash
```

* fix to handle delete too
2020-09-27 09:20:52 -07:00 octicon-file-diff(16/) octicon-file-code(16/)
Nathan Walker
020ad4da37 chore(core): monorepo, esm targeting, improved management (#8707) 2020-08-25 20:00:59 -07:00 octicon-file-diff(16/) octicon-file-code(16/)