7fadab1dc8
Merge branch 'master' of github.com:NativeScript/NativeScript
...
# Conflicts:
# package.json
# packages/core/tsconfig.lib.json
# packages/core/ui/frame/index.android.ts
# packages/core/ui/tabs/index.ios.ts
2020-10-28 09:46:54 +01:00
5c1b7f6d76
fix(core): ObservableArray tests and a typo ( #8968 )
2020-10-17 16:15:20 -07:00
893431a66d
chore: removed this for now. Not really needed as using plugin
2020-10-08 09:53:00 +02:00
60060d984d
Merge branch 'master' of github.com:NativeScript/NativeScript
2020-10-05 09:18:59 +02:00
6d135e5d63
fix(core): ObservableArray splice ensure index is > 0 ( #8921 )
...
Otherwise it will crash in ListView for iOS for example as it tries to animate an item with a negative row index
2020-09-30 16:54:54 -07:00
ae726846d9
Merge branch 'master' of github.com:NativeScript/NativeScript
...
# Conflicts:
# packages/core/package.json
# packages/core/ui/tabs/index.android.ts
2020-09-30 17:46:22 +02:00
65b1cdbae0
fix(core): Observable splice index > length ( #8900 )
...
* fix for splice index > length
In javascript you can call splice with an index > length. The result is a push.
But when you do that ObservableArray index will be wrong and thus user logic will fail.
Example:
```ts
// obsarray = [0];
obsarray.splice(2, 0, 1);
// this works, the inner array is now [0,1]
// however 'change' is called with index = 2
// when the use tries to do obsarray.getItem(eventData.index) -> crash
```
* fix to handle delete too
2020-09-27 09:20:52 -07:00
29c10d5a5f
Merge branch 'master' of github.com:NativeScript/NativeScript
...
# Conflicts:
# CHANGELOG.md
# package.json
# packages/core/data/observable/index.ts
# packages/core/globals/index.ts
# packages/core/package.json
2020-09-23 21:17:41 +02:00
eb676fdedf
feat(core): global event handling ( #8830 )
2020-09-15 10:43:40 -07:00
64594bc4d2
remove global events
...
should be done in a plugin
2020-09-09 21:33:07 +02:00
0ff21d7e5e
onListenerAdded and onListenerRemoved
2020-08-27 09:19:59 +02:00
020ad4da37
chore(core): monorepo, esm targeting, improved management ( #8707 )
2020-08-25 20:00:59 -07:00