Commit Graph

926 Commits

Author SHA1 Message Date
Manol Donev
23dc84d84b fix(ios): textview content clipped on every other newline (#6864) 2019-02-06 14:04:27 +02:00
Martin Yankov
603c901be4 feat(action-bar): flat mode breaks ios safe area (#6862) 2019-02-06 13:13:03 +02:00
Alexander Djenkov
8c80044cc0 fix(view-android): clear dialog fragment when closing modal view (#6852) 2019-02-04 15:34:37 +02:00
Adrian Rollett
408614dd45 feat(dialog): add decimal input type for prompt dialog (#6805) 2019-01-25 15:20:19 +02:00
Manol Donev
08acd84fe2 fix(ios): native view frame optimizations in nested scenario (#6809) 2019-01-23 11:09:04 +02:00
Grgur Grisogono
19dfd163e0 fix: call onNavigatingFrom event only if it exists (#6773)
I ran into an issue where `owner.onNavigatingFrom` didn't exist when rendering a view was blocked by the biometric scanner and then user hit the back button to navigate back.

This code simply adds a check to see if `onNavigatingFrom` exists on the owner
2019-01-21 15:23:43 +02:00
Gal Weissman
25f4b562a0 fix(android-login): use passwordHint for password placeholder 2019-01-21 10:26:27 +02:00
Vasil Chimev
1f1d722008 fix(Android): a crash on application restart after livesync changes (#6756)
```
An uncaught Exception occurred on "main" thread.
com.tns.NativeScriptException:
Calling js method run failed

TypeError: Cannot read property 'getRootView' of undefined
File: file:///data/data/org.nativescript.preview/files/app/tns_modules/tns-core-modules/ui/frame/frame.js, line: 56, column:29
```
2019-01-08 21:03:28 +02:00
Nikolay Tsonev
3a8c3fca75 feat(modals): option to make dialogs cancelable in Android (#6765) 2019-01-08 16:56:30 +02:00
Manol Donev
46c9de020e fix(android): raise resume event on activity.onPostResume() (#6766) 2019-01-08 15:20:11 +02:00
Alexander Djenkov
2085d1e4ac fix(list-view-android): app crashes on ListView item template change (#6634)
* fix(list-view): app crashes on first ListView item template change

* tests: add tests for changing ListView item template with expression
2019-01-08 13:48:47 +02:00
Alexander Djenkov
984f162c1c fix(tab-view): remove onBackPressed override (#6755) 2019-01-04 16:57:26 +02:00
Manol Donev
1ae0cfd4b3 refactor: cleanup unused elements (#6732) 2019-01-02 11:17:55 +02:00
Nikolay Tsonev
6cdb01d432 set the correct application theme while creating the dialog fragment (#6691)
* set the correct application theme while creating the dialog fragment

* useing the new approche fusing the new approach for setting the theme only when the modal view is fullscreen(it will break the style when using non-fullscreen modal)

* note - get theme change

* set the correct application theme while creating the dialog fragment

* useing the new approche fusing the new approach for setting the theme only when the modal view is fullscreen(it will break the style when using non-fullscreen modal)

* note - get theme change
2018-12-31 14:20:52 +02:00
Alexander Vakrilov
8a32102fa1 fix(modal): Fix crash if modal is destroyed before dismissed in Android (#6723) 2018-12-20 17:24:13 +02:00
Manol Donev
4dc35a5e6f fix(android): failure saving state in mixed parent/nested frame nav (#6719) 2018-12-18 10:23:02 +02:00
Manol Donev
c034d6ead6 fix(android): animator restore logic on simulated nav (#6710) 2018-12-17 15:27:52 +02:00
Nathan Walker
3481e6f33f feat(image-cache): expose onError callback (#6458)
* feat(Cache): better error handling

* refactor(image-cache): add `error` parameter to `_onDownloadError`

Add DownloadError interface.

* refactor(image-cache): updates for iOS

Use arrow functions.
Remove an unnecessary `trace.write().

* refactor(image-cache): updates for Android

Update Android `constructor()`.
Move `key` and `image` check to `set()`.
Update `trace.write`.

* fix(image-cache): onError handling
2018-12-17 11:33:12 +02:00
Svetoslav
134b033b77 Merge pull request #6707 from NativeScript/release 2018-12-14 16:40:11 +02:00
SvetoslavTsenov
ea44416734 Merge remote-tracking branch 'origin/master' into release 2018-12-14 14:53:53 +02:00
Vasil Chimev
4c15f71789 fix: iOS tests 2018-12-14 14:34:50 +02:00
Vasil Chimev
790bcfb470 refactor(HMR): apply changes in application styles at runtime 2018-12-14 14:34:50 +02:00
Vasil Chimev
42a1491e6e feat(HMR): apply changes in application styles at runtime
Expose `HmrContext` interface.
Apply changes in `app.css` instantly.
Avoid navigation on livesync when changes in `app.css` have been made.
Apply changes in `app.css` on back navigation.
2018-12-14 14:34:47 +02:00
Martin Bektchiev
1c0218ea15 feat(tns-platform-declarations): Generate iOS typings from iOS 12.1 SDK (#6693)
* feat(tns-platform-declarations): Generate iOS typings from iOS 12.1 SDK

* Instructions for generating iOS typescript definitions
* Refactor `typings-gen.sh` to use {N} CLI and generate fuller
metadata for the system libraries
* Automatically generate `ios.d.ts` wrapper
* Add interop pointers and references as alternatives
to `string` for `char*` args
(implemented in https://github.com/NativeScript/ios-runtime/pull/1022)

BREAKING CHANGE: Several enum values have changed because
    they have been wrongly generated.

    To migrate your app or plugin code use the new names of the
    following:
    *  enum NSUnderlineStyle:
        - `StyleNone` -> `None`
        - `StyleSingle` -> `Single`
        - `StyleThick` -> `Thick`
        - `StyleDouble` -> `Double`
     * enum AVAudioSessionErrorCode:
        - `CodeNone` -> `None`
        - `CodeMediaServicesFailed` -> `MediaServicesFailed`
        - `CodeIsBusy` -> `IsBusy`
        - `CodeIncompatibleCategory` -> `IncompatibleCategory`
        - `CodeCannotInterruptOthers` -> `CannotInterruptOthers`
        - `CodeMissingEntitlement` -> `MissingEntitlement`
        - `CodeSiriIsRecording` -> `SiriIsRecording`
        - `CodeCannotStartPlaying` -> `CannotStartPlaying`
        - `CodeCannotStartRecording` -> `CannotStartRecording`
        - `CodeBadParam` -> `BadParam`
        - `CodeResourceNotAvailable` -> `ResourceNotAvailable`
        - `CodeUnspecified` -> `Unspecified`

* fix(ui/text-base): Update NSUnderlineStyle.StyleSingle constant

After the typings regeneration its and several others' names have
changed to the expected `NSUnderlineStyle.Single`.

* fix(tns-platform-declarations): Restore deprecated enum values

In order to not introduce a breaking change in a patch version, we
are keeping `Style...` and `Code...` values that have been wrongly
generated till now. In the next major/minor release of the package
when the typings are regenerated we can safely remove them.

Revert to using the deprecated one's in `text-base.ios.ts` so that
the introduction of this breaking change doesn't slip in undetected.

* fix(application.ios): Directly call presetnNativeScriptApp

We've been using `performSelectorWithObject` but it's
declaration has been manually added. Moreover it's more
convenient to directly call the method.
2018-12-13 17:04:13 +02:00
Nicu
540b2b4f82 feat(view): added iOS parameter for modal presentation style (#6409)
* feat(view): added iOS parameter for modal presentation style

* Now passing options to showModal in one argument

* refactor: Move context and close in modal options

* chore: Comments added for UIModalPresentationStyle.Popover case

* refactor: Use modalOptions in e2e demo

* chore: fix pbroken test
2018-12-13 17:03:25 +02:00
Manol Donev
c084660d0b fix(android): nested fragment disappears on parent fragment removal (#6677) 2018-12-12 14:16:10 +02:00
Martin Yankov
63be78a69c fix(listview): incorrect layout when scroll (#6656) 2018-12-05 16:28:37 +02:00
Alexander Vakrilov
30df4d9c4a fix(modals): regression with modals in angular (#6655) 2018-12-04 16:39:07 +02:00
Manol Donev
0b239d7a0a feat(tabview): add androidSwipeEnabled property (#6652) 2018-12-04 15:35:15 +02:00
Manol Donev
ae0fa90290 feat(scrollbar): add isScrollEnabled property (#6640) 2018-11-30 17:18:40 +02:00
Alexander Vakrilov
64bccb9bbc feat(modals): Enable modal dialog chaining in IOS (#6637)
* feat(modals): fire close callback after close in IOS

* chore(tests): Fix some test depending on the order of events
2018-11-30 12:05:33 +02:00
Nick Iliev
bc68773bd2 fix(ui/enums) make exported enums compatible with TypeScript and the corresponding properties (#6639)
* feat: make ui/enums tsc compatible

* make ui/enums tsc compatible
2018-11-30 12:03:06 +02:00
Nick Iliev
b58dff0de3 feat(ActionBar): apply text color when largeTitletextAttribute is set on iOS (#6631)
* apply CSS text color when largeTitletextAttribute is set on iOS

* common logic improvment
2018-11-30 11:29:40 +02:00
Manol Donev
25c99d8f71 fix(searchbar): isEnabled and isUserInteractionEnabled (#6636) 2018-11-29 11:18:14 +02:00
Nick Iliev
c8341819a3 feat: add hints options for username and password fields (#6416)
* feat: add hints options for username and paossword fileds in the login dialog

* refactor arguments checks

* parsing of login options moved to common file

* add zero login options check

* parsing optimizations

* api refernces improvments

* refactor: argiment passing

* review code improvments
2018-11-27 11:22:12 +02:00
Eduardo Speroni
11d3884243 fix(android-styling): correctly detect if drawable uses ColorFilter (#6342)
* fix(android-styling): correctly detect if drawable uses ColorFilter

Treat a widget with a BorderDrawable background as any other, even if it's FilterOnly

If the drawable has been replaced with a new one, clear _cachedDrawable

Fixes #6341

* test(button): add test for changing border-radius and color in button

* test: fix test checks for IOS

* keep original drawable cached
2018-11-27 10:44:34 +02:00
Manol Donev
5b9b335489 fix(android-fragment): child already has a parent (#6589) 2018-11-23 14:48:41 +02:00
Alexander Djenkov
fc1f8c1e42 fix(back-navigation): app freeze on going back in parent frame with states (#6595)
Endless loop while searching for parent frame that can go back.
Caught in Angular app when trying to go back from nested named lazy loaded outlet using the android hadrware back button.
2018-11-23 10:05:49 +02:00
Martin Yankov
f90995f8f9 fix(ios): scrollview safe area when no scroll (#6568) 2018-11-19 09:23:06 +00:00
Leonardo Donelli
efe331862f fix: doc of transitionAndroid property of NavigationEntry interface (#6563) 2018-11-15 20:10:29 +00:00
Martin Yankov
51a191f396 fix(ios): safe area handling in scrollview (#6561) 2018-11-15 13:07:15 +00:00
Dick Smith
db33cf313c fix: crash on Android Tab-View #6466 (#6467)
* fix: crash on Android Tab-View NativeScript#6466

This fix has been tested in production with no new issues occurring.

Long-term solution would be one of the following, though:
1. reintroduce overrides for `saveState`/`restoreState` in the current PagerAdapter implementation (removed on this commit NativeScript@ac04ede#diff-f1459d509d1432b432c29bcd30e462fbL97)
2. use FragmentPagerAdapter
3. use FragmentStatePagerAdapter

Both 2 and 3 manage the save/restore cycles. The main difference between 2 and 3 is that 2 uses more memory, but allows for quicker switching between Fragments than 3. Since tabs should usually be limited to 5 or less, this may be the best choice to maintain performance, which is important for top level navigation tabs.

When I have more time I may experiment with these options myself to see what the difference to performance and memory consumption is for each.

* refactor: _commitCurrentTransaction method+comment

* chore: fix typo

* fix: missing class definition
2018-11-14 15:53:38 +00:00
Manol Donev
7df8038d09 fix: nested frames order with tabs & suspend/resume (#6528) 2018-11-14 10:20:52 +02:00
Shyam Seshadri
7e7c050064 feat: add number and phone input types for prompt dialog (#6365) 2018-11-07 17:32:20 +02:00
Manol Donev
7fbdc7adc8 fix: layoutChanged event in landscape (#6520) 2018-11-07 14:23:02 +02:00
Manol Donev
41ba93de41 fix(android): IllegalStateException with tabview&nested frames (#6495) 2018-11-05 16:17:51 +02:00
Manol Donev
fac970e753 fix(android): back navigation on app suspend/resume (#6489) 2018-11-02 17:31:52 +02:00
Vladimir Amiorkov
2933a9a934 fix: Resolve incorrect name of listener when unsubscribing (#6487) 2018-11-02 15:33:17 +02:00
Alexander Djenkov
371fc9b647 fix(tab-view-android): change androidOffscreenTabLimit to 1 when using bottom tabs (#6476) 2018-10-30 14:24:55 +02:00
Martin Yankov
58c9d424f5 fix-next(ios): handle nesting in proxyViewContainer ng (#6475) 2018-10-30 14:00:00 +02:00