4 Commits

Author SHA1 Message Date
5c1b7f6d76 fix(core): ObservableArray tests and a typo (#8968) 2020-10-17 16:15:20 -07:00
6d135e5d63 fix(core): ObservableArray splice ensure index is > 0 (#8921)
Otherwise it will crash in ListView for iOS for example as it tries to animate an item with a negative row index
2020-09-30 16:54:54 -07:00
65b1cdbae0 fix(core): Observable splice index > length (#8900)
* fix for splice index > length

In javascript you can call splice with an index > length. The result is a push.
But when you do that ObservableArray index will be wrong and thus user logic will fail.
Example:
```ts
// obsarray = [0];
obsarray.splice(2, 0, 1);
// this works, the inner array is now [0,1]
// however 'change' is called with index = 2
// when the use tries to do obsarray.getItem(eventData.index) -> crash
```

* fix to handle delete too
2020-09-27 09:20:52 -07:00
020ad4da37 chore(core): monorepo, esm targeting, improved management (#8707) 2020-08-25 20:00:59 -07:00