90 Commits

Author SHA1 Message Date
446163d3f8 fix: fix ios hmr (#8559) 2020-05-08 11:20:32 +03:00
50e58fa19f fix (android/TextField): set focusable, clickable to false when editable is false (#8525)
Do not clear key listener when editable is false This prevents the input type to be changed.
Instead, we can set focusable, clickable to false.
This allows to change input Type i.e (secure) at run time when editable is false.

Reference issue: https://github.com/NativeScript/NativeScript/issues/8523

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
2020-04-14 12:36:54 +03:00
f0149dae7d refactor for easy subclassing and new features (#8514) 2020-04-10 16:44:49 +03:00
bd9828a036 feat(utils): work openFile in simulator (#8495)
* feat: open file in iOS simulator

* feat: added isRealDevice util

* feat: have in mind isRealDevice in utils.openFile

refactor to avoid some circular dependencies

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
2020-04-03 19:44:47 +03:00
ad9daa825f fix: dont default to Font.default (#8401)
* fix: dont default to Font.default

This would cause a font to be set for any label even when using default system font.
This will also cause a typeface which is pretty long

* lint: lint fixes

* fix: added null font guards

* fix: Used default bold for TabView

Co-authored-by: Vasko <v.trifonov@gmail.com>
2020-04-03 16:40:14 +03:00
c150b11bf1 Merge branch 'release' 2020-04-02 12:03:20 +03:00
fc8f7696e6 fix(tabs): dynamic styling fixes (#8479)
* fix(tabs): dynamic styling fixes - iconSource
selectedItemColor and unSelectedItemColor

* fix(tabs): bottom nav item color fix

* chore: remove unneeded method calls

* chore: remove unneeded console.log

* fix: fixing build

* fix(tabs): resources passing

* fix(tabs): setting item colors

* test: updated dynamic color tests

* chore: fix automationText
2020-04-02 11:59:19 +03:00
e421129458 fix: do not clear androidView._cachedDrawable (#8475) 2020-04-01 17:42:24 +03:00
2b06adca27 fix: call to nativeView (#8488) 2020-04-01 17:41:58 +03:00
0a7bee61d9 fix(tabs): dynamic styling colors fixed (#8460)
* fix(tabs): dynamic styling colors fixed

* test(tabs): adding dynamic color change test
2020-03-26 19:15:27 +02:00
c9cea472ca refactor(css): attribute selectors match web counterparts (#7848)
* Improve CSS selector parsing/matching by 30% - 40%
  with some JavaScript optimization and excluding ProxyViewContainer from the process
Change the specificity to be divisible to 10

* fix: selector match

* fix: lint errors

* refactor: restore processing of ProxyViewContainer

* chore: lower the number of expected cycles

* fix: some css selector fixes

Co-authored-by: Manol Donev <manol.donev@gmail.com>
Co-authored-by: Manol Donev <manoldonev@users.noreply.github.com>
Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
2020-03-26 19:04:42 +02:00
66cc8a477e fix(button-android): use setMinWidth to set TextView widgets min-width (#7804)
* fix: setMinimumWidth does not really set the minWidth for TextView widgets

* chore: fix versions

* refactor(android): default minWidth/Height values for button

* reafctor: reset minWidth when view is in flexbox for backcompat

* refactor: ensure back-compatible layout for btns

* chore: cut 6.5.0 release (#8443)

* release: cut 6.5.0 release

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>

Co-authored-by: vakrilov <alexander.vakrilov@telerik.com>
Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
2020-03-26 13:07:04 +02:00
1f04469fb3 feat(css-bkg-pos): Added possibility to declare background pos by single numeric value (#7958)
* feat(css-bkg-pos): Added possibility to declare background pos by single numeric value

* feat(css-bkg-pos): Implemented numeric bkg pos for iOS

* feat(css-bkg-pos): removed unnecessary code

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
2020-03-24 10:17:35 +02:00
42fc4acea3 feat(ios): textfield option to disable iOS autofill strong password handling (#8348)
* feat(ios): textfield option to disable autofill strong password handling

* chore: api change report
2020-03-23 12:16:40 +02:00
8ab0e72bc9 feat: TappableSpan support (#8256)
* feat(android): clickable span

Initial support for clickable span on Android

* test: clickable-span test page

* remove console.log

* use _emit instead of notify

* rename clickable to tappable in Span

* updated NativeScript.api.md

* chore: fixing tslint errors

* chore: fixed witespacing

* moved and improved test page

* feat: tappable span iOS implementation

Co-authored-by: Eduardo Speroni <edusperoni@gmail.com>
2020-03-20 18:37:34 +02:00
92b5b02bf5 feat(text-field): add closeOnReturn property to avoid auto dismissing… (#8347)
* feat(text-field): add closeOnReturn property to avoid auto dismissing input on return press

* tslint

* Update NS public api

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
2020-03-20 10:19:53 +02:00
8dbb623944 fix: update tap event data (#8415)
* Update tap event data object

Adds a:

- TabGestureEventData interface, which can be used for both tap and doubleTap events.

- The event object returned by both tap and doubleTap events now have getX(), getY(), and getPointersCount() methods. These facilitate the same function as those of the touch event object.

* ui(gesture): getX,getY in DIP

Updates the getX() and getY() methods of Tap, doubleTap and touch events to return DIP instead of DP.

* ui(gesture): tap event data includes location

Tap and doubleTap event data now include getX and getY methods for event location. These are in DIP format.

getPointerCount is also available.

* Fix tslint errors

* fix minor formatting issues for api-extrector
2020-03-19 12:51:23 +02:00
4a67a3b73f fix: dont create an actionbar if not necessary (#8402)
* fix: dont create an actionbar if not necessary

For now i kept the commented code so that you can see the change.
Also i changed the android check to behave like iOS

* rollback. we now try an make sure the actionbar  is created only if needed

* actually we should check for false
2020-03-19 11:00:29 +02:00
270988d26e Added iconClass property to TabStripItem (#8440)
* chore: ignore e2e folder's other subfolders

* feat: added iconClass to tabStripItem
2020-03-16 14:22:24 +02:00
243dc98005 Added selectedItemColor and unSelectedItemColor to the TabStrip (#8431)
* chore: add guard for ios

* feat(bottom-nav): adding new properties

* feat(tabs): new property implementation

* feat: new feature implementation in android

Implemented selectedItemColor and unSelectedItemColor properties on TabStrip

* chore: added some comments

* chore: change method return type

* fix: setting icon color

* fix: rendering mode setting

* chore: rename variable

* chore: fixed a typo

* chore: updated log in build gradle

* fix: item color setting in android

* fix: tab styling when no css aplied

* chore: private methods renamed

* tests: added selected-item test pages

* chore: renamed test pages

* chore: move css-tree package to the right place

* tests: added new ui tests

* fix: use renamed function

* fix: set item color

* tests: aded automationText attribute

* tests: trying to fix the tests

Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
2020-03-16 12:54:30 +02:00
e081340665 fix: Fix issue for view not being removed from its parent (#8432) 2020-03-13 12:57:38 +02:00
bf02f7a332 Merge branch 'master' into doubleTap-location 2020-03-10 18:23:49 +02:00
b13f4d058c Merge branch 'master' into fix_css_styles 2020-03-10 16:09:14 +02:00
39473ecd65 Merge branch 'master' into master 2020-03-10 09:43:28 +03:00
4952ca606f Merge branch 'master' into doubleTap-location 2020-03-09 13:36:21 -05:00
458943111e Tabs styling improvements (#8366)
* fix(tabs): delay loadView when animation runs

* chore: update api.md

* chore: remove unnecessary casting

* test: Added disabled test for changing tabs

* tabs(ios): added tabs styling in ios

* tabs: added iosAlignment property

* tabs: textTransform support

* tabs: iosAlignment moved to tabstrip

* test: add frame-in-tabs test

* chore: addressing PR comments

* chore: addressing PR comments

* chore: call method on the instance instead of call

* chore: move IOSAlignment property

* chore: update comments

* fix: texttransform to tabstrip in bottomnavigation

* chore: add new item to native-api-usage

* chore: remove unneeded setNativeView call

* chore: removed unneeded check

Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
2020-03-09 15:24:26 +02:00
1a316b8a72 Set length value to auto when length is undefined 2020-03-07 20:32:48 +03:00
46628ffdb1 refact: locationX/locationY -> getX()/getY() 2020-03-06 10:25:37 -06:00
401992dcc3 Merge branch 'master' into fix_css_styles 2020-03-06 15:25:31 +02:00
1c46d748a0 chore: addressing review comments 2020-03-06 11:12:22 +02:00
9830be7230 fix(bottom-nav): align text with different icons 2020-03-05 15:35:07 +02:00
6668468ada Merge branch 'master' into doubleTap-location 2020-02-27 09:04:56 -06:00
062c620acb Bottom nav color ios fix (#8384)
* fix(bottom-navigation): color in ios fix

* chore: improving fix and added description

* chore: typo fix

* chore: updated comment

* chore: condition check updated
2020-02-27 10:40:00 +02:00
2d4e258a88 Release to master (#8382)
* fix the crash

* chore: update MaterialComponents pod (#8176)

* chore: update MaterialComponents pod

* chore: remove copy of pod file in build script

* chore: cut the 6.3.0 release (#8174)

* hore: cut the 6.3.1 release

* fix: handle fake attach after FragMgr is destroyed (#8200)

* fix: check is disposed fragment is in the FragmentManager (#8201)

* release: cut the 6.3.2 release

* release: cut the 6.4.0 release

* chore(build): always use local typescript

* fix: flipLeft and flipRight on Android (#8307)

* fix(android): tap-trip-item title disappearing

* fix(andoid): crash when setting font on tab-item with no image

* fix(build): Add platforms/android to NPM package (#8312)

Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
Co-authored-by: Alexander Vakrilov <alexander.vakrilov@gmail.com>

* release: cut the 6.4.1 release

* chore: bump tns-core-modules-widgets version (#8352)

Co-authored-by: hamidbsd <50081218+hamidbsd@users.noreply.github.com>
Co-authored-by: Alexander Vakrilov <alexander.vakrilov@gmail.com>
Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
Co-authored-by: Nick Iliev <nikolay.iliev@telerik.com>
Co-authored-by: Martin Bektchiev <martin.bektchiev@progress.com>
Co-authored-by: Rosen Vladimirov <rosen-vladimirov@users.noreply.github.com>
2020-02-26 18:06:50 +02:00
e6fd43bfe5 Fix Style Scope issue with Webpack css/scss files 2020-02-25 22:22:39 -06:00
acaabbd2aa Tabs animation and selected index fixes (#8377)
* fix(tabs): animation freeze when chaning tabs

* fix(tabs): poper item selecting programically
2020-02-25 17:08:43 +02:00
6090514b8f Merge branch 'master' into doubleTap-location 2020-02-24 21:48:20 -06:00
06b9ecf80b fix(ios): Ensure ObserverClass is initialized (#8365) 2020-02-23 17:46:01 +02:00
50c9c40c78 Merge branch 'master' into doubleTap-location 2020-02-21 15:02:23 -06:00
e649a6cfd6 fix(tabs): delay loadView when animation runs (#8353)
* fix(tabs): delay loadView when animation runs

* chore: update api.md

* chore: remove unnecessary casting

* test: Added disabled test for changing tabs
2020-02-21 16:47:33 +02:00
520878a8a0 tslint 2020-02-13 15:30:46 -06:00
5ff78e2ad2 feat(gestures): add locationX and locationY to double tap event data 2020-02-13 14:57:56 -06:00
dd11158374 fix: guard cachedDrawable (#8320) 2020-02-06 17:29:30 +02:00
0b50f3e5d3 fix: remove the passowrd for TextField as well (#8290) 2020-01-30 16:34:38 +02:00
a311a922b5 Fix date picker owner not updating its comps on iOS (#8263)
Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
2020-01-27 17:46:12 +02:00
e57d5d9da1 chore: merge release in master (#8275)
* fix the crash

* chore: update MaterialComponents pod (#8176)

* chore: update MaterialComponents pod

* chore: remove copy of pod file in build script

* chore: cut the 6.3.0 release (#8174)

* hore: cut the 6.3.1 release

* fix: handle fake attach after FragMgr is destroyed (#8200)

* fix: check is disposed fragment is in the FragmentManager (#8201)

* release: cut the 6.3.2 release

Co-authored-by: hamidbsd <50081218+hamidbsd@users.noreply.github.com>
Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
2020-01-27 11:05:46 +02:00
02763ecd2c fix(android): crash on setting elevation on API21 (#8269) 2020-01-23 10:50:01 +02:00
05ef9b0ff2 fix(8151): button textAlignment on IOS (UIButton) (#8181)
When setting the format of a "text view", we need to recover existing values for properties that will get default values otherwise.
The "textAlignment" of a UIButton is available through a "titleLabel" object instead of directly on itself (see IOS documentation fo UIButton).

Co-authored-by: Romain Vincent <54814371+romain20100@users.noreply.github.com>
Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
2020-01-21 18:39:42 +02:00
3c79ded42b feat(textview): added maxLines property (#7943)
* feat(textview): added maxLines property

* feat(text-view): moved implementation to TextView

* feat(text-view): changes based on CR

* feat(text-view): Normalize behavior in between android and iOS

* chore: updated NativeScript.api.md

* chore: add new line before return

Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
2020-01-16 12:41:26 +02:00
6133d6b6bd fix(ios): ActionBar style wrong after cancelled swipe back navigation (#8252)
* fix(ios): ActionBar style wrong after cancelled swipe back navigation

* chore: cleanup

* remove unneeded console.log

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
Co-authored-by: Dimitar Topuzov <dtopuzov@gmail.com>
2020-01-16 12:17:29 +02:00