Commit Graph

677 Commits

Author SHA1 Message Date
Hristo Hristov
1b9610b4dd The original issue described here: https://github.com/NativeScript/NativeScript/issues/4804 is fixed in 3.2 but there is another bug which doesn't render borderRadius on Image element. (#4963) 2017-10-20 08:33:08 +03:00
Panayot Cankov
188c1f2568 Hanlde hint color reset properly in iOS (#4968) 2017-10-20 08:31:18 +03:00
Panayot Cankov
69199a5df2 Fix hint color in ios, the attributedPlaceholder and placeholder was set following two very distinct paths (#4945) 2017-10-18 16:10:23 +03:00
Peter Kanev
374f31cbf7 fix(minor): reword missing-xml-error to be clearer (#4947) 2017-10-18 10:43:17 +03:00
Hristo Hristov
cb6a75c107 Fix crash on API 23 where constantState.newDrawable(nativeView.getResources()); throws exception in Java. (#4959)
Fix https://github.com/bradmartin/nativescript-floatingactionbutton/issues/57
Addition to https://github.com/NativeScript/NativeScript/issues/4728
2017-10-18 10:35:07 +03:00
Peter Kanev
cb029225c3 Elements tab support for iOS Chrome DevTools (#4930)
* add initial implementation of the dom agent for ios

* add implementation of the css agent for ios

* refactor devtools inspector methods to somewhat accomodate ios and android

patch elements dom-node tests to test for ios too

* fix android dom-node test

* fix ios dom-node-tests to mock the ios devtools inspector properly

* fix: minor changes
2017-10-12 11:32:31 +03:00
Panayot Cankov
35be4bc40a Animations improperly reset (#4900)
* Animations improperly reset

* Scope stop and start of animations to avoid blinks
2017-10-03 15:50:09 +03:00
Panayot Cankov
1049fcc251 Revert _applyXMLAttributes to set style, rows, columns and fontAttributes as properties (#4911) 2017-10-03 15:40:27 +03:00
Hristo Hristov
27773e96a6 Initial transitions are ingored on android (as they are on ios) because on API 21+ Transition class requires at least one layout pass before transitions are executed. If we don't ignore it our transition handlers won't execute and frame navigation won't execute because it thinks there is a pending navigation. (#4896)
Fix https://github.com/NativeScript/NativeScript/issues/4895
2017-09-28 09:19:06 +03:00
Hristo Hristov
9b52bbcd29 If you set tap gesture on a button parent (e.g. some layout for example) and set tap handler on the button and click the button there is a chance to execute navigation with clear history. This will remove current fragment and will clear the button listener owner. Still android will fire the click handler and we will throw an exception. (#4898)
Fix https://github.com/NativeScript/NativeScript/issues/4897
2017-09-28 09:17:54 +03:00
Alexander Vakrilov
1e47117179 fix: DatePicker month off by 1 in Android (#4872) 2017-09-26 09:44:33 +03:00
Panayot Cankov
6d7c1ff295 Avoid applying CSS multiple times (#4784)
* Move the applyStyleFromScope to onLoaded, when the views are created and id or className properties are set the CSS selectors are queried and applied multiple times

* Condense the changes when applying properties
2017-09-25 18:32:00 +03:00
Evan Payne
b0577728be Return true if user has consumed the action (#4859)
Based on this: https://developer.android.com/reference/android/widget/TextView.OnEditorActionListener.html
And assuming that the developer will run dismissSoftInput in the owner.dismissSoftInput() only if they need to.
Returning False will close the keyboard regardless.
2017-09-25 15:46:01 +03:00
Nikolay Tsonev
cf48c9f6dd edit broken link (#4799) 2017-09-05 18:22:26 +03:00
Alexander Vakrilov
d0b3e0c536 fix(date-picker): Date picker changed check (#4797) 2017-09-05 13:42:06 +03:00
Alexander Vakrilov
28b6eba9ac TypeScript 2.5 compatibility (#4794) 2017-09-04 14:36:34 +03:00
Brad Martin
a79a83ce82 Typos (#4789) 2017-09-04 11:09:36 +03:00
Panayot Cankov
12c0199fb5 UIScrollViews will now report 'scroll' events and the background in ios will adjust added layers (#4762) 2017-08-29 10:25:45 +03:00
Hristo Hristov
617fa92efc Fix MultiTemplateParser to not eat its closing tag (#4756) 2017-08-25 17:44:10 +03:00
Eddy Verbruggen
f00ec1a966 Add a 'focus' even to text input fields (#4730) 2017-08-25 11:22:47 +03:00
Hristo Hristov
c98443b331 Fix breaking change - nativeView property should have setter (#4750)
Exposed savedInstanceState on LaunchEventArgs so some controls that need Bundle to initialize could get it from there.
2017-08-25 11:13:51 +03:00
Panayot Cankov
d62df3789c Do not change the Android layer types (hardware/software) (#4625) 2017-08-25 10:45:58 +03:00
Panayot Cankov
3a447b6f3f Added @profile on several key methods in the Android lifecycle, refactored by extracting into methods a little (#4685) 2017-08-24 13:10:53 +03:00
Daniel Leal
7b364613da fix: typo on android utils, getPalleteColor to getPaletteColor (#4687)
* fix: typo on android, getPalleteColor to getPaletteColor

* fix: adress comments
2017-08-24 11:55:31 +03:00
Hristo Hristov
b6d5510627 Fix crash where some android Drawables doesn't implement getConstantState... (#4742)
Changed all places where getConstantState was used.
2017-08-24 11:06:33 +03:00
Hristo Hristov
06ad345015 Fix issue 4302 (#4723)
Fix tests for that issue
2017-08-22 09:52:07 +03:00
Hristo Hristov
9bcf4ef460 Removes list-view selected state when rowHeight is set (#4725) 2017-08-22 09:50:54 +03:00
Eddy Verbruggen
6e06eba218 Fixed a bunch of typo's and minor errors in TypeScript definition files. (#4707)
* Fix a bunch of typo's and minor errors in TypeScript definition files.

* Implemented the requested change by @hshristov
2017-08-21 11:22:04 +03:00
Hristo Hristov
bba7a82bdf Disable recycling, refactoring & fixes (#4705)
* Added tests for native view recycling
Disabled android native view recycling
Move toString from view-common to view-base
Fix crash on application restore and navigation back on API26
Added setAsRootView method
Added missing logo into perf-tests/recycling app

* additional fix for image-source-tests. ios is case sensitive.

* Add @private to some internal properties
Fix where padding is not respected when background is reset.
2017-08-17 09:15:35 +03:00
Hristo Hristov
2701ea3c1e Fix failing test on ios 11 (#4686)
Add new perf-test page for view recycling
Changed the initialization of TextTransformation field
2017-08-16 15:19:01 +03:00
Stanimira Vlaeva
08dcfabe82 refactor(date-picker): value converter for month is 1-based (#4656) 2017-08-08 17:07:21 +03:00
Hristo Hristov
24923445bd Image cache is cleared when livesync happens (#4672) 2017-08-08 16:52:39 +03:00
Hristo Hristov
2c27b1ac7a Cache android.widget.SeekBar as SeekBar for better performance (#4669)
* Cache android.widget.SeekBar as SeekBar for better performance
Made singleton listener for SeekBar
Fix slider issue
Add slider test

* Futher refactoring
2017-08-08 16:04:41 +03:00
Alexander Vakrilov
50d399101e Fixes TabView icons changes. (#4666)
* Fixes TabView icons/title changes.

* Access TabLayput trough parent

* TabView icon change example
2017-08-08 13:06:56 +03:00
Hristo Hristov
075e70e336 cache page on forward navigation (#4652)
* cache page on forward navigation
Still some failing navigation tests

* Current page is kept alive when navigating forward
Refactoring code and removing all hacks and flags
Remove one module circular reference

* Disable Page recycling because when there is transition between pages the nativeView stays animated (e.g. when transition is Fade the hidden page nativeView stays with Alpha 0)
Disable recycling if there is native anitmation

* Fix failing tests on ios & android API17
Fix wrong urls in http tests
Made some timer tests async

* Animations are not stored in BackstackEntry instead of Fragment because fragments could die (activity die) and recreated and we lose animations.

* Fix android crash when activity is recreated.
Refactoring transitionListener.
2017-08-07 17:24:12 +03:00
Stanimira Vlaeva
14098d40db fix: set default values to time widgets (#4383) 2017-08-03 22:03:05 +03:00
Vasil Chimev
c26f1c916a Add line-height test page (#4638)
* Add lineHeight property to text-base.d.ts

* Add line-height test page
2017-08-02 09:30:29 +03:00
Hristo Hristov
0f14101238 recycling now happens only if nativeView and android properties are not accessed. (#4627)
recycleNativeView filed now accepts: "always" | "never" | "auto". Always will recycle the nativeView no matter if its nativeView or android proprties are accessed. Never will disable recycling. Auto will recycle it only if nativeView and android properties are not accessed.
2017-08-01 15:04:16 +03:00
Alexander Vakrilov
7983895c8e FIX: Background drawable cache conflicts with local property (#4633) 2017-08-01 11:53:42 +03:00
Alexander Vakrilov
2dbd1b19ea Fix: refresh flat property on change in IOS (#4628)
* Fix: refresh flat property on change in IOS

* Fix typos
2017-08-01 10:40:51 +03:00
Eddy Verbruggen
12020bd8bb Implement an ActionBar 'flat' property to remove the bottom border/shadow and (on iOS) translucency (#3900)
* #2740 Feature Request: Improved ActionBar CSS Support

* Now using a dedicated 'flat' property.
2017-07-28 15:30:30 +03:00
Panayot Cankov
8711b54b5e Shorthand properties does not update if sub-property is changed (#4607) 2017-07-27 15:42:47 +03:00
Panayot Cankov
43659799bc Implement non uniform border corner radiuses and fix blinking image-view radiuses (#4573)
* Image corners were blinking in #4322 and CSS border will now draw non uniform corner radiuses if the border color is uniform

* Implement per-side corner radiuses for iOS

* Update stretch-mode example

* Update matrix-mode example

* Update image resources

* Add clipping for non uniform radii without border width, don't throw for missing image resources in css
2017-07-27 15:36:47 +03:00
Panayot Cankov
2f6ca2524b CssAnimationProperties, when unset, were not setting the default native value. (#4595) 2017-07-26 19:16:26 +03:00
Alexander Vakrilov
5a660a6eda Set text-field and text-view tintColor to textColor (iOS) (fixes #4357) EXTENDED (#4549)
* set text-field and text-view tintColor to textColor (#4357)

* Rest tint color
2017-07-25 11:22:21 +03:00
Stanimira Vlaeva
4bd3a94873 fix(animations): check if target is present before removing its animation (#4586)
In Angular, if the NativeScriptAnimationModule is imported in another
NgModule more than once (which shouldn't be done), the renderer is instantiated twice. This
causes animation with empty targets to be created. If such animation is
removed, the app will crash. Additional check if the target is present
will prevent this.
2017-07-25 10:28:09 +03:00
Stanimira Vlaeva
43b21ce7e7 refactor(css-selector): export createSelector method (#4580)
needed for NativeScript Angular's animation driver
2017-07-20 18:02:01 +03:00
Hristo Hristov
a17cd1169c fix layer type recycling (#4574) 2017-07-19 15:39:07 +03:00
Eddy Verbruggen
74f26f4498 Add CSS support for line-height (#4534)
* Add CSS support for line-height (issue #1664)

* Implemented @vakrilov's feedback

* Implemented @vakrilov's feedback (changed Android default impl)
2017-07-13 15:00:18 +03:00
Steve McNiven-Scott
3dbcf088be Allow toggling of visible scrollbar indicators (#4523)
* Allow toggling of visible scrollbar indicators

* Add unit test

* Make what the prop does more clear

* Fix tslint

* Rename property per @vakrilov

* Missed string property rename

* Move property from method

* Update orientationChanged to use new property name
2017-07-11 18:14:29 +03:00