time-picker min max logic fixed

This commit is contained in:
Vladimir Enchev
2015-11-25 10:22:12 +02:00
parent 79f009fb38
commit fd33f5144b
5 changed files with 243 additions and 173 deletions

View File

@@ -29,7 +29,7 @@ function _createTimePicker(hour?: number, minute?: number): timePickerModule.Tim
if (minute) {
timePicker.minute = minute;
}
return timePicker;
}
@@ -58,38 +58,38 @@ if (platform.device.os === platform.platformNames.ios) {
}
}
export function test_WhenCreated_HourIsUndefined() {
export function test_WhenCreated_HourIsCurrentHour() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
var actualValue = timePicker.hour;
var expectedValue = undefined;
var expectedValue = timePickerTestsNative.getNativeHour(timePicker);
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
});
}
export function test_WhenCreated_MinHourIs1() {
export function test_WhenCreated_MinHourIs0() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
var actualValue = timePicker.minHour;
var expectedValue = 1;
var expectedValue = 0;
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
});
}
export function test_WhenCreated_MaxHourIs24() {
export function test_WhenCreated_MaxHourIs23() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
var actualValue = timePicker.maxHour;
var expectedValue = 24;
var expectedValue = 23;
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
});
}
export function test_WhenCreated_MinuteIsUndefined() {
export function test_WhenCreated_MinuteIsCurrentMinute() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
var actualValue = timePicker.minute;
var expectedValue = undefined;
var expectedValue = timePickerTestsNative.getNativeMinute(timePicker);
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
});
}
@@ -115,84 +115,96 @@ export function test_WhenCreated_MaxMinuteIs59() {
export function testHourThrowExceptionWhenLessThanMinHour() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
timePicker.minHour = 13;
timePicker.hour = 14;
timePicker.minHour = timePicker.hour - 1;
TKUnit.assertThrows(function () {
timePicker.hour = timePicker.minHour - 1;
}, "Setting hour property to a value less than minHour property value should throw.");
});
}
export function testMinHourThrowExceptionWhenHourLessThanMinHour() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
timePicker.hour = 14;
TKUnit.assertThrows(function () {
timePicker.minHour = timePicker.hour + 1;
}, "Setting minHour property to a greater than hour property value should throw.");
});
}
export function testHourThrowExceptionWhenGreaterThanMaxHour() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
timePicker.maxHour = 13;
timePicker.hour = 14;
timePicker.maxHour = timePicker.hour + 1;
TKUnit.assertThrows(function () {
timePicker.hour = timePicker.maxHour + 1;;
}, "Setting hour property to a value greater than maxHour property value should throw.");
});
}
export function testMaxHourThrowExceptionWhenHourGreaterThanMaxHour() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
timePicker.hour = 14;
TKUnit.assertThrows(function () {
timePicker.maxHour = timePicker.hour - 1;
}, "Setting maxHour property to a value less than hour property value should throw.");
});
}
export function testMinuteThrowExceptionWhenLessThanMinMinute() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
timePicker.minMinute = 13;
timePicker.hour = 14;
timePicker.minute = 13;
timePicker.minHour = timePicker.hour;
timePicker.minMinute = timePicker.minute;
TKUnit.assertThrows(function () {
timePicker.minute = timePicker.minMinute - 1;
}, "Setting hour property to a value less than minHour property value should throw.");
}, "Setting minute property to a value less than minMinute property value should throw.");
});
}
export function testMinMinuteThrowExceptionWhenMinuteLessThanMinMinute() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
timePicker.hour = 14;
timePicker.minute = 13;
timePicker.minHour = timePicker.hour;
TKUnit.assertThrows(function () {
timePicker.minMinute = timePicker.minute + 1;
}, "Setting minMinute property to a value greater than minute property value should throw.");
});
}
export function testMinuteThrowExceptionWhenGreaterThanMaxMinute() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
timePicker.maxMinute = 13;
timePicker.hour = 14;
timePicker.minute = 13;
timePicker.maxHour = timePicker.hour;
timePicker.maxMinute = timePicker.minute;
TKUnit.assertThrows(function () {
timePicker.minute = timePicker.maxMinute + 1;;
}, "Setting hour property to a value greater than maxHour property value should throw.");
timePicker.minute = timePicker.maxMinute + 1;
}, "Setting minute property to a value greater than maxMinute property value should throw.");
});
}
export function testHourFromNativeEqualToMinHourWhenLessThanMinHour() {
export function testMaxMinuteThrowExceptionWhenMinuteGreaterThanMaxMinute() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
var expectedValue = 13;
timePicker.minHour = expectedValue;
timePickerTestsNative.setNativeHour(timePicker, expectedValue - 1);
var actualValue = timePickerTestsNative.getNativeHour(timePicker);
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
});
}
timePicker.hour = 14;
timePicker.minute = 13;
export function testHourFromNativeEqualToMaxHourWhenGreaterThanMaxHour() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
var expectedValue = 13;
timePicker.maxHour = expectedValue;
timePickerTestsNative.setNativeHour(timePicker, expectedValue + 1);
var actualValue = timePickerTestsNative.getNativeHour(timePicker);
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
});
}
export function testMinuteFromNativeEqualToMinMinuteWhenLessThanMinMinute() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
var expectedValue = 13;
timePicker.minMinute = expectedValue;
timePickerTestsNative.setNativeMinute(timePicker, expectedValue - 1);
var actualValue = timePickerTestsNative.getNativeMinute(timePicker);
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
});
}
export function testMinuteFromNativeEqualToMaxMinuteWhenGreaterThanMaxMinute() {
helper.buildUIAndRunTest(_createTimePicker(), function (views: Array<viewModule.View>) {
var timePicker = <timePickerModule.TimePicker>views[0];
var expectedValue = 13;
timePicker.maxMinute = expectedValue;
timePickerTestsNative.setNativeMinute(timePicker, expectedValue + 1);
var actualValue = timePickerTestsNative.getNativeMinute(timePicker);
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
timePicker.maxHour = timePicker.hour;
TKUnit.assertThrows(function () {
timePicker.maxMinute = timePicker.minute - 1;
}, "Setting maxMinute property to a value less than minute property value should throw.");
});
}