javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 20:11:24 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issue with binding when there is no sourceProperty set.

Browse Source
This commit is contained in:
Nedyalko Nikolov
2015-08-31 15:49:42 +03:00
parent 9203850ea7
commit fc3c52691e
2 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
apps/tests/ui/bindable-tests.ts
View File

@ -887,4 +887,22 @@ export function test_NestedPropertiesBindingTwoTargetsAndReplacingSomeNestedObje
(<Activity>act1).Owner = newPerson;
TKUnit.assertEqual(target2.get("targetProp"), secondExpectedFirstName);
}
export function test_NullSourcePropertyShouldNotCrash() {
var expectedValue = "Expected Value";
var target = new bindable.Bindable();
var convFunc = function (value) {
return value + "Converted";
}
var model = new observable.Observable();
model.set("field", expectedValue);
model.set("convFunc", convFunc);
target.bind({
sourceProperty: null,
targetProperty: "targetProp",
expression: "convFunc(field)"
}, model);
TKUnit.assertEqual(target.get("targetProp"), convFunc(expectedValue));
}

9
ui/core/bindable.ts
View File

@ -187,8 +187,13 @@ export class Binding {
return this.sourcePropertiesArray;
}
private static getProperties(property: string) {
return property.split(".");
private static getProperties(property: string): Array<string> {
if (property) {
return property.split(".");
}
else {
return [];
}
}
private resolveObjectsAndProperties(source: Object, propsArray: Array<string>) {