From fa879ba49fcc5d805e42e97661dc13525ebab5fb Mon Sep 17 00:00:00 2001 From: Igor Randjelovic Date: Fri, 20 Nov 2020 13:02:49 +0100 Subject: [PATCH] fix: clean path should be absolute --- .../configuration/__snapshots__/react.spec.ts.snap | 8 ++++---- .../configuration/__snapshots__/vue.spec.ts.snap | 4 ++-- packages/webpack5/src/configuration/base.ts | 3 +-- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/packages/webpack5/__tests__/configuration/__snapshots__/react.spec.ts.snap b/packages/webpack5/__tests__/configuration/__snapshots__/react.spec.ts.snap index b4d996335..350d9e624 100644 --- a/packages/webpack5/__tests__/configuration/__snapshots__/react.spec.ts.snap +++ b/packages/webpack5/__tests__/configuration/__snapshots__/react.spec.ts.snap @@ -139,7 +139,7 @@ exports[`react configuration > android > adds ReactRefreshWebpackPlugin when HMR new CleanWebpackPlugin( { cleanOnceBeforeBuildPatterns: [ - 'platforms/android/app/src/main/assets/app/**/*' + '__jest__/platforms/android/app/src/main/assets/app/**/*' ], verbose: true } @@ -314,7 +314,7 @@ exports[`react configuration > android > base config 1`] = ` new CleanWebpackPlugin( { cleanOnceBeforeBuildPatterns: [ - 'platforms/android/app/src/main/assets/app/**/*' + '__jest__/platforms/android/app/src/main/assets/app/**/*' ], verbose: true } @@ -482,7 +482,7 @@ exports[`react configuration > ios > adds ReactRefreshWebpackPlugin when HMR ena new CleanWebpackPlugin( { cleanOnceBeforeBuildPatterns: [ - 'platforms/ios/__jest__/app/**/*' + '__jest__/platforms/ios/__jest__/app/**/*' ], verbose: true } @@ -660,7 +660,7 @@ exports[`react configuration > ios > base config 1`] = ` new CleanWebpackPlugin( { cleanOnceBeforeBuildPatterns: [ - 'platforms/ios/__jest__/app/**/*' + '__jest__/platforms/ios/__jest__/app/**/*' ], verbose: true } diff --git a/packages/webpack5/__tests__/configuration/__snapshots__/vue.spec.ts.snap b/packages/webpack5/__tests__/configuration/__snapshots__/vue.spec.ts.snap index d6ee7b518..4da8a273a 100644 --- a/packages/webpack5/__tests__/configuration/__snapshots__/vue.spec.ts.snap +++ b/packages/webpack5/__tests__/configuration/__snapshots__/vue.spec.ts.snap @@ -146,7 +146,7 @@ exports[`vue configuration for android 1`] = ` new CleanWebpackPlugin( { cleanOnceBeforeBuildPatterns: [ - 'platforms/android/app/src/main/assets/app/**/*' + '__jest__/platforms/android/app/src/main/assets/app/**/*' ], verbose: true } @@ -318,7 +318,7 @@ exports[`vue configuration for ios 1`] = ` new CleanWebpackPlugin( { cleanOnceBeforeBuildPatterns: [ - 'platforms/ios/__jest__/app/**/*' + '__jest__/platforms/ios/__jest__/app/**/*' ], verbose: true } diff --git a/packages/webpack5/src/configuration/base.ts b/packages/webpack5/src/configuration/base.ts index 63b2de0ad..ab8328a6d 100644 --- a/packages/webpack5/src/configuration/base.ts +++ b/packages/webpack5/src/configuration/base.ts @@ -15,7 +15,6 @@ import TerserPlugin from 'terser-webpack-plugin'; export default function (config: Config, env: IWebpackEnv): Config { const entryPath = getEntryPath(); - const distPath = getDistPath(); const platform = getPlatform(); const packageJson = getPackageJson(); const mode = env.production ? 'production' : 'development'; @@ -144,7 +143,7 @@ export default function (config: Config, env: IWebpackEnv): Config { // items to clean config.plugin('CleanWebpackPlugin').use(CleanWebpackPlugin, [ { - cleanOnceBeforeBuildPatterns: [`${distPath}/**/*`], + cleanOnceBeforeBuildPatterns: [`${getAbsoluteDistPath()}/**/*`], verbose: true, }, ]);