javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: improved core barrel exports and Application class (#10286)

Browse Source 
BREAKING CHANGES:

`Application.orientation` is no longer a function.

Migration: Remove `()` from the `Application.orientation()` call:
```diff
import { Application } from "@nativescript/core";

-console.log(Application.orientation());
+console.log(Application.orientation);
```


`Application.systemAppearance` is no longer a function.

Migration: Remove `()` from the `Application.systemAppearance()` call:
```diff
import { Application } from "@nativescript/core";

-console.log(Application.systemAppearance());
+console.log(Application.systemAppearance);
```
This commit is contained in:
Igor Randjelovic
2023-05-17 21:02:06 +02:00
committed by Nathan Walker
parent 963d0243de
commit f64355ba7a
67 changed files with 3536 additions and 3678 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/core/module-name-resolver/index.ts
View File

@@ -1,8 +1,8 @@
import { Screen, Device } from '../platform';
import * as appCommonModule from '../application/application-common';
import { PlatformContext, findMatch, stripQualifiers } from './qualifier-matcher';
import { registerModulesFromFileSystem } from './non-bundle-workflow-compat';
import { Trace } from '../trace';
import { Application } from '../application';
export type { PlatformContext } from './qualifier-matcher';
@@ -11,7 +11,12 @@ export type ModuleListProvider = () => string[];
export class ModuleNameResolver {
private _cache = {};
constructor(private context: PlatformContext, private moduleListProvider: ModuleListProvider = global.getRegisteredModules) {}
constructor(private context: PlatformContext, private moduleListProvider: ModuleListProvider = global.getRegisteredModules) {
Application.on('livesync', (args) => clearCache());
Application.on('orientationChanged', (args) => {
resolverInstance = undefined;
});
}
public resolveModuleName(path: string, ext: string): string {
const key = path + ext;
@@ -94,8 +99,3 @@ export function clearCache() {
export function _setResolver(resolver: ModuleNameResolver) {
resolverInstance = resolver;
}
appCommonModule.on('livesync', (args) => clearCache());
appCommonModule.on('orientationChanged', (args) => {
resolverInstance = undefined;
});

4
packages/core/module-name-resolver/non-bundle-workflow-compat.ts
View File

@@ -1,5 +1,5 @@
import { Application } from '../application';
import * as fs from '../file-system';
import * as appCommonModule from '../application/application-common';
import { Trace } from '../trace';
const cache = new Set<string>();
@@ -136,7 +136,7 @@ export function registerModulesFromFileSystem(moduleName: string) {
function initialize() {
if (!initialized) {
appCommonModule.on('livesync', (args) => cache.clear());
Application.on('livesync', (args) => cache.clear());
initialized = true;
}
}