javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 03:31:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3100 from NativeScript/delete-test

Browse Source 
Delete inconsistently failing test
This commit is contained in:
Rossen Hristov
2016-11-15 16:38:39 +02:00
committed by GitHub
parent c5f3fd511a c2b35ffef2
commit f0e24eb26f
1 changed files with 26 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
tests/app/ui/tab-view/tab-view-tests.ts
View File

@ -276,36 +276,35 @@ export class TabViewTest extends testModule.UITest<tabViewModule.TabView> {
TKUnit.assertEqual(actualNewIndex, expectedNewIndex, "expectedNewIndex"); TKUnit.assertEqual(actualNewIndex, expectedNewIndex, "expectedNewIndex");
} }
public testAndroidOffscreenTabLimit_Default = function () { // public testAndroidOffscreenTabLimit_Default = function () {
let tabView = this.testView; // let tabView = this.testView;
if (!tabView.android){ // if (!tabView.android){
return; // return;
} // }
// The default setting is 1. // tabView.androidOffscreenTabLimit = 1;
// tabView.androidOffscreenTabLimit = 1; // tabView.items = this._createItems(20);
tabView.items = this._createItems(20); // this.waitUntilTestElementIsLoaded();
this.waitUntilTestElementIsLoaded(); // for (let index = 0, length = tabView.items.length; index < length; index++){
for (let index = 0, length = tabView.items.length; index < length; index++){ // tabViewTestsNative.selectNativeTab(tabView, index);
tabViewTestsNative.selectNativeTab(tabView, index); // TKUnit.waitUntilReady(function () {
TKUnit.waitUntilReady(function () { // return tabView.selectedIndex === index;
return tabView.selectedIndex === index; // }, helper.ASYNC);
}, helper.ASYNC); // }
}
let viewsWithParent = 0; // let viewsWithParent = 0;
let viewsWithoutParent = 0; // let viewsWithoutParent = 0;
for (let i = 0, length = tabView.items.length; i < length; i++){ // for (let i = 0, length = tabView.items.length; i < length; i++){
if (tabView.items[i].view.parent) { // if (tabView.items[i].view.parent) {
viewsWithParent++; // viewsWithParent++;
} // }
else { // else {
viewsWithoutParent++; // viewsWithoutParent++;
} // }
} // }
TKUnit.assertTrue(viewsWithoutParent > viewsWithParent, `Most of the views should be recycled: viewsWithoutParent = ${viewsWithoutParent}; viewsWithParent = ${viewsWithParent};`); // TKUnit.assertTrue(viewsWithoutParent > viewsWithParent, `Most of the views should be recycled: viewsWithoutParent = ${viewsWithoutParent}; viewsWithParent = ${viewsWithParent};`);
} // }
public testAndroidOffscreenTabLimit_KeepAllAlive = function () { public testAndroidOffscreenTabLimit_KeepAllAlive = function () {
let tabView = this.testView; let tabView = this.testView;