javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix: ListPicker selected index coercing

Browse Source
This commit is contained in:
vakrilov
2017-03-21 16:31:38 +02:00
parent 8e6b510566
commit ef7d9155b2
3 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tns-core-modules/ui/list-picker/list-picker-common.ts
View File

@@ -46,7 +46,6 @@ export const itemsProperty = new Property<ListPickerBase, any[] | ItemsSource>({
name: "items", valueChanged: (target, oldValue, newValue) => { name: "items", valueChanged: (target, oldValue, newValue) => {
let getItem = newValue && (<ItemsSource>newValue).getItem; let getItem = newValue && (<ItemsSource>newValue).getItem;
target.isItemsSource = typeof getItem === "function"; target.isItemsSource = typeof getItem === "function";
selectedIndexProperty.coerce(target);
} }
}); });
itemsProperty.register(ListPickerBase); itemsProperty.register(ListPickerBase);

3
tns-core-modules/ui/list-picker/list-picker.android.ts
View File

@@ -137,6 +137,9 @@ export class ListPicker extends ListPickerBase {
let maxValue = value && value.length > 0 ? value.length - 1 : 0; let maxValue = value && value.length > 0 ? value.length - 1 : 0;
this.android.setMaxValue(maxValue); this.android.setMaxValue(maxValue);
this._fixNumberPickerRendering(); this._fixNumberPickerRendering();
// Coerce selected index after we have set items to native view.
selectedIndexProperty.coerce(this);
} }
get [colorProperty.native](): { wheelColor: number, textColor: number } { get [colorProperty.native](): { wheelColor: number, textColor: number } {

3
tns-core-modules/ui/list-picker/list-picker.ios.ts
View File

@@ -46,6 +46,9 @@ export class ListPicker extends ListPickerBase {
} }
set [itemsProperty.native](value: any[] | ItemsSource) { set [itemsProperty.native](value: any[] | ItemsSource) {
this.ios.reloadAllComponents(); this.ios.reloadAllComponents();
// Coerce selected index after we have set items to native view.
selectedIndexProperty.coerce(this);
} }
get [backgroundColorProperty.native](): UIColor { get [backgroundColorProperty.native](): UIColor {