javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-20 15:34:26 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'android_background_again' of github.com:Akylas/NativeScript

Browse Source 
# Conflicts:
#	packages/core/ui/action-bar/index.android.ts
#	packages/core/ui/button/index.android.ts
#	packages/core/ui/core/view/index.android.ts
This commit is contained in:
Martin Guillon
2021-02-17 17:08:47 +01:00
parent d699bf0033 016313bef1
commit ee48d4ff4d
4 changed files with 39 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/core/ui/action-bar/index.android.ts
View File

@ -225,7 +225,15 @@ export class ActionBar extends ActionBarBase {
const nativeView = this.nativeViewProtected;
if (backgroundDrawable && onlyColor && sdkVersion() >= 21) {
if (isBorderDrawable && (<any>nativeView)._cachedDrawable) {
backgroundDrawable = (<any>nativeView)._cachedDrawable.newDrawable(nativeView.getResources());
backgroundDrawable = (<any>nativeView)._cachedDrawable;
// we need to duplicate the drawable or we lose the "default" cached drawable
const constantState = backgroundDrawable.getConstantState();
if (constantState) {
try {
backgroundDrawable = constantState.newDrawable(nativeView.getResources());
// eslint-disable-next-line no-empty
} catch {}
}
nativeView.setBackground(backgroundDrawable);
}

11
packages/core/ui/button/index.android.ts
View File

@ -62,10 +62,17 @@ export class Button extends ButtonBase {
public _applyBackground(background: Background, isBorderDrawable, onlyColor: boolean, backgroundDrawable: any) {
const nativeView = this.nativeViewProtected;
console.log('_applyBackground', nativeView, backgroundDrawable, onlyColor, isBorderDrawable);
if (backgroundDrawable && onlyColor) {
if (isBorderDrawable && (<any>nativeView)._cachedDrawable) {
backgroundDrawable = (<any>nativeView)._cachedDrawable.newDrawable(nativeView.getResources());
backgroundDrawable = (<any>nativeView)._cachedDrawable;
// we need to duplicate the drawable or we lose the "default" cached drawable
const constantState = backgroundDrawable.getConstantState();
if (constantState) {
try {
backgroundDrawable = constantState.newDrawable(nativeView.getResources());
// eslint-disable-next-line no-empty
} catch {}
}
nativeView.setBackground(backgroundDrawable);
}

2
packages/core/ui/core/view/index.android.ts
View File

@ -1009,7 +1009,7 @@ export class View extends ViewCommon {
if (constantState) {
try {
drawable = constantState.newDrawable(nativeView.getResources());
// eslint-disable-next-line no-empty
// eslint-disable-next-line no-empty
} catch {}
}
}