From e97fd105e3c0b459e7a19e2f5535e2888033d9e1 Mon Sep 17 00:00:00 2001 From: Hristo Hristov Date: Wed, 14 Dec 2016 13:59:50 +0200 Subject: [PATCH] Fix missing exports --- .../ui/layouts/absolute-layout/absolute-layout.android.ts | 2 -- .../ui/layouts/dock-layout/dock-layout.android.ts | 1 - .../ui/layouts/flexbox-layout/flexbox-layout-common.ts | 1 - .../ui/layouts/flexbox-layout/flexbox-layout.android.ts | 5 ----- .../ui/layouts/flexbox-layout/flexbox-layout.ios.ts | 5 ----- .../ui/layouts/grid-layout/grid-layout-common.ts | 1 + .../ui/layouts/grid-layout/grid-layout.android.ts | 4 ---- tns-core-modules/ui/layouts/layout-base.android.ts | 2 ++ tns-core-modules/ui/layouts/layout-base.ios.ts | 2 ++ tns-core-modules/ui/layouts/layout.android.ts | 2 ++ tns-core-modules/ui/layouts/layout.ios.ts | 1 + tsconfig.json | 2 +- 12 files changed, 9 insertions(+), 19 deletions(-) diff --git a/tns-core-modules/ui/layouts/absolute-layout/absolute-layout.android.ts b/tns-core-modules/ui/layouts/absolute-layout/absolute-layout.android.ts index 3a2f5269e..fd28d2492 100644 --- a/tns-core-modules/ui/layouts/absolute-layout/absolute-layout.android.ts +++ b/tns-core-modules/ui/layouts/absolute-layout/absolute-layout.android.ts @@ -6,7 +6,6 @@ export * from "./absolute-layout-common"; let leftDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => zeroLength, set: function (this: View, value: Length) { setNativeProperty(this, (lp) => lp.left = this.effectiveLeft); @@ -17,7 +16,6 @@ let leftDescriptor: TypedPropertyDescriptor = { let topDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => zeroLength, set: function (this: View, value: Length) { setNativeProperty(this, (lp) => lp.top = this.effectiveTop); diff --git a/tns-core-modules/ui/layouts/dock-layout/dock-layout.android.ts b/tns-core-modules/ui/layouts/dock-layout/dock-layout.android.ts index 2216276ca..5854d412e 100644 --- a/tns-core-modules/ui/layouts/dock-layout/dock-layout.android.ts +++ b/tns-core-modules/ui/layouts/dock-layout/dock-layout.android.ts @@ -6,7 +6,6 @@ export * from "./dock-layout-common"; let dockDescriptor: TypedPropertyDescriptor<"left" | "top" | "right" | "bottom"> = { enumerable: true, configurable: true, - writable: true, get: () => "left", set: function (this: View, value: "left" | "top" | "right" | "bottom") { const nativeView: android.view.View = this._nativeView; diff --git a/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout-common.ts b/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout-common.ts index a0dbc1adf..d927b1305 100644 --- a/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout-common.ts +++ b/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout-common.ts @@ -244,7 +244,6 @@ alignItemsProperty.register(Style); export const alignContentProperty = new CssProperty({ name: "alignContent", cssName: "align-content", defaultValue: AlignContent.STRETCH, affectsLayout: isIOS, valueConverter: AlignContent.parse }); alignContentProperty.register(Style); - export const orderProperty = new CssProperty({ name: "order", cssName: "order", defaultValue: ORDER_DEFAULT, valueConverter: Order.parse }); orderProperty.register(Style); diff --git a/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout.android.ts b/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout.android.ts index e878c720e..e505ac6cc 100644 --- a/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout.android.ts +++ b/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout.android.ts @@ -14,7 +14,6 @@ export * from "./flexbox-layout-common"; const orderDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => orderProperty.defaultValue, set: function (this: View, value: Order) { setLayoutParamsProperty(this, (lp) => lp.order = value); @@ -24,7 +23,6 @@ const orderDescriptor: TypedPropertyDescriptor = { const flexGrowDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => flexGrowProperty.defaultValue, set: function (this: View, value: FlexGrow) { setLayoutParamsProperty(this, (lp) => lp.flexGrow = value); @@ -34,7 +32,6 @@ const flexGrowDescriptor: TypedPropertyDescriptor = { const flexShrinkDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => flexShrinkProperty.defaultValue, set: function (this: View, value: FlexShrink) { setLayoutParamsProperty(this, (lp) => lp.flexShrink = value); @@ -44,7 +41,6 @@ const flexShrinkDescriptor: TypedPropertyDescriptor = { const flexWrapBeforeDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => false, set: function (this: View, value: FlexWrapBefore) { setLayoutParamsProperty(this, (lp) => lp.wrapBefore = value); @@ -54,7 +50,6 @@ const flexWrapBeforeDescriptor: TypedPropertyDescriptor = { const alignSelfDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => AlignSelf.AUTO, set: function (this: View, value: AlignSelf) { setLayoutParamsProperty(this, (lp) => lp.alignSelf = alignSelfMap[value]); diff --git a/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout.ios.ts b/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout.ios.ts index 660727468..69c61857b 100644 --- a/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout.ios.ts +++ b/tns-core-modules/ui/layouts/flexbox-layout/flexbox-layout.ios.ts @@ -32,7 +32,6 @@ function childHandler(view) { const orderDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => orderProperty.defaultValue, set: function (this: View, value: OrderBase) { childHandler(this); @@ -42,7 +41,6 @@ const orderDescriptor: TypedPropertyDescriptor = { const flexGrowDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => flexGrowProperty.defaultValue, set: function (this: View, value: FlexGrow) { childHandler(this); @@ -52,7 +50,6 @@ const flexGrowDescriptor: TypedPropertyDescriptor = { const flexShrinkDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => flexShrinkProperty.defaultValue, set: function (this: View, value: FlexShrink) { childHandler(this); @@ -62,7 +59,6 @@ const flexShrinkDescriptor: TypedPropertyDescriptor = { const flexWrapBeforeDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => false, set: function (this: View, value: FlexWrapBefore) { childHandler(this); @@ -72,7 +68,6 @@ const flexWrapBeforeDescriptor: TypedPropertyDescriptor = { const alignSelfDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => AlignSelf.AUTO, set: function (this: View, value: AlignSelf) { childHandler(this); diff --git a/tns-core-modules/ui/layouts/grid-layout/grid-layout-common.ts b/tns-core-modules/ui/layouts/grid-layout/grid-layout-common.ts index 15323f06d..f870f0429 100644 --- a/tns-core-modules/ui/layouts/grid-layout/grid-layout-common.ts +++ b/tns-core-modules/ui/layouts/grid-layout/grid-layout-common.ts @@ -2,6 +2,7 @@ import { LayoutBase, View, Bindable, Property } from "ui/layouts/layout-base"; export * from "ui/layouts/layout-base"; + function validateArgs(element: View): View { if (!element) { throw new Error("element cannot be null or undefinied."); diff --git a/tns-core-modules/ui/layouts/grid-layout/grid-layout.android.ts b/tns-core-modules/ui/layouts/grid-layout/grid-layout.android.ts index 62d10cff9..c830e675b 100644 --- a/tns-core-modules/ui/layouts/grid-layout/grid-layout.android.ts +++ b/tns-core-modules/ui/layouts/grid-layout/grid-layout.android.ts @@ -18,7 +18,6 @@ function setNativeProperty(view: View, setter: (lp: org.nativescript.widgets.Com let rowDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => 0, set: function (this: View, value: number) { setNativeProperty(this, (lp) => lp.row = value); @@ -29,7 +28,6 @@ let rowDescriptor: TypedPropertyDescriptor = { let colDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => 0, set: function (this: View, value: number) { setNativeProperty(this, (lp) => lp.column = value); @@ -40,7 +38,6 @@ let colDescriptor: TypedPropertyDescriptor = { let rowSpanDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => 1, set: function (this: View, value: number) { setNativeProperty(this, (lp) => lp.rowSpan = value); @@ -51,7 +48,6 @@ let rowSpanDescriptor: TypedPropertyDescriptor = { let colSpanDescriptor: TypedPropertyDescriptor = { enumerable: true, configurable: true, - writable: true, get: () => 1, set: function (this: View, value: number) { setNativeProperty(this, (lp) => lp.columnSpan = value); diff --git a/tns-core-modules/ui/layouts/layout-base.android.ts b/tns-core-modules/ui/layouts/layout-base.android.ts index dc2ab65be..7fe7f6e23 100644 --- a/tns-core-modules/ui/layouts/layout-base.android.ts +++ b/tns-core-modules/ui/layouts/layout-base.android.ts @@ -1,5 +1,7 @@ import { LayoutBaseCommon, clipToBoundsProperty } from "./layout-base-common"; +export * from "./layout-base-common"; + export class LayoutBase extends LayoutBaseCommon { get [clipToBoundsProperty.native](): boolean { diff --git a/tns-core-modules/ui/layouts/layout-base.ios.ts b/tns-core-modules/ui/layouts/layout-base.ios.ts index 3457ba600..0d8ff3e55 100644 --- a/tns-core-modules/ui/layouts/layout-base.ios.ts +++ b/tns-core-modules/ui/layouts/layout-base.ios.ts @@ -1,5 +1,7 @@ import { LayoutBaseCommon, clipToBoundsProperty } from "./layout-base-common"; +export * from "./layout-base-common"; + export class LayoutBase extends LayoutBaseCommon { get [clipToBoundsProperty.native](): boolean { diff --git a/tns-core-modules/ui/layouts/layout.android.ts b/tns-core-modules/ui/layouts/layout.android.ts index 64845756f..49059313e 100644 --- a/tns-core-modules/ui/layouts/layout.android.ts +++ b/tns-core-modules/ui/layouts/layout.android.ts @@ -1,6 +1,8 @@ import { Layout as LayoutDefinition } from "ui/layouts/layout"; import { LayoutBase, View, layout, traceEnabled, traceWrite, traceCategories } from "ui/layouts/layout-base"; +export * from "ui/layouts/layout-base"; + const OWNER = Symbol("_owner"); var NativeViewGroupClass; diff --git a/tns-core-modules/ui/layouts/layout.ios.ts b/tns-core-modules/ui/layouts/layout.ios.ts index cced46f2c..eb316d629 100644 --- a/tns-core-modules/ui/layouts/layout.ios.ts +++ b/tns-core-modules/ui/layouts/layout.ios.ts @@ -1,6 +1,7 @@ import { Layout as LayoutDefinition } from "ui/layouts/layout"; import { LayoutBase } from "ui/layouts/layout-base"; +export * from "ui/layouts/layout-base"; export class Layout extends LayoutBase implements LayoutDefinition { private _view: UIView; diff --git a/tsconfig.json b/tsconfig.json index 675ff87ba..735d74ff0 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,6 +1,6 @@ { "compilerOptions": { - "noEmitOnError": true, + "noEmitOnError": false, "noEmitHelpers": true, "target": "es5", "module": "commonjs",