javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(tabs): delay loadView when animation runs (#8353)

Browse Source 
* fix(tabs): delay loadView when animation runs

* chore: update api.md

* chore: remove unnecessary casting

* test: Added disabled test for changing tabs
This commit is contained in:
Vasil Trifonov
2020-02-21 16:47:33 +02:00
committed by GitHub
parent dd11158374
commit e649a6cfd6
14 changed files with 104 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
nativescript-core/ui/core/view-base/view-base.d.ts vendored
View File

@@ -470,6 +470,12 @@ export abstract class ViewBase extends Observable {
*/
_setupAsRootView(context: any): void;
/**
* When returning true the callLoaded method will be run in setTimeout
* Method is intended to be overridden by inheritors and used as "protected"
*/
_shouldDelayLoad(): boolean;
/**
* @private
*/

12
nativescript-core/ui/core/view-base/view-base.ts
View File

@@ -615,10 +615,18 @@ export abstract class ViewBase extends Observable implements ViewBaseDefinition
public loadView(view: ViewBase): void {
if (view && !view.isLoaded) {
view.callLoaded();
if (this._shouldDelayLoad()) {
setTimeout(() => view.callLoaded());
} else {
view.callLoaded();
}
}
}
public _shouldDelayLoad(): boolean {
return false;
}
public unloadView(view: ViewBase): void {
if (view && view.isLoaded) {
view.callUnloaded();
@@ -1053,7 +1061,7 @@ export const classNameProperty = new Property<ViewBase, string>({
cssClasses.clear();
if (shouldAddModalRootViewCssClasses) {
cssClasses.add(MODAL_ROOT_VIEW_CSS_CLASS);
cssClasses.add(MODAL_ROOT_VIEW_CSS_CLASS);
} else if (shouldAddRootViewCssClasses) {
cssClasses.add(ROOT_VIEW_CSS_CLASS);
}