From e62acba79243a91da6a0e915b47751daac3c985e Mon Sep 17 00:00:00 2001 From: Nathan Walker Date: Mon, 15 Mar 2021 20:44:44 -0700 Subject: [PATCH] fix: move BottomNavigation and Tabs to @nativescript-community Cocoapods no longer required with @nativescript/core out of the box and users are no longer taxed with MaterialTabs even if they didn't use those components. BREAKING CHANGES If using `BottomNavigation`, just install `@nativescript-community/ui-material-bottom-navigation` and update your imports to use it. API is exactly the same. If using `Tabs`, just install `@nativescript-community/ui-material-tabs` and update your imports to use it. API is exactly the same. --- .../bottom-navigation-navigation-tests.ts | 284 ---- .../bottom-navigation-root-tests.ts | 177 --- .../bottom-navigation-tests-native.android.ts | 40 - .../bottom-navigation-tests-native.d.ts | 8 - .../bottom-navigation-tests-native.ios.ts | 35 - .../bottom-navigation-tests-new.ts | 33 - .../bottom-navigation-tests.ts | 347 ----- .../src/ui/tabs/tabs-navigation-tests.ts | 284 ---- apps/automated/src/ui/tabs/tabs-root-tests.ts | 194 --- .../src/ui/tabs/tabs-tests-native.android.ts | 40 - .../src/ui/tabs/tabs-tests-native.d.ts | 8 - .../src/ui/tabs/tabs-tests-native.ios.ts | 44 - apps/automated/src/ui/tabs/tabs-tests-new.ts | 33 - apps/automated/src/ui/tabs/tabs-tests.ts | 350 ----- .../bottom-navigation-base-page.ts | 34 - ...ttom-navigation-css-properties.e2e-spec.ts | 73 - .../bottom-navigation.e2e-spec.ts | 371 ----- .../tabs/tabs-tests.e2e-spec.ts | 370 ----- .../tabs/tabs-view-base-page.ts | 39 - .../background-color-page.css | 19 - .../background-color-page.xml | 24 - apps/ui/src/bottom-navigation/binding-page.ts | 6 - .../ui/src/bottom-navigation/binding-page.xml | 19 - .../bottom-navigation-css-page.css | 1 - .../bottom-navigation-css-page.ts | 19 - .../bottom-navigation-css-page.xml | 35 - .../bottom-navigation-page.ts | 17 - .../bottom-navigation-page.xml | 59 - .../bottom-navigation-view-model.ts | 58 - apps/ui/src/bottom-navigation/color-page.css | 27 - apps/ui/src/bottom-navigation/color-page.xml | 33 - .../custom-tabstrip-page.css | 31 - .../bottom-navigation/custom-tabstrip-page.ts | 24 - .../custom-tabstrip-page.xml | 41 - .../dynamic-color-change-page.css | 28 - .../dynamic-color-change-page.ts | 39 - .../dynamic-color-change-page.xml | 44 - apps/ui/src/bottom-navigation/events-page.ts | 42 - apps/ui/src/bottom-navigation/events-page.xml | 36 - .../bottom-navigation/fancy-fonts-page.css | 45 - .../src/bottom-navigation/fancy-fonts-page.ts | 9 - .../bottom-navigation/fancy-fonts-page.xml | 82 -- apps/ui/src/bottom-navigation/first-page.ts | 14 - apps/ui/src/bottom-navigation/first-page.xml | 7 - .../src/bottom-navigation/font-icons-page.css | 39 - .../src/bottom-navigation/font-icons-page.xml | 63 - apps/ui/src/bottom-navigation/font-page.css | 27 - apps/ui/src/bottom-navigation/font-page.xml | 33 - .../src/bottom-navigation/icon-change-page.ts | 17 - .../bottom-navigation/icon-change-page.xml | 23 - .../icon-title-placement-page.xml | 30 - .../src/bottom-navigation/issue-5470-page.xml | 27 - .../src/bottom-navigation/item-color-page.css | 7 - .../src/bottom-navigation/item-color-page.xml | 40 - apps/ui/src/bottom-navigation/main-page.ts | 33 - apps/ui/src/bottom-navigation/main-page.xml | 6 - .../ui/src/bottom-navigation/reselect-page.ts | 56 - .../src/bottom-navigation/reselect-page.xml | 37 - apps/ui/src/bottom-navigation/second-page.ts | 13 - apps/ui/src/bottom-navigation/second-page.xml | 7 - .../bottom-navigation/text-transform-page.css | 27 - .../bottom-navigation/text-transform-page.xml | 33 - apps/ui/src/main-page.ts | 2 - apps/ui/src/tabs/background-color-page.css | 19 - apps/ui/src/tabs/background-color-page.xml | 24 - apps/ui/src/tabs/color-page.css | 27 - apps/ui/src/tabs/color-page.xml | 33 - apps/ui/src/tabs/custom-tabstrip-page.css | 31 - apps/ui/src/tabs/custom-tabstrip-page.ts | 22 - apps/ui/src/tabs/custom-tabstrip-page.xml | 41 - apps/ui/src/tabs/default-page.ts | 15 - apps/ui/src/tabs/default-page.xml | 89 -- .../ui/src/tabs/dynamic-color-change-page.css | 28 - apps/ui/src/tabs/dynamic-color-change-page.ts | 37 - .../ui/src/tabs/dynamic-color-change-page.xml | 44 - apps/ui/src/tabs/events-page.ts | 40 - apps/ui/src/tabs/events-page.xml | 36 - apps/ui/src/tabs/first-page.ts | 13 - apps/ui/src/tabs/first-page.xml | 7 - apps/ui/src/tabs/font-icons-page.css | 39 - apps/ui/src/tabs/font-icons-page.xml | 63 - apps/ui/src/tabs/font-page.css | 27 - apps/ui/src/tabs/font-page.xml | 33 - .../src/tabs/frame-in-tabs-inner-page-1.xml | 12 - .../src/tabs/frame-in-tabs-inner-page-2.xml | 3 - .../src/tabs/frame-in-tabs-inner-page-3.xml | 3 - .../src/tabs/frame-in-tabs-inner-page-4.xml | 3 - apps/ui/src/tabs/frame-in-tabs-overflow.xml | 24 - apps/ui/src/tabs/frame-in-tabs.ts | 3 - apps/ui/src/tabs/frame-in-tabs.xml | 24 - apps/ui/src/tabs/highlight-color-page.css | 3 - apps/ui/src/tabs/highlight-color-page.xml | 24 - apps/ui/src/tabs/icon-change-page.ts | 17 - apps/ui/src/tabs/icon-change-page.xml | 23 - .../ui/src/tabs/icon-title-placement-page.xml | 30 - apps/ui/src/tabs/issue-5470-page.xml | 27 - apps/ui/src/tabs/item-color-page.css | 20 - apps/ui/src/tabs/item-color-page.xml | 40 - apps/ui/src/tabs/main-page.ts | 39 - apps/ui/src/tabs/main-page.xml | 6 - .../tabs/nested-bottom-navigation-page.xml | 39 - apps/ui/src/tabs/nested-layout-page.xml | 26 - apps/ui/src/tabs/reselect-page.ts | 68 - apps/ui/src/tabs/reselect-page.xml | 37 - apps/ui/src/tabs/second-page.ts | 13 - apps/ui/src/tabs/second-page.xml | 7 - apps/ui/src/tabs/swipe-disabled-page.ts | 15 - apps/ui/src/tabs/swipe-disabled-page.xml | 40 - apps/ui/src/tabs/tab-strip-item-page.xml | 16 - apps/ui/src/tabs/tab-strip-items-page.xml | 88 -- apps/ui/src/tabs/tabs-binding-page.ts | 6 - apps/ui/src/tabs/tabs-binding-page.xml | 17 - apps/ui/src/tabs/tabs-binding-view-model.ts | 59 - apps/ui/src/tabs/tabs-page.ts | 15 - apps/ui/src/tabs/tabs-page.xml | 36 - apps/ui/src/tabs/tabs-position-page.xml | 40 - apps/ui/src/tabs/text-transform-page.css | 27 - apps/ui/src/tabs/text-transform-page.xml | 33 - packages/core/platforms/ios/Podfile | 12 - .../ui/bottom-navigation/index.android.ts | 944 ------------- packages/core/ui/bottom-navigation/index.d.ts | 72 - .../core/ui/bottom-navigation/index.ios.ts | 817 ----------- .../tab-content-item/index.android.ts | 76 - .../tab-content-item/index.d.ts | 11 - .../tab-content-item/index.ios.ts | 32 - .../tab-content-item-common.ts | 29 - .../tab-navigation-base/index.d.ts | 255 ---- .../tab-navigation-base/index.ts | 334 ----- .../tab-strip-item/index.d.ts | 70 - .../tab-strip-item/index.ts | 292 ---- .../tab-navigation-base/tab-strip/index.d.ts | 83 -- .../ui/tab-navigation-base/tab-strip/index.ts | 206 --- packages/core/ui/tabs/index.android.ts | 1004 ------------- packages/core/ui/tabs/index.d.ts | 100 -- packages/core/ui/tabs/index.ios.ts | 1255 ----------------- packages/core/ui/tabs/tabs-common.ts | 53 - 136 files changed, 11239 deletions(-) delete mode 100644 apps/automated/src/ui/bottom-navigation/bottom-navigation-navigation-tests.ts delete mode 100644 apps/automated/src/ui/bottom-navigation/bottom-navigation-root-tests.ts delete mode 100644 apps/automated/src/ui/bottom-navigation/bottom-navigation-tests-native.android.ts delete mode 100644 apps/automated/src/ui/bottom-navigation/bottom-navigation-tests-native.d.ts delete mode 100644 apps/automated/src/ui/bottom-navigation/bottom-navigation-tests-native.ios.ts delete mode 100644 apps/automated/src/ui/bottom-navigation/bottom-navigation-tests-new.ts delete mode 100644 apps/automated/src/ui/bottom-navigation/bottom-navigation-tests.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-navigation-tests.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-root-tests.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-tests-native.android.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-tests-native.d.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-tests-native.ios.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-tests-new.ts delete mode 100644 apps/automated/src/ui/tabs/tabs-tests.ts delete mode 100644 apps/ui/e2e/suites/tab-navigation/bottom-navigation/bottom-navigation-base-page.ts delete mode 100644 apps/ui/e2e/suites/tab-navigation/bottom-navigation/bottom-navigation-css-properties.e2e-spec.ts delete mode 100644 apps/ui/e2e/suites/tab-navigation/bottom-navigation/bottom-navigation.e2e-spec.ts delete mode 100644 apps/ui/e2e/suites/tab-navigation/tabs/tabs-tests.e2e-spec.ts delete mode 100644 apps/ui/e2e/suites/tab-navigation/tabs/tabs-view-base-page.ts delete mode 100644 apps/ui/src/bottom-navigation/background-color-page.css delete mode 100644 apps/ui/src/bottom-navigation/background-color-page.xml delete mode 100644 apps/ui/src/bottom-navigation/binding-page.ts delete mode 100644 apps/ui/src/bottom-navigation/binding-page.xml delete mode 100644 apps/ui/src/bottom-navigation/bottom-navigation-css-page.css delete mode 100644 apps/ui/src/bottom-navigation/bottom-navigation-css-page.ts delete mode 100644 apps/ui/src/bottom-navigation/bottom-navigation-css-page.xml delete mode 100644 apps/ui/src/bottom-navigation/bottom-navigation-page.ts delete mode 100644 apps/ui/src/bottom-navigation/bottom-navigation-page.xml delete mode 100644 apps/ui/src/bottom-navigation/bottom-navigation-view-model.ts delete mode 100644 apps/ui/src/bottom-navigation/color-page.css delete mode 100644 apps/ui/src/bottom-navigation/color-page.xml delete mode 100644 apps/ui/src/bottom-navigation/custom-tabstrip-page.css delete mode 100644 apps/ui/src/bottom-navigation/custom-tabstrip-page.ts delete mode 100644 apps/ui/src/bottom-navigation/custom-tabstrip-page.xml delete mode 100644 apps/ui/src/bottom-navigation/dynamic-color-change-page.css delete mode 100644 apps/ui/src/bottom-navigation/dynamic-color-change-page.ts delete mode 100644 apps/ui/src/bottom-navigation/dynamic-color-change-page.xml delete mode 100644 apps/ui/src/bottom-navigation/events-page.ts delete mode 100644 apps/ui/src/bottom-navigation/events-page.xml delete mode 100644 apps/ui/src/bottom-navigation/fancy-fonts-page.css delete mode 100644 apps/ui/src/bottom-navigation/fancy-fonts-page.ts delete mode 100644 apps/ui/src/bottom-navigation/fancy-fonts-page.xml delete mode 100644 apps/ui/src/bottom-navigation/first-page.ts delete mode 100644 apps/ui/src/bottom-navigation/first-page.xml delete mode 100644 apps/ui/src/bottom-navigation/font-icons-page.css delete mode 100644 apps/ui/src/bottom-navigation/font-icons-page.xml delete mode 100644 apps/ui/src/bottom-navigation/font-page.css delete mode 100644 apps/ui/src/bottom-navigation/font-page.xml delete mode 100644 apps/ui/src/bottom-navigation/icon-change-page.ts delete mode 100644 apps/ui/src/bottom-navigation/icon-change-page.xml delete mode 100644 apps/ui/src/bottom-navigation/icon-title-placement-page.xml delete mode 100644 apps/ui/src/bottom-navigation/issue-5470-page.xml delete mode 100644 apps/ui/src/bottom-navigation/item-color-page.css delete mode 100644 apps/ui/src/bottom-navigation/item-color-page.xml delete mode 100644 apps/ui/src/bottom-navigation/main-page.ts delete mode 100644 apps/ui/src/bottom-navigation/main-page.xml delete mode 100644 apps/ui/src/bottom-navigation/reselect-page.ts delete mode 100644 apps/ui/src/bottom-navigation/reselect-page.xml delete mode 100644 apps/ui/src/bottom-navigation/second-page.ts delete mode 100644 apps/ui/src/bottom-navigation/second-page.xml delete mode 100644 apps/ui/src/bottom-navigation/text-transform-page.css delete mode 100644 apps/ui/src/bottom-navigation/text-transform-page.xml delete mode 100644 apps/ui/src/tabs/background-color-page.css delete mode 100644 apps/ui/src/tabs/background-color-page.xml delete mode 100644 apps/ui/src/tabs/color-page.css delete mode 100644 apps/ui/src/tabs/color-page.xml delete mode 100644 apps/ui/src/tabs/custom-tabstrip-page.css delete mode 100644 apps/ui/src/tabs/custom-tabstrip-page.ts delete mode 100644 apps/ui/src/tabs/custom-tabstrip-page.xml delete mode 100644 apps/ui/src/tabs/default-page.ts delete mode 100644 apps/ui/src/tabs/default-page.xml delete mode 100644 apps/ui/src/tabs/dynamic-color-change-page.css delete mode 100644 apps/ui/src/tabs/dynamic-color-change-page.ts delete mode 100644 apps/ui/src/tabs/dynamic-color-change-page.xml delete mode 100644 apps/ui/src/tabs/events-page.ts delete mode 100644 apps/ui/src/tabs/events-page.xml delete mode 100644 apps/ui/src/tabs/first-page.ts delete mode 100644 apps/ui/src/tabs/first-page.xml delete mode 100644 apps/ui/src/tabs/font-icons-page.css delete mode 100644 apps/ui/src/tabs/font-icons-page.xml delete mode 100644 apps/ui/src/tabs/font-page.css delete mode 100644 apps/ui/src/tabs/font-page.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs-inner-page-1.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs-inner-page-2.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs-inner-page-3.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs-inner-page-4.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs-overflow.xml delete mode 100644 apps/ui/src/tabs/frame-in-tabs.ts delete mode 100644 apps/ui/src/tabs/frame-in-tabs.xml delete mode 100644 apps/ui/src/tabs/highlight-color-page.css delete mode 100644 apps/ui/src/tabs/highlight-color-page.xml delete mode 100644 apps/ui/src/tabs/icon-change-page.ts delete mode 100644 apps/ui/src/tabs/icon-change-page.xml delete mode 100644 apps/ui/src/tabs/icon-title-placement-page.xml delete mode 100644 apps/ui/src/tabs/issue-5470-page.xml delete mode 100644 apps/ui/src/tabs/item-color-page.css delete mode 100644 apps/ui/src/tabs/item-color-page.xml delete mode 100644 apps/ui/src/tabs/main-page.ts delete mode 100644 apps/ui/src/tabs/main-page.xml delete mode 100644 apps/ui/src/tabs/nested-bottom-navigation-page.xml delete mode 100644 apps/ui/src/tabs/nested-layout-page.xml delete mode 100644 apps/ui/src/tabs/reselect-page.ts delete mode 100644 apps/ui/src/tabs/reselect-page.xml delete mode 100644 apps/ui/src/tabs/second-page.ts delete mode 100644 apps/ui/src/tabs/second-page.xml delete mode 100644 apps/ui/src/tabs/swipe-disabled-page.ts delete mode 100644 apps/ui/src/tabs/swipe-disabled-page.xml delete mode 100644 apps/ui/src/tabs/tab-strip-item-page.xml delete mode 100644 apps/ui/src/tabs/tab-strip-items-page.xml delete mode 100644 apps/ui/src/tabs/tabs-binding-page.ts delete mode 100644 apps/ui/src/tabs/tabs-binding-page.xml delete mode 100644 apps/ui/src/tabs/tabs-binding-view-model.ts delete mode 100644 apps/ui/src/tabs/tabs-page.ts delete mode 100644 apps/ui/src/tabs/tabs-page.xml delete mode 100644 apps/ui/src/tabs/tabs-position-page.xml delete mode 100644 apps/ui/src/tabs/text-transform-page.css delete mode 100644 apps/ui/src/tabs/text-transform-page.xml delete mode 100644 packages/core/platforms/ios/Podfile delete mode 100644 packages/core/ui/bottom-navigation/index.android.ts delete mode 100644 packages/core/ui/bottom-navigation/index.d.ts delete mode 100644 packages/core/ui/bottom-navigation/index.ios.ts delete mode 100644 packages/core/ui/tab-navigation-base/tab-content-item/index.android.ts delete mode 100644 packages/core/ui/tab-navigation-base/tab-content-item/index.d.ts delete mode 100644 packages/core/ui/tab-navigation-base/tab-content-item/index.ios.ts delete mode 100644 packages/core/ui/tab-navigation-base/tab-content-item/tab-content-item-common.ts delete mode 100644 packages/core/ui/tab-navigation-base/tab-navigation-base/index.d.ts delete mode 100644 packages/core/ui/tab-navigation-base/tab-navigation-base/index.ts delete mode 100644 packages/core/ui/tab-navigation-base/tab-strip-item/index.d.ts delete mode 100644 packages/core/ui/tab-navigation-base/tab-strip-item/index.ts delete mode 100644 packages/core/ui/tab-navigation-base/tab-strip/index.d.ts delete mode 100644 packages/core/ui/tab-navigation-base/tab-strip/index.ts delete mode 100644 packages/core/ui/tabs/index.android.ts delete mode 100644 packages/core/ui/tabs/index.d.ts delete mode 100644 packages/core/ui/tabs/index.ios.ts delete mode 100644 packages/core/ui/tabs/tabs-common.ts diff --git a/apps/automated/src/ui/bottom-navigation/bottom-navigation-navigation-tests.ts b/apps/automated/src/ui/bottom-navigation/bottom-navigation-navigation-tests.ts deleted file mode 100644 index 01789168d..000000000 --- a/apps/automated/src/ui/bottom-navigation/bottom-navigation-navigation-tests.ts +++ /dev/null @@ -1,284 +0,0 @@ -import * as TKUnit from '../../tk-unit'; -import * as helper from '../../ui-helper'; -import { Label } from '@nativescript/core/ui/label'; -import { StackLayout } from '@nativescript/core/ui/layouts/stack-layout'; -import { Frame } from '@nativescript/core/ui/frame'; -import { Page } from '@nativescript/core/ui/page'; -import { ListView, ItemEventData } from '@nativescript/core/ui/list-view'; -import { BottomNavigation, TabContentItem, TabStrip, TabStripItem } from '@nativescript/core'; -import { Button } from '@nativescript/core/ui/button'; - -var ASYNC = 2; - -function _createBottomNavigation(): BottomNavigation { - var tabView = new BottomNavigation(); - tabView.id = 'BottomNavigation'; - - return tabView; -} - -function _createContentItems(count: number): Array { - const items = new Array(); - for (let i = 0; i < count; i++) { - const label = new Label(); - label.text = 'Tab ' + i; - const tabEntry = new TabContentItem(); - tabEntry.content = label; - items.push(tabEntry); - } - - return items; -} - -function _createTabStrip(count: number): TabStrip { - const items = new Array(); - for (let i = 0; i < count; i++) { - let tabStripEntry = new TabStripItem(); - tabStripEntry.title = 'Tab ' + i; - items.push(tabStripEntry); - } - - const tabStrip = new TabStrip(); - tabStrip.items = items; - - return tabStrip; -} - -function _createListView(): ListView { - var listView = new ListView(); - listView.id = 'ListView'; - var items = Array.apply(null, Array(10)).map(function (_, i) { - return i; - }); - - listView.on(ListView.itemLoadingEvent, function (args: ItemEventData) { - var button =