From e6250e718a613baea83d2eeb8dc0d426ce4fdc9e Mon Sep 17 00:00:00 2001 From: Hristo Hristov Date: Tue, 28 Mar 2017 18:08:39 +0300 Subject: [PATCH] Disable recycling of native views createNativeView will set iOS nativeView if it is null/undefined --- tests/app/testRunner.ts | 5 +++- tests/app/ui/core/bindable/bindable-tests.ts | 4 +-- tests/app/ui/list-view/list-view-tests.ts | 6 ++-- tests/app/ui/repeater/repeater-tests.ts | 2 +- .../application/application-common.ts | 8 ++--- .../application/application.android.ts | 12 ++++---- tns-core-modules/application/application.d.ts | 18 +++++------- .../application/application.ios.ts | 18 +++++++----- .../ui/action-bar/action-bar.android.ts | 4 ++- .../activity-indicator-common.ts | 2 +- tns-core-modules/ui/border/border.ts | 2 +- tns-core-modules/ui/button/button-common.ts | 2 +- tns-core-modules/ui/button/button.android.ts | 2 ++ .../ui/content-view/content-view.ts | 2 +- tns-core-modules/ui/core/bindable/bindable.ts | 7 +++-- .../ui/core/view-base/view-base.ts | 6 ++-- .../ui/date-picker/date-picker-common.ts | 2 +- .../ui/date-picker/date-picker.android.ts | 2 ++ .../editable-text-base.android.ts | 1 + tns-core-modules/ui/frame/frame.android.ts | 29 ++----------------- .../ui/html-view/html-view-common.ts | 2 +- tns-core-modules/ui/image/image-common.ts | 2 +- tns-core-modules/ui/image/image.android.ts | 2 ++ tns-core-modules/ui/label/label.android.ts | 5 ++-- tns-core-modules/ui/label/label.ios.ts | 2 +- .../absolute-layout/absolute-layout-common.ts | 2 +- .../layouts/dock-layout/dock-layout-common.ts | 2 +- .../flexbox-layout/flexbox-layout-common.ts | 2 +- .../flexbox-layout/flexbox-layout.android.ts | 1 + .../layouts/grid-layout/grid-layout-common.ts | 2 +- .../grid-layout/grid-layout.android.ts | 3 ++ tns-core-modules/ui/layouts/layout.android.ts | 1 + .../stack-layout/stack-layout-common.ts | 2 +- .../layouts/wrap-layout/wrap-layout-common.ts | 2 +- .../ui/list-picker/list-picker-common.ts | 2 +- .../ui/list-picker/list-picker.android.ts | 2 ++ .../ui/list-view/list-view-common.ts | 2 +- .../ui/list-view/list-view.android.ts | 1 + tns-core-modules/ui/page/page.android.ts | 1 + .../ui/progress/progress-common.ts | 2 +- tns-core-modules/ui/repeater/repeater.ts | 2 +- .../ui/scroll-view/scroll-view.android.ts | 2 +- .../ui/scroll-view/scroll-view.ios.ts | 2 +- .../ui/search-bar/search-bar-common.ts | 2 +- .../ui/search-bar/search-bar.android.ts | 2 ++ .../ui/segmented-bar/segmented-bar-common.ts | 2 +- .../ui/segmented-bar/segmented-bar.android.ts | 2 ++ tns-core-modules/ui/slider/slider-common.ts | 2 +- tns-core-modules/ui/slider/slider.android.ts | 2 ++ tns-core-modules/ui/switch/switch-common.ts | 2 +- tns-core-modules/ui/switch/switch.android.ts | 2 ++ .../ui/tab-view/tab-view.android.ts | 2 ++ .../ui/text-base/text-base.android.ts | 1 + .../ui/text-field/text-field-common.ts | 2 +- .../ui/text-view/text-view.android.ts | 2 +- .../ui/text-view/text-view.ios.ts | 2 +- .../ui/time-picker/time-picker-common.ts | 2 +- .../ui/time-picker/time-picker.android.ts | 1 + .../ui/web-view/web-view.android.ts | 1 + 59 files changed, 112 insertions(+), 97 deletions(-) diff --git a/tests/app/testRunner.ts b/tests/app/testRunner.ts index 6f8167b1e..4988877e4 100644 --- a/tests/app/testRunner.ts +++ b/tests/app/testRunner.ts @@ -346,7 +346,10 @@ function printRunTestStats() { messageContainer.focus(); page.style.fontSize = 11; if (page.android) { - setTimeout(() => messageContainer.dismissSoftInput()); + setTimeout(() => { + messageContainer.dismissSoftInput(); + (messageContainer.nativeView).scrollTo(0, 0); + }); } } diff --git a/tests/app/ui/core/bindable/bindable-tests.ts b/tests/app/ui/core/bindable/bindable-tests.ts index 7ebb0285e..560a6b4cd 100644 --- a/tests/app/ui/core/bindable/bindable-tests.ts +++ b/tests/app/ui/core/bindable/bindable-tests.ts @@ -604,7 +604,7 @@ export function test_BindingToDictionaryAtAppLevel() { pageViewModel.set("testProperty", testPropertyName); const dict = {}; dict[testPropertyName] = expectedValue; - appModule.resources["dict"] = dict; + appModule.getResources()["dict"] = dict; const testFunc = function (views: Array) { const testLabel =