javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-11-05 13:26:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

feat(http): better binary support & XHR support (#7707)

Browse Source 
* feat(http): binary upload support

* feat(http): better binary support & XHR support

* fix: linting issue

* chore: moved files from old place to the new one

* chore: Updated NativeScript.api.md

* feat(http): support both ByteBuffer and String

Co-authored-by: Vasil Trifonov <v.trifonov@gmail.com>
This commit is contained in:
Stefan Andres Charsley
2020-01-29 02:22:32 +13:00
committed by Vasil Trifonov
parent a311a922b5
commit e293367dfc
23 changed files with 1249 additions and 486 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
tests/app/fetch/fetch-tests.ts
View File

@@ -54,6 +54,30 @@ export var test_fetch_formData = function (done: (err: Error, res?: string) => v
// << fetch-formdata
};
export var test_fetch_blob = function (done: (err: Error, res?: string) => void) {
// >> fetch-blob
fetch("https://httpbin.org/get").then(response => response.blob()).then(function (r) {
// Argument (r) is Blob object!
// >> (hide)
TKUnit.assertNotNull(r, "Result from blob() should be Blob object!");
done(null);
// << (hide)
}).catch(failOnError(done));
// << fetch-blob
};
export var test_fetch_arraybuffer = function (done: (err: Error, res?: string) => void) {
// >> fetch-arraybuffer
fetch("https://httpbin.org/get").then(response => response.arrayBuffer()).then(function (r) {
// Argument (r) is ArrayBuffer object!
// >> (hide)
TKUnit.assertNotNull(r, "Result from arrayBuffer() should be ArrayBuffer object!");
done(null);
// << (hide)
}).catch(failOnError(done));
// << fetch-arraybuffer
};
export var test_fetch_fail_invalid_url = function (done) {
var completed: boolean;
var isReady = function () { return completed; };
@@ -64,12 +88,13 @@ export var test_fetch_fail_invalid_url = function (done) {
}).catch(failOnError(done));
};
export var test_fetch_invalid_url_fail_message = function (done) {
fetch("hgfttp://httpbin.org/get").catch(function (e: TypeError) {
TKUnit.assert(e.message.match(/Network request failed:.{2,}/), "Failure message should contain details on the failure. Actual message was: " + e.message);
done(null);
}).catch(failOnError(done));
};
// Note: fetch is unable to do url validation
// export var test_fetch_invalid_url_fail_message = function (done) {
// fetch("hgfttp://httpbin.org/get").catch(function (e: TypeError) {
// TKUnit.assert(e.message.match(/Network request failed:.{2,}/), "Failure message should contain details on the failure. Actual message was: " + e.message);
// done(null);
// }).catch(failOnError(done));
// };
export var test_fetch_response_status = function (done) {

2
tests/app/http/http-string-worker.ts
View File

@@ -1,5 +1,7 @@
import * as http from "@nativescript/core/http";
(<any>global).FormData = class FormData {};
declare var postMessage: any;
http.getString("https://httpbin.org/get").then(function (r) {

42
tests/app/http/http-tests.ts
View File

@@ -24,20 +24,21 @@ export var test_getString_fail = function (done) {
});
};
export var test_getString_fail_when_result_is_not_string = function (done) {
var result;
// TODO: should this be kept? many decoders will decode the png data into text (even if it's gibberish)
// export var test_getString_fail_when_result_is_not_string = function (done) {
// var result;
http.getString({ url: "https://httpbin.org/image/png", method: "GET" }).catch(function (e) {
result = e;
try {
TKUnit.assert(result instanceof Error, "Result from getString().catch() should be Error! Current type is " + typeof result);
done(null);
}
catch (err) {
done(err);
}
});
};
// http.getString({ url: "https://httpbin.org/image/png", method: "GET" }).then(function (e) {
// result = e;
// try {
// TKUnit.assert(result instanceof Error, "Result from getString().catch() should be Error! Current type is " + typeof result);
// done(null);
// }
// catch (err) {
// done(err);
// }
// });
// };
export var test_getJSON_isDefined = function () {
TKUnit.assert(typeof (http.getJSON) !== "undefined", "Method http.getJSON() should be defined!");
@@ -635,13 +636,16 @@ export var test_request_jsonAsContentSentAndReceivedProperly = function (done) {
});
};
declare var Worker: any;
export var test_getString_WorksProperlyInWorker = function (done) {
let worker = new Worker("./http-string-worker");
worker.onmessage = function (msg) {
export var test_getString_WorksProperlyInWorker = function(done) {
const HttpStringWorker = require("nativescript-worker-loader!./http-string-worker");
let worker = new HttpStringWorker();
console.log("Worker Created");
worker.onmessage = function(msg) {
console.log("Message received");
done();
};
worker.onerror = function (e) {
worker.onerror = function(e) {
console.log("errir received");
done(e);
};
};
};

2
tests/app/test-runner.ts
View File

@@ -46,6 +46,8 @@ allTests["PLATFORM"] = platformTests;
import * as fsTests from "./file-system/file-system-tests";
allTests["FILE-SYSTEM"] = fsTests;
// Disabled tests as they have external dependencies
// TODO: find a way to run these tests locally, but don't run them on the CI as they are flaky
// import * as httpTests from "./http/http-tests";
// allTests["HTTP"] = httpTests;

121
tests/app/xhr/xhr-tests.ts
View File

@@ -110,17 +110,6 @@ export var test_XMLHttpRequest_headersSentAndReceivedProperly = function (done)
// </snippet>
};
export var test_XMLHttpRequest_setResponseTypeShouldNotThrow = function (done) {
try {
var xhr = new XMLHttpRequest();
(<any>xhr)._setResponseType();
done(null);
}
catch (err) {
done(err);
}
};
export var test_XMLHttpRequest_contentSentAndReceivedProperly = function (done) {
// <snippet module="xhr" title="xhr">
// ### Send/receive JSON
@@ -128,14 +117,12 @@ export var test_XMLHttpRequest_contentSentAndReceivedProperly = function (done)
let xhr = new XMLHttpRequest();
xhr.open("POST", "https://httpbin.org/post");
xhr.setRequestHeader("Content-Type", "application/json");
xhr.responseType = "json";
xhr.onreadystatechange = function () {
if (xhr.readyState > 3) {
var result = JSON.parse(xhr.responseText);
// var valueOne = result["json"]["MyVariableOne"];
// <hide>
try {
TKUnit.assert(result["json"]["MyVariableOne"] === "ValueOne" && result["json"]["MyVariableTwo"] === "ValueTwo", "Content not sent/received properly!");
TKUnit.assert(xhr.response.json.MyVariableOne === "ValueOne" && xhr.response.json.MyVariableTwo === "ValueTwo", "Response content not parsed properly!");
TKUnit.assert(xhr.response.json.MyVariableOne === "ValueOne" && xhr.response.json.MyVariableTwo === "ValueTwo", "Response content not parsed properly!" + JSON.stringify(xhr.response));
done(null);
}
catch (err) {
@@ -182,7 +169,7 @@ export var test_XMLHttpRequest_FormDataContentSentAndReceivedProperly = function
};
export var test_XMLHttpRequest_abortShouldCancelonreadystatechange = function (done) {
var flag = false;
let flag = false;
// <snippet module="xhr" title="xhr">
// ### Abort request
// ``` JavaScript
@@ -198,11 +185,11 @@ export var test_XMLHttpRequest_abortShouldCancelonreadystatechange = function (d
xhr.abort();
// ```
// </snippet>
TKUnit.assert(flag === false, "Content not sent/received properly!");
TKUnit.assert(flag, "Content not sent/received properly!");
done(null);
};
export var test_XMLHttpRequest_requestShouldBePossibleAfterAbort = function (done) {
export var test_XMLHttpRequest_requestShouldBePossibleAfterAbortedOpen = function (done) {
xhr = new XMLHttpRequest();
xhr.open("POST", "https://httpbin.org/post");
xhr.setRequestHeader("Content-Type", "application/json");
@@ -218,12 +205,26 @@ export var test_XMLHttpRequest_requestShouldBePossibleAfterAbort = function (don
}
}
};
xhr.send(JSON.stringify({ MyVariableOne: "ValueOne", MyVariableTwo: "ValueTwo" }));
xhr.abort();
xhr.send(JSON.stringify({ MyVariableOne: "ValueOne", MyVariableTwo: "ValueTwo" }));
};
export var test_XMLHttpRequest_requestShouldntBePossibleAfterAbortedSentRequest = function () {
xhr = new XMLHttpRequest();
xhr.open("POST", "https://httpbin.org/post");
xhr.setRequestHeader("Content-Type", "application/json");
xhr.send(JSON.stringify({ MyVariableOne: "ValueOne", MyVariableTwo: "ValueTwo" }));
xhr.abort();
TKUnit.assertThrows(
() => xhr.send(JSON.stringify({ MyVariableOne: "ValueOne", MyVariableTwo: "ValueTwo" })),
"Didn't raise re-attempt to send after aborted send",
"Failed to execute 'send' on 'XMLHttpRequest': The object's state must be OPENED."
);
};
export function test_ignore_zero_length_request_body() {
let xhr = new XMLHttpRequest();
xhr.open("GET", "https://httpbin.org/get");
@@ -262,7 +263,7 @@ export function test_xhr_events() {
xhr.removeEventListener("error", badEvent);
xhr._errorFlag = true;
xhr._setReadyState(xhr.DONE, "error data");
xhr._setRequestError("error", "error data");
TKUnit.assertEqual(errorCallbackData, "error data");
TKUnit.assertEqual(errorEventData, "error data");
}
@@ -282,7 +283,7 @@ export function test_xhr_responseType_rss() {
};
xhr._loadResponse(response);
TKUnit.assertEqual(xhr.responseType, "text");
TKUnit.assertEqual(xhr.responseType, "");
TKUnit.assertEqual(xhr.response, rawRssFeed);
}
@@ -301,11 +302,11 @@ export function test_xhr_responseType_text() {
};
xhr._loadResponse(response);
TKUnit.assertEqual(xhr.responseType, "text");
TKUnit.assertEqual(xhr.responseType, "");
TKUnit.assertEqual(xhr.response, "response body");
}
export function test_xhr_responseType_switched_to_JSON_if_header_present() {
export function test_xhr_responseType_should_not_switch_to_JSON_if_header_present() {
const xhr = <any>new XMLHttpRequest();
const response = {
statusCode: 200,
@@ -320,11 +321,11 @@ export function test_xhr_responseType_switched_to_JSON_if_header_present() {
};
xhr._loadResponse(response);
TKUnit.assertEqual(xhr.responseType, "json");
TKUnit.assertEqual(xhr.response.data, 42);
TKUnit.assertEqual(xhr.responseType, "");
TKUnit.assertEqual(xhr.response, "{\"data\": 42}");
}
export function test_xhr_responseType_switched_to_JSON_if_headers_content_type_has_json_suffix() {
export function test_xhr_responseType__should_not_switch_to_JSON_if_headers_content_type_has_json_suffix() {
const xhr = <any>new XMLHttpRequest();
const response = {
statusCode: 200,
@@ -340,8 +341,8 @@ export function test_xhr_responseType_switched_to_JSON_if_headers_content_type_h
};
xhr._loadResponse(response);
TKUnit.assertEqual(xhr.responseType, "json");
TKUnit.assertEqual(xhr.response.data, 42);
TKUnit.assertEqual(xhr.responseType, "");
TKUnit.assertEqual(xhr.response, "{\"data\": 42}");
}
export function test_sets_status_and_statusText(done) {
@@ -376,11 +377,13 @@ export function test_responseType(done) {
xhr.responseType = "";
xhr.responseType = "text";
xhr.responseType = "json";
xhr.responseType = "blob";
xhr.responseType = "arraybuffer";
TKUnit.assertThrows(
() => xhr.responseType = "arraybuffer",
() => xhr.responseType = "document",
"Didn't raise on unsupported type.",
"Response type of 'arraybuffer' not supported."
"Response type of 'document' not supported."
);
done(null);
}
@@ -403,9 +406,57 @@ export function test_getResponseHeader() {
TKUnit.assertEqual(xhr.getResponseHeader("Content-Type"), "application/json");
}
export function test_soap_content_types_recognized_as_text() {
const xhr = <any>new XMLHttpRequest();
export var test_XMLHttpRequest_contentReceivedArrayBufferProperly = function (done) {
// <snippet module="xhr" title="xhr">
// ### Receive Blob
// ``` JavaScript
let xhr = new XMLHttpRequest();
xhr.open("GET", "https://httpbin.org/image/jpeg");
xhr.responseType = "arraybuffer";
xhr.onreadystatechange = function () {
if (xhr.readyState > 3) {
// <hide>
try {
TKUnit.assertEqual(xhr.getResponseHeader("Content-Length"), "35588");
TKUnit.assertEqual(xhr.getResponseHeader("Content-Type"), "image/jpeg");
TKUnit.assertEqual((xhr.response as ArrayBuffer).byteLength, 35588);
done(null);
}
catch (err) {
done(err);
}
// </hide>
}
};
xhr.send();
// ```
// </snippet>
};
TKUnit.assertTrue(xhr.isTextContentType("text/xml"), "text/xml failed to be recognized as a text response type");
TKUnit.assertTrue(xhr.isTextContentType("application/xml"), "application/xml failed to be recognized as a text response type");
}
export var test_XMLHttpRequest_contentReceivedBlobProperly = function (done) {
// <snippet module="xhr" title="xhr">
// ### Receive Blob
// ``` JavaScript
let xhr = new XMLHttpRequest();
xhr.open("GET", "https://httpbin.org/image/jpeg");
xhr.responseType = "blob";
xhr.onreadystatechange = function () {
if (xhr.readyState > 3) {
// <hide>
try {
TKUnit.assertEqual(xhr.getResponseHeader("Content-Length"), "35588");
TKUnit.assertEqual(xhr.getResponseHeader("Content-Type"), "image/jpeg");
TKUnit.assertEqual((xhr.response as Blob).size, 35588);
TKUnit.assertEqual((xhr.response as Blob).type, "image/jpeg");
done(null);
}
catch (err) {
done(err);
}
// </hide>
}
};
xhr.send();
// ```
// </snippet>
};