javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-15 11:01:21 +08:00
Code Issues Packages Projects Releases Wiki Activity

refactor: move getPlatform to helpers

Browse Source
This commit is contained in:
Igor Randjelovic
2020-11-19 22:20:48 +01:00
parent 054d4e6f87
commit e23c8356af
4 changed files with 24 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
packages/webpack5/src/configuration/base.ts
View File

@ -5,6 +5,7 @@ import {
getDistPath,
getEntryPath,
getPackageJson,
getPlatform,
} from '../helpers/project';
import { CleanWebpackPlugin } from 'clean-webpack-plugin';
@ -15,7 +16,7 @@ import TerserPlugin from 'terser-webpack-plugin';
export default function (config: Config, env: IWebpackEnv): Config {
const entryPath = getEntryPath();
const distPath = getDistPath();
const platform = determinePlatformFromEnv(env);
const platform = getPlatform();
const packageJson = getPackageJson();
const mode = env.production ? 'production' : 'development';
@ -175,20 +176,8 @@ export default function (config: Config, env: IWebpackEnv): Config {
}
function shouldIncludeInspectorModules(env: IWebpackEnv): boolean {
const platform = determinePlatformFromEnv(env);
const platform = getPlatform();
// todo: check if core modules are external
// todo: check if we are testing
return platform === 'ios';
}
function determinePlatformFromEnv(env: IWebpackEnv): Platform {
if (env?.android) {
return 'android';
}
if (env?.ios) {
return 'ios';
}
throw new Error('You need to provide a target platform!');
}