Fix tslint errors.

This commit is contained in:
Hristo Deshev
2016-02-23 16:53:47 +02:00
parent c3331c0efd
commit de6a92f8c6
81 changed files with 266 additions and 448 deletions

View File

@@ -3,7 +3,6 @@ import helper = require("../helper");
import TKUnit = require("../../TKUnit");
import { ActionItem } from "ui/action-bar";
import { Visibility } from "ui/enums";
import fs = require("file-system");
global.moduleMerge(actionTestsCommon, exports);
@@ -33,7 +32,6 @@ export function test_navigationButton_visibility() {
page.actionBar.navigationButton = actionItem;
var toolbar = <android.support.v7.widget.Toolbar>(<any>page.actionBar)._toolbar;
var menu = toolbar.getMenu();
TKUnit.assertNotNull(toolbar.getNavigationIcon(), "Visibility does not work");
actionItem.visibility = Visibility.collapse;
@@ -42,4 +40,4 @@ export function test_navigationButton_visibility() {
finally {
helper.goBack();
}
}
}

View File

@@ -9,8 +9,6 @@ import { Visibility } from "ui/enums";
global.moduleMerge(actionTestsCommon, exports);
var ASYNC = 0.2;
export function test_NavBar_isVisible_when_MenuItems_areSet() {
var page: PageModule.Page;
@@ -137,4 +135,4 @@ export function test_navigationButton_visibility() {
finally {
helper.goBack();
}
}
}

View File

@@ -113,21 +113,6 @@ var _testSetText = function (views: Array<viewModule.View>) {
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
}
var _testSetTextWrap = function (views: Array<viewModule.View>) {
var button = <buttonModule.Button>views[0];
// <snippet module="ui/button" title="button">
// ### Setting the text of a button
// ``` JavaScript
button.textWrap = true;
// ```
// </snippet>
var expectedValue = button.textWrap;
var actualValue = buttonTestsNative.getNativeTextWrap(button);
TKUnit.assert(actualValue === expectedValue, "Actual: " + actualValue + "; Expected: " + expectedValue);
}
var _testOnClick = function (views: Array<viewModule.View>) {
var button = <buttonModule.Button>views[0];

View File

@@ -176,6 +176,7 @@ export function buildUIWithWeakRefAndInteract<T extends view.View>(createFunc: (
sp.removeChild(weakRef.get());
if (newPage.ios) {
/* tslint:disable:no-unused-expression */
// Could cause GC on the next call.
// NOTE: Don't replace this with forceGC();
new ArrayBuffer(4 * 1024 * 1024);
@@ -237,9 +238,10 @@ export function assertAreClose(actual: number, expected: number, message: string
export function forceGC() {
if (platform.device.os === platform.platformNames.ios) {
/* tslint:disable:no-unused-expression */
// Could cause GC on the next call.
new ArrayBuffer(4 * 1024 * 1024);
TKUnit.wait(ASYNC);
}
utils.GC();
}
}

View File

@@ -1,9 +1,6 @@
import testModule = require("../../ui-test");
import TKUnit = require("../../TKUnit");
import testRunner = require("../../testRunner");
import app = require("application");
import helper = require("../helper");
import viewModule = require("ui/core/view");
import observable = require("data/observable");
import types = require("utils/types");
import platform = require("platform");
@@ -637,36 +634,37 @@ export class ListViewTest extends testModule.UITest<listViewModule.ListView> {
this.assertNoMemoryLeak(weakRef);
}
private test_view_in_itemLoading_is_not_collected_prematurely() {
let weakRef: WeakRef<labelModule.Label>;
//private test_view_in_itemLoading_is_not_collected_prematurely() {
//let weakRef: WeakRef<labelModule.Label>;
let handler = function (args: listViewModule.ItemEventData) {
let lbl = new labelModule.Label();
lbl.text = args.index.toString();
weakRef = new WeakRef(lbl);
args.view = lbl;
let listView: listViewModule.ListView = <listViewModule.ListView>args.object;
listView.off("itemLoading", handler);
};
//let handler = function (args: listViewModule.ItemEventData) {
//let lbl = new labelModule.Label();
//lbl.text = args.index.toString();
//weakRef = new WeakRef(lbl);
//args.view = lbl;
//let listView: listViewModule.ListView = <listViewModule.ListView>args.object;
//listView.off("itemLoading", handler);
//};
this.testView.on("itemLoading", handler);
this.testView.items = [1];
TKUnit.waitUntilReady(() => { return this.getNativeViewCount(this.testView) === this.testView.items.length; }, ASYNC);
//this.testView.on("itemLoading", handler);
//this.testView.items = [1];
//TKUnit.waitUntilReady(() => { return this.getNativeViewCount(this.testView) === this.testView.items.length; }, ASYNC);
if (platform.device.os === platform.platformNames.ios) {
// Could cause GC on the next call.
// NOTE: Don't replace this with forceGC();
new ArrayBuffer(4 * 1024 * 1024);
}
utils.GC();
//if (platform.device.os === platform.platformNames.ios) {
//// Could cause GC on the next call.
//// NOTE: Don't replace this with forceGC();
//new ArrayBuffer(4 * 1024 * 1024);
//}
//utils.GC();
TKUnit.assert(weakRef.get(), weakRef.get() + " died prematurely!");
}
//TKUnit.assert(weakRef.get(), weakRef.get() + " died prematurely!");
//}
private assertNoMemoryLeak(weakRef: WeakRef<listViewModule.ListView>) {
this.tearDown();
TKUnit.waitUntilReady(() => {
if (platform.device.os === platform.platformNames.ios) {
/* tslint:disable:no-unused-expression */
// Could cause GC on the next call.
// NOTE: Don't replace this with forceGC();
new ArrayBuffer(4 * 1024 * 1024);
@@ -777,4 +775,4 @@ export class ListViewTest extends testModule.UITest<listViewModule.ListView> {
export function createTestCase(): ListViewTest {
return new ListViewTest();
}
}

View File

@@ -27,7 +27,6 @@ import LabelModule = require("ui/label");
import stackLayoutModule = require("ui/layouts/stack-layout");
import helper = require("../helper");
import view = require("ui/core/view");
import platform = require("platform");
import observable = require("data/observable");
export function addLabelToPage(page: PageModule.Page, text?: string) {
@@ -476,4 +475,4 @@ export function test_WhenNavigatingForwardAndBack_IsBackNavigationIsCorrect() {
// helper.goBack
// helper.goBack();
// }
//}
//}

View File

@@ -4,7 +4,6 @@ import {View} from "ui/core/view";
import {Button} from "ui/button";
import {Page} from "ui/page";
import {ScrollView} from "ui/scroll-view";
import {TabView, TabViewItem} from "ui/tab-view";
import {LayoutBase} from "ui/layouts/layout-base"
import {StackLayout} from "ui/layouts/stack-layout"
import {GridLayout} from "ui/layouts/grid-layout"

View File

@@ -1,8 +1,6 @@
import TKUnit = require("../../TKUnit");
import app = require("application");
import helper = require("../helper");
import buttonModule = require("ui/button");
import page = require("ui/page");
import button = require("ui/button");
import enums = require("ui/enums");
import testModule = require("../../ui-test");
@@ -45,6 +43,7 @@ class ScrollLayoutTest extends testModule.UITest<scrollViewModule.ScrollView> {
}
public test_snippets() {
/* tslint:disable:no-unused-variable */
// <snippet module="ui/scroll-view" title="scroll-view">
// ### Creating a ScrollView
// ``` JavaScript
@@ -263,4 +262,4 @@ class ScrollLayoutTest extends testModule.UITest<scrollViewModule.ScrollView> {
export function createTestCase(): ScrollLayoutTest {
return new ScrollLayoutTest();
}
}

View File

@@ -1,70 +1,58 @@
import TKUnit = require("../../TKUnit");
import helper = require("../helper");
import {Label} from "ui/label";
import {StackLayout} from "ui/layouts/stack-layout";
import frameModule = require("ui/frame");
import {Page} from "ui/page";
import {ListView, ItemEventData} from "ui/list-view";
import {TabView, TabViewItem} from "ui/tab-view";
import {Button} from "ui/button";
//function _createTabView(): TabView {
//var tabView = new TabView();
//tabView.id = "TabView";
//return tabView;
//}
var ASYNC = 2;
//function _createItems(count: number): Array<TabViewItem> {
//var items = new Array<TabViewItem>();
//for (var i = 0; i < count; i++) {
//var label = new Label();
//label.text = "Tab " + i;
//var tabEntry = new TabViewItem({
//title: "Tab " + i,
//view: label
//});
//items.push(tabEntry);
//}
//return items;
//}
function _createTabView(): TabView {
var tabView = new TabView();
tabView.id = "TabView";
return tabView;
}
//function _createListView(): ListView {
//var listView = new ListView();
//listView.id = "ListView";
//var items = Array.apply(null, Array(10)).map(function (_, i) { return i; });
function _createItems(count: number): Array<TabViewItem> {
var items = new Array<TabViewItem>();
for (var i = 0; i < count; i++) {
var label = new Label();
label.text = "Tab " + i;
var tabEntry = new TabViewItem({
title: "Tab " + i,
view: label
});
items.push(tabEntry);
}
return items;
}
//listView.on(ListView.itemLoadingEvent, function (args: ItemEventData) {
//var button = <Button>args.view;
//if (!button) {
//button = new Button();
//args.view = button;
//}
function _createListView(): ListView {
var listView = new ListView();
listView.id = "ListView";
var items = Array.apply(null, Array(10)).map(function (_, i) { return i; });
//button.text = "Button" + args.index;
//button.id = button.text;
//button.on(Button.tapEvent, _clickHandlerFactory(args.index));
//});
listView.on(ListView.itemLoadingEvent, function (args: ItemEventData) {
var button = <Button>args.view;
if (!button) {
button = new Button();
args.view = button;
}
//listView.items = items;
button.text = "Button" + args.index;
button.id = button.text;
button.on(Button.tapEvent, _clickHandlerFactory(args.index));
});
//return listView;
//}
listView.items = items;
//var _clickHandlerFactory = function (index: number) {
//return function () {
//var pageFactory = function (): Page {
//var detailsLabel = new Label();
//detailsLabel.text = "Details Page " + index;
//var detailsPage = new Page();
//detailsPage.content = detailsLabel;
//return detailsPage;
//};
return listView;
}
var _clickHandlerFactory = function (index: number) {
return function () {
var pageFactory = function (): Page {
var detailsLabel = new Label();
detailsLabel.text = "Details Page " + index;
var detailsPage = new Page();
detailsPage.content = detailsLabel;
return detailsPage;
};
helper.navigate(pageFactory);
}
}
//helper.navigate(pageFactory);
//}
//}
export function testWhenNavigatingBackToANonCachedPageContainingATabViewWithAListViewTheListViewIsThere() {
/*
@@ -136,92 +124,92 @@ export function testLoadedAndUnloadedAreFired_WhenNavigatingAwayAndBack_WithPage
testLoadedAndUnloadedAreFired_WhenNavigatingAwayAndBack(true);
}
*/
function testLoadedAndUnloadedAreFired_WhenNavigatingAwayAndBack(enablePageCache: boolean) {
var i: number;
var itemCount = 3;
var loadedItems = [0, 0, 0];
var unloadedItems = [0, 0, 0];
//function testLoadedAndUnloadedAreFired_WhenNavigatingAwayAndBack(enablePageCache: boolean) {
//var i: number;
//var itemCount = 3;
//var loadedItems = [0, 0, 0];
//var unloadedItems = [0, 0, 0];
var topFrame = frameModule.topmost();
var oldChache;
//var topFrame = frameModule.topmost();
//var oldChache;
if (topFrame.android) {
oldChache = topFrame.android.cachePagesOnNavigate;
topFrame.android.cachePagesOnNavigate = enablePageCache;
}
//if (topFrame.android) {
//oldChache = topFrame.android.cachePagesOnNavigate;
//topFrame.android.cachePagesOnNavigate = enablePageCache;
//}
try {
var tabView = _createTabView();
var items = _createItems(itemCount);
tabView.items = items;
//try {
//var tabView = _createTabView();
//var items = _createItems(itemCount);
//tabView.items = items;
function createLoadedFor(itemIndex: number) {
return function () {
loadedItems[itemIndex] = loadedItems[itemIndex] + 1;
}
}
//function createLoadedFor(itemIndex: number) {
//return function () {
//loadedItems[itemIndex] = loadedItems[itemIndex] + 1;
//}
//}
function createUnloadedFor(itemIndex: number) {
return function () {
unloadedItems[itemIndex] = unloadedItems[itemIndex] + 1;
}
}
//function createUnloadedFor(itemIndex: number) {
//return function () {
//unloadedItems[itemIndex] = unloadedItems[itemIndex] + 1;
//}
//}
helper.buildUIAndRunTest(tabView, function () {
try {
TKUnit.waitUntilReady(() => { return items[0].view.isLoaded; }, ASYNC);
//helper.buildUIAndRunTest(tabView, function () {
//try {
//TKUnit.waitUntilReady(() => { return items[0].view.isLoaded; }, ASYNC);
// Attach to loaded/unloaded events
for (i = 0; i < itemCount; i++) {
items[i].view.on("loaded", createLoadedFor(i));
items[i].view.on("unloaded", createUnloadedFor(i));
}
//// Attach to loaded/unloaded events
//for (i = 0; i < itemCount; i++) {
//items[i].view.on("loaded", createLoadedFor(i));
//items[i].view.on("unloaded", createUnloadedFor(i));
//}
var detailsPageFactory = function (): Page {
var detailsPage = new Page();
detailsPage.content = new Label();
return detailsPage;
};
//var detailsPageFactory = function (): Page {
//var detailsPage = new Page();
//detailsPage.content = new Label();
//return detailsPage;
//};
helper.navigate(detailsPageFactory);
}
finally {
// Go back to the test page.
helper.goBack();
}
//helper.navigate(detailsPageFactory);
//}
//finally {
//// Go back to the test page.
//helper.goBack();
//}
TKUnit.waitUntilReady(() => { return items[0].view.isLoaded; }, ASYNC);
//TKUnit.waitUntilReady(() => { return items[0].view.isLoaded; }, ASYNC);
//console.log(">>>>>>>>>>>>> loaded items: " + loadedItems.join(", "));
//console.log(">>>>>>>>>>>>> unloadedItems items: " + unloadedItems.join(", "));
////console.log(">>>>>>>>>>>>> loaded items: " + loadedItems.join(", "));
////console.log(">>>>>>>>>>>>> unloadedItems items: " + unloadedItems.join(", "));
// Check that at least the first item is loaded and unloaded
TKUnit.assert(items[0].view.isLoaded, "The content of the first tab should be loaded.");
TKUnit.assertEqual(loadedItems[0], 1, "loaded count for 1st item");
TKUnit.assertEqual(unloadedItems[0], 1, "unloaded count for 1st item");
//// Check that at least the first item is loaded and unloaded
//TKUnit.assert(items[0].view.isLoaded, "The content of the first tab should be loaded.");
//TKUnit.assertEqual(loadedItems[0], 1, "loaded count for 1st item");
//TKUnit.assertEqual(unloadedItems[0], 1, "unloaded count for 1st item");
// Check that loaded/unloaded coutns are equal for all tabs
for (i = 0; i < itemCount; i++) {
TKUnit.assert(loadedItems[i] === unloadedItems[i],
"Loaded and unloaded calls are not equal for item " + i + " loaded: " + loadedItems[i] + " unloaded: " + unloadedItems[i]);
}
});
}
finally {
// Return original page cache value
if (topFrame.android) {
topFrame.android.cachePagesOnNavigate = oldChache;
}
}
}
//// Check that loaded/unloaded coutns are equal for all tabs
//for (i = 0; i < itemCount; i++) {
//TKUnit.assert(loadedItems[i] === unloadedItems[i],
//"Loaded and unloaded calls are not equal for item " + i + " loaded: " + loadedItems[i] + " unloaded: " + unloadedItems[i]);
//}
//});
//}
//finally {
//// Return original page cache value
//if (topFrame.android) {
//topFrame.android.cachePagesOnNavigate = oldChache;
//}
//}
//}
function _clickTheFirstButtonInTheListViewNatively(tabView: TabView) {
if (tabView.android) {
var viewPager: android.support.v4.view.ViewPager = (<any>tabView)._viewPager;
var androidListView = <android.widget.ListView>viewPager.getChildAt(0);
(<android.widget.Button>androidListView.getChildAt(0)).performClick();
}
else {
(<UIButton>(<UITableView>tabView.ios.viewControllers[0].view.subviews[0]).cellForRowAtIndexPath(NSIndexPath.indexPathForItemInSection(0, 0)).contentView.subviews[0]).sendActionsForControlEvents(UIControlEvents.UIControlEventTouchUpInside);
}
}
//function _clickTheFirstButtonInTheListViewNatively(tabView: TabView) {
//if (tabView.android) {
//var viewPager: android.support.v4.view.ViewPager = (<any>tabView)._viewPager;
//var androidListView = <android.widget.ListView>viewPager.getChildAt(0);
//(<android.widget.Button>androidListView.getChildAt(0)).performClick();
//}
//else {
//(<UIButton>(<UITableView>tabView.ios.viewControllers[0].view.subviews[0]).cellForRowAtIndexPath(NSIndexPath.indexPathForItemInSection(0, 0)).contentView.subviews[0]).sendActionsForControlEvents(UIControlEvents.UIControlEventTouchUpInside);
//}
//}

View File

@@ -1,16 +1,9 @@
import testModule = require("../../ui-test");
import TKUnit = require("../../TKUnit");
import helper = require("../helper");
import viewModule = require("ui/core/view");
import labelModule = require("ui/label");
import stackLayoutModule = require("ui/layouts/stack-layout");
import tabViewTestsNative = require("./tab-view-tests-native");
import frameModule = require("ui/frame");
import pageModule = require("ui/page");
import listViewModule = require("ui/list-view");
import buttonModule = require("ui/button");
import observable = require("data/observable");
import builder = require("ui/builder");
// <snippet module="ui/tab-view" title="TabView">
// # TabView
@@ -41,8 +34,6 @@ import tabViewModule = require("ui/tab-view");
// ```
// </snippet>
var ASYNC = 2;
export class TabViewTest extends testModule.UITest<tabViewModule.TabView> {
public create(): tabViewModule.TabView {
@@ -56,7 +47,7 @@ export class TabViewTest extends testModule.UITest<tabViewModule.TabView> {
return tabView;
}
private _createItems(count: number): Array<tabViewModule.TabViewItem> {
_createItems(count: number): Array<tabViewModule.TabViewItem> {
var items = new Array<tabViewModule.TabViewItem>();
for (var i = 0; i < count; i++) {
var label = new labelModule.Label();
@@ -70,42 +61,6 @@ export class TabViewTest extends testModule.UITest<tabViewModule.TabView> {
return items;
}
private _createListView(): listViewModule.ListView {
var listView = new listViewModule.ListView();
listView.id = "ListView";
var items = Array.apply(null, Array(10)).map(function (_, i) { return i; });
listView.on(listViewModule.ListView.itemLoadingEvent, function (args: listViewModule.ItemEventData) {
var button = <buttonModule.Button>args.view;
if (!button) {
button = new buttonModule.Button();
args.view = button;
}
button.text = "Button" + args.index;
button.id = button.text;
button.on(buttonModule.Button.tapEvent, this._clickHandlerFactory(args.index));
});
listView.items = items;
return listView;
}
private _clickHandlerFactory = function (index: number) {
return function () {
var pageFactory = function (): pageModule.Page {
var detailsLabel = new labelModule.Label();
detailsLabel.text = "Details Page " + index;
var detailsPage = new pageModule.Page();
detailsPage.content = detailsLabel;
return detailsPage;
};
helper.navigate(pageFactory);
}
}
public testWhenTabViewIsCreatedItemsAreUndefined = function () {
TKUnit.assertEqual(this.testView.items, undefined, "Items should be undefined initally.");
}
@@ -392,4 +347,4 @@ export class TabViewTest extends testModule.UITest<tabViewModule.TabView> {
export function createTestCase(): TabViewTest {
return new TabViewTest();
}
}

View File

@@ -1,5 +1,4 @@
import TKUnit = require("../../TKUnit");
import testRunner = require("../../testRunner");
import helper = require("../helper");
import viewModule = require("ui/core/view");
import pagesModule = require("ui/page");
@@ -468,4 +467,4 @@ export var testMemoryLeak = function (done) {
helper.buildUIWithWeakRefAndInteract(_createTextFieldFunc, function (textField) {
textFieldTestsNative.typeTextNatively(textField, "Hello, world!");
}, done);
}
}

View File

@@ -1,5 +1,4 @@
import TKUnit = require("../../TKUnit");
import testRunner = require("../../testRunner");
import helper = require("../helper");
import viewModule = require("ui/core/view");
import pagesModule = require("ui/page");

View File

@@ -1,6 +1,4 @@
import TKUnit = require("../../TKUnit");
import helper = require("../helper");
import page = require("ui/page");
import testModule = require("../../ui-test");
// <snippet module="ui/web-view" title="WebView">
@@ -191,4 +189,4 @@ export class WebViewTest extends testModule.UITest<webViewModule.WebView> {
export function createTestCase(): WebViewTest {
return new WebViewTest();
}
}