diff --git a/packages/webpack5/scripts/jest.setup.ts b/packages/webpack5/scripts/jest.setup.ts index 38e3489a5..a6bf18bd0 100644 --- a/packages/webpack5/scripts/jest.setup.ts +++ b/packages/webpack5/scripts/jest.setup.ts @@ -13,6 +13,12 @@ jest.mock('cosmiconfig', () => ({ }, })); +jest.mock('../src/helpers/config.ts', () => ({ + getValue(key, defaultValue) { + return defaultValue; + }, +})); + jest.mock('os', () => { const os = jest.requireActual('os'); @@ -23,27 +29,27 @@ jest.mock('os', () => { in0: [ { address: '127.0.0.1', - family: 'IPv4' + family: 'IPv4', }, { address: 'in0-ipv6-should-not-use', - family: 'IPv6' - } + family: 'IPv6', + }, ], in1: [ { address: '192.168.0.10', - family: 'IPv4' + family: 'IPv4', }, { address: 'in1-ipv6-should-not-use', - family: 'IPv6' - } - ] - } - } - } -}) + family: 'IPv6', + }, + ], + }; + }, + }; +}); jest.mock('path', () => { const path = jest.requireActual('path'); diff --git a/packages/webpack5/src/helpers/config.ts b/packages/webpack5/src/helpers/config.ts index 74b04ad35..3e8951a16 100644 --- a/packages/webpack5/src/helpers/config.ts +++ b/packages/webpack5/src/helpers/config.ts @@ -16,10 +16,10 @@ function getCLILib() { * * @param {string} key The key to get from the config. Supports dot-notation. */ -export function getValue(key: string): T { +export function getValue(key: string, defaultValue?: any): T { const lib = getCLILib(); - return (lib.projectConfigService as { getValue(key: string): T }).getValue( - key - ); + return (lib.projectConfigService as { + getValue(key: string, defaultValue?: any): T; + }).getValue(key, defaultValue); } diff --git a/packages/webpack5/src/stubs/default.config.stub.js b/packages/webpack5/src/stubs/default.config.stub.js index 07275b43b..a561e0e2b 100644 --- a/packages/webpack5/src/stubs/default.config.stub.js +++ b/packages/webpack5/src/stubs/default.config.stub.js @@ -3,7 +3,8 @@ const webpack = require("@nativescript/webpack"); module.exports = (env) => { webpack.init(env); - // todo: comments for common usage + // Learn how to customize: + // https://docs.nativescript.org/webpack return webpack.resolveConfig(); };