diff --git a/CHANGELOG.md b/CHANGELOG.md index 5c722d7c4..26375ca6c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,12 @@ +## [7.0.5](https://github.com/NativeScript/NativeScript/compare/7.0.4-core...7.0.5) (2020-09-23) + + +### Bug Fixes + +* **core:** bundle entry points and global handling ([#8884](https://github.com/NativeScript/NativeScript/issues/8884)) ([1f790ed](https://github.com/NativeScript/NativeScript/commit/1f790edc8032fd36bde4b7a24e4d1c1c4b4dea49)) + + + ## [7.0.4](https://github.com/NativeScript/NativeScript/compare/7.0.3-types-ios...7.0.4) (2020-09-23) diff --git a/package.json b/package.json index 3831dcb92..248a1b951 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "nativescript", - "version": "7.0.4", + "version": "7.0.5", "license": "MIT", "config": { "npm_alias": "npm" diff --git a/packages/core/globals/index.ts b/packages/core/globals/index.ts index d47733635..a5771d05f 100644 --- a/packages/core/globals/index.ts +++ b/packages/core/globals/index.ts @@ -360,4 +360,4 @@ export function initGlobal() { } if (!global.NativeScriptHasInitGlobal) { initGlobal(); -} +} \ No newline at end of file diff --git a/packages/core/package.json b/packages/core/package.json index 88e09e40c..71eeb2d70 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -3,7 +3,7 @@ "main": "index", "types": "index.d.ts", "description": "NativeScript Core Modules", - "version": "7.0.4", + "version": "7.0.5", "homepage": "https://nativescript.org", "repository": { "type": "git", diff --git a/packages/core/ui/text-base/text-base-common.ts b/packages/core/ui/text-base/text-base-common.ts index 08e2078e7..5f60c9aea 100644 --- a/packages/core/ui/text-base/text-base-common.ts +++ b/packages/core/ui/text-base/text-base-common.ts @@ -26,6 +26,26 @@ export abstract class TextBaseCommon extends View implements TextBaseDefinition public text: string; public formattedText: FormattedString; + /*** + * In the NativeScript Core; by default the nativeTextViewProtected points to the same value as nativeViewProtected. + * At this point no internal NS components need this indirection functionality. + * This indirection is used to allow support usage by third party components so they don't have to duplicate functionality. + * + * A third party component can just override the `nativeTextViewProtected` getter and return a different internal view and that view would be + * what all TextView/TextInput class features would be applied to. + * + * A example is the Android MaterialDesign TextInput class, it has a wrapper view of a TextInputLayout + * https://developer.android.com/reference/com/google/android/material/textfield/TextInputLayout + * which wraps the actual TextInput. This wrapper layout (TextInputLayout) must be assigned to the nativeViewProtected as the entire + * NS Core uses nativeViewProtected for everything related to layout, so that it can be measured, added to the parent view as a child, ect. + * + * However, its internal view would be the actual TextView/TextInput and to allow that sub-view to have the normal TextView/TextInput + * class features, which we expose and to allow them to work on it, the internal TextView/TextInput is what the needs to have the class values applied to it. + * + * So all code that works on what is expected to be a TextView/TextInput should use `nativeTextViewProtected` so that any third party + * components that need to have two separate components can work properly without them having to duplicate all the TextBase (and decendants) functionality + * by just overriding the nativeTextViewProtected getter. + **/ get nativeTextViewProtected() { return this.nativeViewProtected; }