javascript/NativeScript
1
0
Fork 0
mirror of https://github.com/NativeScript/NativeScript.git synced 2025-08-16 11:42:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7452 from NativeScript/mdonev/observable-array-splice-fix

Browse Source 
fix(observable-array): splice to notify correct amount of added items
This commit is contained in:
Manol Donev
2019-07-04 15:45:07 +03:00
committed by GitHub
parent e0fad4133b 8bd7fd2ba6
commit d8ef044469
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/data/observable-array-tests.ts
View File

@ -410,7 +410,7 @@ export const test_ObservableArray_spliceShouldRemoveAndInertSpecifiedNumberOfEle
// args.action is "splice". // args.action is "splice".
// args.index is the start index. // args.index is the start index.
// args.removed.length is equal to the number of deleted items. // args.removed.length is equal to the number of deleted items.
// args.addedCount is equal to the delta between number of inserted items and number of deleted items but not less than 0. // args.addedCount is equal to the amount of added and replaced items.
// >> (hide) // >> (hide)
result = args; result = args;
@ -421,7 +421,7 @@ export const test_ObservableArray_spliceShouldRemoveAndInertSpecifiedNumberOfEle
// << observable-array-splice-args-change // << observable-array-splice-args-change
TKUnit.assert(result.eventName === ObservableArray.changeEvent && result.action === ChangeType.Splice && TKUnit.assert(result.eventName === ObservableArray.changeEvent && result.action === ChangeType.Splice &&
result.removed.length === 2 && result.index === 1 && result.addedCount === 1, "ObservableArray splice() should raise 'change' event with correct args!"); result.removed.length === 2 && result.index === 1 && result.addedCount === 3, "ObservableArray splice() should raise 'change' event with correct args!");
}; };
export const test_ObservableArray_unshiftShouldInsertNewElementsFromTheStart = function () { export const test_ObservableArray_unshiftShouldInsertNewElementsFromTheStart = function () {

2
tns-core-modules/data/observable-array/observable-array.ts
View File

@ -207,7 +207,7 @@ export class ObservableArray<T> extends observable.Observable implements observa
action: ChangeType.Splice, action: ChangeType.Splice,
index: start, index: start,
removed: result, removed: result,
addedCount: this._array.length > length ? this._array.length - length : 0 addedCount: this._array.length + result.length - length
}); });
if (this._array.length !== length) { if (this._array.length !== length) {
this._notifyLengthChange(); this._notifyLengthChange();